Print this page
6595 sdev's devfsadm macros set a bad precedent

@@ -330,17 +330,17 @@
 } devname_devfsadm_state_t;
 
 extern volatile uint_t  devfsadm_state; /* atomic mask for devfsadm status */
 
 #define DEVNAME_DEVFSADM_SET_RUNNING(devfsadm_state)    \
-        devfsadm_state = DEVNAME_DEVFSADM_RUNNING
+        (devfsadm_state = DEVNAME_DEVFSADM_RUNNING)
 #define DEVNAME_DEVFSADM_SET_STOP(devfsadm_state)       \
-        devfsadm_state = DEVNAME_DEVFSADM_STOPPED
+        (devfsadm_state = DEVNAME_DEVFSADM_STOPPED)
 #define DEVNAME_DEVFSADM_SET_RUN(devfsadm_state)        \
-        devfsadm_state = DEVNAME_DEVFSADM_RUN
+        (devfsadm_state = DEVNAME_DEVFSADM_RUN)
 #define DEVNAME_DEVFSADM_IS_RUNNING(devfsadm_state)     \
-        devfsadm_state == DEVNAME_DEVFSADM_RUNNING
+        (devfsadm_state == DEVNAME_DEVFSADM_RUNNING)
 #define DEVNAME_DEVFSADM_HAS_RUN(devfsadm_state)        \
         (devfsadm_state == DEVNAME_DEVFSADM_RUN)
 
 #define SDEV_BLOCK_OTHERS(dv, cmd)      {       \
         ASSERT(MUTEX_HELD(&dv->sdev_lookup_lock));      \