Code Review for il_5688

Prepared by:Richard Lowe (richlowe) on 2015-Mar-23 21:41 -0400 EDT
Workspace:/builds/work/illumos/illumos-git (at baee3e8426ae)
Compare against: illumos/master (http://github.com/illumos/illumos-gate.git at e2c8add4a6ce)
Summary of changes: 644 lines changed: 504 ins; 6 del; 134 mod; 9639 unchg
Patch of changes: il_5688.patch
Printable review: il_5688.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/elfdump/Makefile.com

5688 ELF tools need to be more careful with dwarf data
2 lines changed: 0 ins; 1 del; 1 mod; 78 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/elfdump/common/_elfdump.h

5688 ELF tools need to be more careful with dwarf data
2 lines changed: 0 ins; 0 del; 2 mod; 245 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/elfdump/common/dwarf.c

5688 ELF tools need to be more careful with dwarf data
415 lines changed: 334 ins; 2 del; 79 mod; 597 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/elfdump/common/elfdump.c

5688 ELF tools need to be more careful with dwarf data
89 lines changed: 74 ins; 3 del; 12 mod; 5142 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/elfdump/common/elfdump.msg

5688 ELF tools need to be more careful with dwarf data
7 lines changed: 6 ins; 0 del; 1 mod; 653 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/include/dwarf.h

5688 ELF tools need to be more careful with dwarf data
13 lines changed: 8 ins; 0 del; 5 mod; 259 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/libld/common/libld.msg

5688 ELF tools need to be more careful with dwarf data
4 lines changed: 4 ins; 0 del; 0 mod; 1592 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/libld/common/unwind.c

5688 ELF tools need to be more careful with dwarf data
78 lines changed: 61 ins; 0 del; 17 mod; 779 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/tools/common/leb128.c

5688 ELF tools need to be more careful with dwarf data
34 lines changed: 17 ins; 0 del; 17 mod; 294 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.