Code Review for il_5595

Prepared by:Richard Lowe (richlowe) on 2015-Feb-19 12:43 -0500 EST
Workspace:/builds/work/illumos/illumos-git (at 82d5d349bf1f)
Compare against: illumos/master (http://github.com/illumos/illumos-gate.git at 6b35cb3cf158)
Summary of changes: 47 lines changed: 2 ins; 33 del; 12 mod; 5783 unchg
Patch of changes: il_5595.patch
Printable review: il_5595.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/Makefile.master

5595 libzpool won't build with a studio primary
5 lines changed: 0 ins; 4 del; 1 mod; 1166 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fm/eversholt/Makefile.esc.com

5595 libzpool won't build with a studio primary
2 lines changed: 0 ins; 2 del; 0 mod; 89 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/Makefile.kmdb.targ

5324 .comment section on kmdb kmods is not set properly
1 line changed: 1 ins; 0 del; 0 mod; 187 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/Makefile.module

5324 .comment section on kmdb kmods is not set properly
1 line changed: 1 ins; 0 del; 0 mod; 256 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libm/common/m9x/__fex_i386.c

5632 libm's use of _sse_hw is wrong and unnecessary (in that order)
4 lines changed: 0 ins; 1 del; 3 mod; 1688 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/ctf/cvt/ctfconvert.c

5595 libzpool won't build with a studio primary
12 lines changed: 0 ins; 9 del; 3 mod; 242 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/ctf/cvt/ctfmerge.c

5595 libzpool won't build with a studio primary
14 lines changed: 0 ins; 9 del; 5 mod; 994 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/ctf/cvt/ctftools.h

5595 libzpool won't build with a studio primary
1 line changed: 0 ins; 1 del; 0 mod; 448 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/ctf/cvt/output.c

5595 libzpool won't build with a studio primary
7 lines changed: 0 ins; 7 del; 0 mod; 713 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.