Code Review for il_5083

Prepared by:Richard Lowe (richlowe) on 2014-Aug-13 12:15 -0400 EDT
Workspace:/builds/work/illumos/illumos-git (at dafdd87e2deb)
Compare against: illumos/master (http://github.com/illumos/illumos-gate.git at c65ceeb86e91)
Summary of changes: 45 lines changed: 0 ins; 9 del; 36 mod; 23220 unchg
Patch of changes: il_5083.patch
Printable review: il_5083.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fs.d/ufs/mkfs/mkfs.c

5083 avoid undefined order of operations in assignments
2 lines changed: 0 ins; 0 del; 2 mod; 5860 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/intel/modules/generic_cpu/gcpu.c

5083 avoid undefined order of operations in assignments
1 line changed: 0 ins; 0 del; 1 mod; 708 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/scadm/sparc/mpxu/common/smq.c

5083 avoid undefined order of operations in assignments
8 lines changed: 0 ins; 5 del; 3 mod; 180 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/troff/nroff.d/n6.c

5083 avoid undefined order of operations in assignments
6 lines changed: 0 ins; 2 del; 4 mod; 502 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/troff/troff.d/t6.c

5083 avoid undefined order of operations in assignments
14 lines changed: 0 ins; 2 del; 12 mod; 846 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/hxge/hxge_virtual.c

5083 avoid undefined order of operations in assignments
2 lines changed: 0 ins; 0 del; 2 mod; 947 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/ib/adapters/hermon/hermon_cmd.c

5083 avoid undefined order of operations in assignments
1 line changed: 0 ins; 0 del; 1 mod; 3712 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/ib/adapters/tavor/tavor_cmd.c

5083 avoid undefined order of operations in assignments
1 line changed: 0 ins; 0 del; 1 mod; 3059 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/nxge/nxge_virtual.c

5083 avoid undefined order of operations in assignments
2 lines changed: 0 ins; 0 del; 2 mod; 4128 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/io/dktp/drvobj/strategy.c

5083 avoid undefined order of operations in assignments
6 lines changed: 0 ins; 0 del; 6 mod; 1463 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/serengeti/io/sghsc.c

5083 avoid undefined order of operations in assignments
2 lines changed: 0 ins; 0 del; 2 mod; 1815 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.