Code Review for il_4839

Prepared by:Richard Lowe (richlowe) on 2014-May-02 17:45 -0400 EDT
Workspace:/builds/work/illumos/illumos-git (at 66309e317c6e)
Compare against: illumos/master (http://github.com/illumos/illumos-gate.git at 5539384561c0)
Summary of changes: 53 lines changed: 30 ins; 2 del; 21 mod; 2232 unchg
Patch of changes: il_4839.patch
Printable review: il_4839.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/elfdump/common/gen_struct_layout.c

4839 3294 generated elfdump struct layouts by hand, shouldn't have
27 lines changed: 25 ins; 2 del; 0 mod; 622 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/elfdump/common/struct_layout_amd64.c

4839 3294 generated elfdump struct layouts by hand, shouldn't have
4 lines changed: 2 ins; 0 del; 2 mod; 406 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/elfdump/common/struct_layout_i386.c

4839 3294 generated elfdump struct layouts by hand, shouldn't have
18 lines changed: 3 ins; 0 del; 15 mod; 393 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/elfdump/common/struct_layout_sparc.c

4839 3294 generated elfdump struct layouts by hand, shouldn't have
2 lines changed: 0 ins; 0 del; 2 mod; 405 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/elfdump/common/struct_layout_sparcv9.c

4839 3294 generated elfdump struct layouts by hand, shouldn't have
2 lines changed: 0 ins; 0 del; 2 mod; 406 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.