Code Review for il_3999

Prepared by:Richard Lowe (richlowe) on 2013-Aug-09 16:25 -0400 EDT
Workspace:/builds/work/illumos/illumos-git (at 7c04019e342a)
Compare against: illumos/master (http://github.com/illumos/illumos-gate.git at ae449904a90a)
Summary of changes: 196 lines changed: 124 ins; 3 del; 69 mod; 10545 unchg
Patch of changes: il_3999.patch
Printable review: il_3999.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/dis/dis_target.c

4004 dis(1) can't deal with extended sections
10 lines changed: 8 ins; 0 del; 2 mod; 958 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/ar/common/ar.msg

4011 ar does weird things with extended ELF sections
2 lines changed: 2 ins; 0 del; 0 mod; 134 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/ar/common/file.c

4011 ar does weird things with extended ELF sections
30 lines changed: 27 ins; 0 del; 3 mod; 1615 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/libld/common/syms.c

3999 libld extended section handling is broken
2 lines changed: 0 ins; 0 del; 2 mod; 3133 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/librtld/common/dldump.c

4003 dldump() can't deal with extended sections
47 lines changed: 40 ins; 1 del; 6 mod; 837 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/librtld/common/librtld.msg

4003 dldump() can't deal with extended sections
2 lines changed: 2 ins; 0 del; 0 mod; 87 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/packages/common/SUNWonld-README

4003 dldump() can't deal with extended sections
3999 libld extended section handling is broken
2 lines changed: 2 ins; 0 del; 0 mod; 1650 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/pvs/common/pvs.c

4000 pvs can't deal with extended sections
8 lines changed: 7 ins; 0 del; 1 mod; 1290 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/pvs/common/pvs.msg

4000 pvs can't deal with extended sections
1 line changed: 1 ins; 0 del; 0 mod; 115 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/size/common/process.c

4009 size(1) can't find sections in relocatable objects with extended sections
48 lines changed: 6 ins; 0 del; 42 mod; 264 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libctf/common/ctf_lib.c

4005 libctf can't deal with extended sections
44 lines changed: 29 ins; 2 del; 13 mod; 462 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.