Code Review for il_3436

Prepared by:Richard Lowe (richlowe) on 2013-Jan-02 21:49 -0500 EST
Workspace:/builds/work/illumos/illumos-git (at 950c7fbff1b5)
Compare against: illumos/master (http://github.com/illumos/illumos-gate.git at 717fae565868)
Summary of changes: 54 lines changed: 28 ins; 10 del; 16 mod; 5524 unchg
Patch of changes: il_3436.patch
Printable review: il_3436.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/Makefile.check

3442 sgs checks should be run in normal builds
7 lines changed: 0 ins; 2 del; 5 mod; 168 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/Makefile

3442 sgs checks should be run in normal builds
2 lines changed: 2 ins; 0 del; 0 mod; 202 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/libld/common/libld.msg

3441 -zassert-deflib messages are in the wrong place
10 lines changed: 5 ins; 5 del; 0 mod; 1581 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/libld/common/place.c

3436 relocatable objects also need sloppy relocation
3439 discarded sections shouldn't end up on output lists
25 lines changed: 13 ins; 2 del; 10 mod; 1243 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/librtld_db/demo/Makefile.com

3440 librtld_db demos need warnings gagged
4 lines changed: 4 ins; 0 del; 0 mod; 82 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/librtld_db/demo/common/dis.c

3440 librtld_db demos need warnings gagged
1 line changed: 0 ins; 0 del; 1 mod; 181 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/packages/common/SUNWonld-README

3436 relocatable objects also need sloppy relocation
3439 discarded sections shouldn't end up on output lists
2 lines changed: 2 ins; 0 del; 0 mod; 1642 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/rtld/common/rtld.msg

3441 -zassert-deflib messages are in the wrong place
3 lines changed: 2 ins; 1 del; 0 mod; 425 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.