Code Review for il_3352

Prepared by:Richard Lowe (richlowe) on 2012-Nov-09 22:01 -0500 EST
Workspace:/builds/work/illumos/illumos-git (at 9b1fc24cc59c)
Compare against: illumos/master (http://github.com/illumos/illumos-gate.git at 25345e466695)
Summary of changes: 582 lines changed: 568 ins; 9 del; 5 mod; 6836 unchg
Patch of changes: il_3352.patch
Printable review: il_3352.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw exception_lists/packaging

3352 would like 64bit install libraries
11 lines changed: 11 ins; 0 del; 0 mod; 964 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/Targetdirs

3352 would like 64bit install libraries
11 lines changed: 11 ins; 0 del; 0 mod; 1941 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libbe/Makefile

3352 would like 64bit install libraries
2 lines changed: 2 ins; 0 del; 0 mod; 64 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libbe/Makefile.com

3352 would like 64bit install libraries
3 lines changed: 1 ins; 2 del; 0 mod; 66 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libbe/amd64/Makefile

3352 would like 64bit install libraries
30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libbe/sparcv9/Makefile

3352 would like 64bit install libraries
30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdhcputil/Makefile

3352 would like 64bit install libraries
4 lines changed: 2 ins; 2 del; 0 mod; 69 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libdhcputil/amd64/Makefile

3352 would like 64bit install libraries
29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libdhcputil/sparcv9/Makefile

3352 would like 64bit install libraries
29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libfdisk/amd64/Makefile

3352 would like 64bit install libraries
1 line changed: 0 ins; 1 del; 0 mod; 29 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libfdisk/sparcv9/Makefile

3352 would like 64bit install libraries
28 lines changed: 28 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libfstyp/Makefile

3352 would like 64bit install libraries
3 lines changed: 1 ins; 1 del; 1 mod; 54 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libfstyp/amd64/Makefile

3352 would like 64bit install libraries
28 lines changed: 28 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libfstyp/sparcv9/Makefile

3352 would like 64bit install libraries
27 lines changed: 27 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libinstzones/Makefile

3352 would like 64bit install libraries
2 lines changed: 2 ins; 0 del; 0 mod; 60 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libinstzones/amd64/Makefile

3352 would like 64bit install libraries
30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libinstzones/sparcv9/Makefile

3352 would like 64bit install libraries
30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libwanboot/Makefile

3352 would like 64bit install libraries
3 lines changed: 1 ins; 1 del; 1 mod; 75 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libwanboot/amd64/Makefile

3352 would like 64bit install libraries
32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libwanboot/sparcv9/Makefile

3352 would like 64bit install libraries
32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libwanbootutil/Makefile

3352 would like 64bit install libraries
3 lines changed: 1 ins; 1 del; 1 mod; 97 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libwanbootutil/amd64/Makefile

3352 would like 64bit install libraries
29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libwanbootutil/sparcv9/Makefile

3352 would like 64bit install libraries
29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libzoneinfo/Makefile

3352 would like 64bit install libraries
3 lines changed: 1 ins; 1 del; 1 mod; 51 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libzoneinfo/amd64/Makefile

3352 would like 64bit install libraries
28 lines changed: 28 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libzoneinfo/sparcv9/Makefile

3352 would like 64bit install libraries
29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/pylibbe/Makefile

3352 would like 64bit install libraries
2 lines changed: 2 ins; 0 del; 0 mod; 54 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/pylibbe/Makefile.com

3352 would like 64bit install libraries
2 lines changed: 2 ins; 0 del; 0 mod; 60 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/pylibbe/amd64/Makefile

3352 would like 64bit install libraries
29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/pylibbe/common/libbe_py.c

3352 would like 64bit install libraries
2 lines changed: 1 ins; 0 del; 1 mod; 1093 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/pylibbe/sparcv9/Makefile

3352 would like 64bit install libraries
29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/developer-library-lint.mf

3352 would like 64bit install libraries
3 lines changed: 3 ins; 0 del; 0 mod; 567 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/install-beadm.mf

3352 would like 64bit install libraries
7 lines changed: 7 ins; 0 del; 0 mod; 52 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/package-svr4.mf

3352 would like 64bit install libraries
3 lines changed: 3 ins; 0 del; 0 mod; 120 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/system-boot-wanboot-internal.mf

3352 would like 64bit install libraries
5 lines changed: 5 ins; 0 del; 0 mod; 51 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/system-boot-wanboot.mf

3352 would like 64bit install libraries
3 lines changed: 3 ins; 0 del; 0 mod; 60 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/system-library-install-libinstzones.mf

3352 would like 64bit install libraries
3 lines changed: 3 ins; 0 del; 0 mod; 40 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/system-library.mf

3352 would like 64bit install libraries
8 lines changed: 8 ins; 0 del; 0 mod; 1269 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.