Code Review for il_3265

Prepared by:Richard Lowe (richlowe) on 2012-Oct-11 22:38 -0400 EDT
Workspace:/builds/work/illumos/illumos-git (at d105e79264e6)
Compare against: illumos/master (http://github.com/illumos/illumos-gate.git at 3cb02613df33)
Summary of changes: 75 lines changed: 41 ins; 1 del; 33 mod; 9351 unchg
Patch of changes: il_3265.patch
Printable review: il_3265.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/elfdump/common/_elfdump.h

3265 link-editor builds bogus .eh_frame_hdr on ia32
1 line changed: 0 ins; 0 del; 1 mod; 246 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/elfdump/common/dwarf.c

3265 link-editor builds bogus .eh_frame_hdr on ia32
12 lines changed: 3 ins; 0 del; 9 mod; 666 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/elfdump/common/elfdump.c

3265 link-editor builds bogus .eh_frame_hdr on ia32
18 lines changed: 9 ins; 0 del; 9 mod; 5139 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/include/dwarf.h

3265 link-editor builds bogus .eh_frame_hdr on ia32
4 lines changed: 3 ins; 0 del; 1 mod; 260 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/libld/common/unwind.c

3265 link-editor builds bogus .eh_frame_hdr on ia32
10 lines changed: 7 ins; 0 del; 3 mod; 789 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/packages/common/SUNWonld-README

3265 link-editor builds bogus .eh_frame_hdr on ia32
1 line changed: 1 ins; 0 del; 0 mod; 1633 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/tools/common/leb128.c

3265 link-editor builds bogus .eh_frame_hdr on ia32
21 lines changed: 12 ins; 1 del; 8 mod; 288 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/head/link.h

3263 link.h should work in a largefile environment
8 lines changed: 6 ins; 0 del; 2 mod; 330 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.