Code Review for il_2976

Prepared by:Richard Lowe (richlowe) on 2016-Feb-25 15:39 -0500 EST
Workspace:/builds/work/illumos/illumos-git (at 250853efd9f0)
Compare against: illumos/master (http://github.com/illumos/illumos-gate.git at 633aa8079184)
Summary of changes: 115 lines changed: 36 ins; 73 del; 6 mod; 43572 unchg
Patch of changes: il_2976.patch
Printable review: il_2976.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fm/fmadm/common/faulty.c

2976 remove useless offsetof() macros
2 lines changed: 0 ins; 1 del; 1 mod; 1864 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/common/modules/ii/ii.c

2976 remove useless offsetof() macros
4 lines changed: 2 ins; 2 del; 0 mod; 425 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/common/modules/libumem/misc.h

2976 remove useless offsetof() macros
5 lines changed: 1 ins; 4 del; 0 mod; 63 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/pools/poolstat/poolstat.c

2976 remove useless offsetof() macros
3 lines changed: 1 ins; 2 del; 0 mod; 1023 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/stat/common/acquire_iodevs.c

2976 remove useless offsetof() macros
4 lines changed: 1 ins; 3 del; 0 mod; 1123 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/nvpair/nvpair.c

2976 remove useless offsetof() macros
5 lines changed: 2 ins; 3 del; 0 mod; 3297 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/head/iso/stddef_iso.h

3373 gcc >= 4.5 concerns about offsetof()
Portions contributed by: Igor Pashev <pashev.igor@gmail.com>
4 lines changed: 4 ins; 0 del; 0 mod; 93 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libumem/common/misc.h

2976 remove useless offsetof() macros
11 lines changed: 1 ins; 10 del; 0 mod; 131 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/lvm/libmeta/common/meta_statconcise.c

2976 remove useless offsetof() macros
4 lines changed: 1 ins; 3 del; 0 mod; 1889 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/avs/ns/rdc/rdc.c

2976 remove useless offsetof() macros
9 lines changed: 1 ins; 8 del; 0 mod; 1107 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/avs/ns/rdc/rdc_io.c

2976 remove useless offsetof() macros
8 lines changed: 1 ins; 7 del; 0 mod; 6717 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/avs/ns/sv/sv.c

2976 remove useless offsetof() macros
6 lines changed: 1 ins; 5 del; 0 mod; 2815 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/ipf/netinet/ip_fil.h

2976 remove useless offsetof() macros
3 lines changed: 0 ins; 3 del; 0 mod; 1616 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/drm/drmP.h

2976 remove useless offsetof() macros
1 line changed: 1 ins; 0 del; 0 mod; 1102 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/sfe/sfe_util.c

2976 remove useless offsetof() macros
4 lines changed: 1 ins; 3 del; 0 mod; 5416 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/vscan/vscan_svc.c

2976 remove useless offsetof() macros
2 lines changed: 1 ins; 1 del; 0 mod; 1366 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/ecppvar.h

2976 remove useless offsetof() macros
2 lines changed: 1 ins; 1 del; 0 mod; 521 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/ib/clients/of/sol_ofs/sol_cma.h

2976 remove useless offsetof() macros
4 lines changed: 1 ins; 3 del; 0 mod; 374 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/sysmacros.h

3373 gcc >= 4.5 concerns about offsetof()
Portions contributed by: Igor Pashev <pashev.igor@gmail.com>
4 lines changed: 4 ins; 0 del; 0 mod; 386 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/usb/clients/audio/usb_ac/usb_ac.h

2976 remove useless offsetof() macros
9 lines changed: 1 ins; 8 del; 0 mod; 361 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/usb/clients/video/usbvc/usbvc_var.h

2976 remove useless offsetof() macros
3 lines changed: 1 ins; 2 del; 0 mod; 390 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/xen/io/xnb.h

3373 gcc >= 4.5 concerns about offsetof()
Portions contributed by: Igor Pashev <pashev.igor@gmail.com>
3 lines changed: 1 ins; 0 del; 2 mod; 213 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/xen/io/xnf.h

3373 gcc >= 4.5 concerns about offsetof()
Portions contributed by: Igor Pashev <pashev.igor@gmail.com>
2 lines changed: 0 ins; 0 del; 2 mod; 181 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/xen/public/io/ring.h

3373 gcc >= 4.5 concerns about offsetof()
Portions contributed by: Igor Pashev <pashev.igor@gmail.com>
7 lines changed: 6 ins; 0 del; 1 mod; 306 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun/io/scsi/adapters/sf.c

2976 remove useless offsetof() macros
4 lines changed: 1 ins; 3 del; 0 mod; 7235 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/io/rmclomv.c

2976 remove useless offsetof() macros
2 lines changed: 1 ins; 1 del; 0 mod; 3558 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.