Code Review for il_11057

Prepared by:Richard Lowe on 2019-May-22 03:21 +0000 UTC
Workspace:/builds/richlowe/illumos-git (at d2e4fde329b5)
Compare against: illumos/master (http://github.com/illumos/illumos-gate.git at 3f1d0a2eaba9)
Summary of changes: 98 lines changed: 91 ins; 0 del; 7 mod; 7866 unchg
Patch of changes: il_11057.patch
Printable review: il_11057.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/libld/common/entry.c

11057 hidden undefined weak symbols should not leave relocations
11058 libld entrance descriptor assertions get NDEBUG check backwards
1 line changed: 0 ins; 0 del; 1 mod; 502 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/libld/common/machrel.amd.c

11057 hidden undefined weak symbols should not leave relocations
11058 libld entrance descriptor assertions get NDEBUG check backwards
29 lines changed: 28 ins; 0 del; 1 mod; 1709 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/libld/common/machrel.intel.c

11057 hidden undefined weak symbols should not leave relocations
11058 libld entrance descriptor assertions get NDEBUG check backwards
29 lines changed: 28 ins; 0 del; 1 mod; 1720 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/libld/common/machrel.sparc.c

11057 hidden undefined weak symbols should not leave relocations
11058 libld entrance descriptor assertions get NDEBUG check backwards
38 lines changed: 34 ins; 0 del; 4 mod; 2266 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/packages/common/SUNWonld-README

11057 hidden undefined weak symbols should not leave relocations
11058 libld entrance descriptor assertions get NDEBUG check backwards
1 line changed: 1 ins; 0 del; 0 mod; 1669 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.