Code Review for il_10471

Prepared by:Richard Lowe on 2019-Feb-28 22:40 +0000 UTC
Workspace:/builds/richlowe/illumos-git (at 9de63d252e32)
Compare against: illumos/master (http://github.com/illumos/illumos-gate.git at d8fc057eca26)
Summary of changes: 937 lines changed: 898 ins; 20 del; 19 mod; 4117 unchg
Patch of changes: il_10471.patch
Printable review: il_10471.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/libld/common/machrel.amd.c

10471 ld(1) amd64 LD->LE TLS transition causes memory corruption
2 lines changed: 0 ins; 1 del; 1 mod; 1709 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/packages/common/SUNWonld-README

10471 ld(1) amd64 LD->LE TLS transition causes memory corruption
1 line changed: 1 ins; 0 del; 0 mod; 1664 unchg

------ ------ ------ ------ ------ Old --- Patch --- usr/src/cmd/sgs/test/ld/x64/tls/ie/README (deleted)

10367 ld(1) tests should be a real test suite
10368 want an ld(1) regression test for i386 LD tls transition (10267)
9 lines changed: 0 ins; 9 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/pkg/manifests/system-test-elftest.mf

10471 ld(1) amd64 LD->LE TLS transition causes memory corruption
10367 ld(1) tests should be a real test suite
10368 want an ld(1) regression test for i386 LD tls transition (10267)
57 lines changed: 57 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/test/Makefile

10367 ld(1) tests should be a real test suite
10368 want an ld(1) regression test for i386 LD tls transition (10267)
9 lines changed: 7 ins; 0 del; 2 mod; 20 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/elf-tests/Makefile

10367 ld(1) tests should be a real test suite
10368 want an ld(1) regression test for i386 LD tls transition (10267)
20 lines changed: 20 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/elf-tests/cmd/Makefile

10367 ld(1) tests should be a real test suite
10368 want an ld(1) regression test for i386 LD tls transition (10267)
38 lines changed: 38 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/elf-tests/cmd/elftest.ksh

10367 ld(1) tests should be a real test suite
10368 want an ld(1) regression test for i386 LD tls transition (10267)
49 lines changed: 49 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/elf-tests/doc/Makefile

10367 ld(1) tests should be a real test suite
10368 want an ld(1) regression test for i386 LD tls transition (10267)
36 lines changed: 36 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/elf-tests/doc/README

10367 ld(1) tests should be a real test suite
10368 want an ld(1) regression test for i386 LD tls transition (10267)
59 lines changed: 59 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/elf-tests/runfiles/Makefile

10367 ld(1) tests should be a real test suite
10368 want an ld(1) regression test for i386 LD tls transition (10267)
40 lines changed: 40 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/elf-tests/runfiles/default.run

10471 ld(1) amd64 LD->LE TLS transition causes memory corruption
10367 ld(1) tests should be a real test suite
10368 want an ld(1) regression test for i386 LD tls transition (10267)
37 lines changed: 37 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/elf-tests/tests/Makefile

10367 ld(1) tests should be a real test suite
10368 want an ld(1) regression test for i386 LD tls transition (10267)
21 lines changed: 21 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/elf-tests/tests/assert-deflib/Makefile

10367 ld(1) tests should be a real test suite
10368 want an ld(1) regression test for i386 LD tls transition (10267)
48 lines changed: 48 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old New Patch Raw usr/src/test/elf-tests/tests/assert-deflib/link.c (renamed from usr/src/cmd/sgs/test/ld/assert-deflib/link.c)

10367 ld(1) tests should be a real test suite
10368 want an ld(1) regression test for i386 LD tls transition (10267)
0 lines changed: 0 ins; 0 del; 0 mod; 23 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/test/elf-tests/tests/assert-deflib/test-deflib.sh (renamed and modified from usr/src/cmd/sgs/test/ld/assert-deflib/test-deflib.sh)

10367 ld(1) tests should be a real test suite
10368 want an ld(1) regression test for i386 LD tls transition (10267)
6 lines changed: 2 ins; 1 del; 3 mod; 131 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/elf-tests/tests/tls/Makefile

10367 ld(1) tests should be a real test suite
10368 want an ld(1) regression test for i386 LD tls transition (10267)
19 lines changed: 19 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/elf-tests/tests/tls/amd64/Makefile

10471 ld(1) amd64 LD->LE TLS transition causes memory corruption
10367 ld(1) tests should be a real test suite
10368 want an ld(1) regression test for i386 LD tls transition (10267)
19 lines changed: 19 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/elf-tests/tests/tls/amd64/ie/Makefile

10367 ld(1) tests should be a real test suite
10368 want an ld(1) regression test for i386 LD tls transition (10267)
58 lines changed: 58 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/test/elf-tests/tests/tls/amd64/ie/Makefile.test (renamed and modified from usr/src/cmd/sgs/test/ld/x64/tls/ie/Makefile)

10367 ld(1) tests should be a real test suite
10368 want an ld(1) regression test for i386 LD tls transition (10267)
15 lines changed: 1 ins; 9 del; 5 mod; 73 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/elf-tests/tests/tls/amd64/ie/README

10367 ld(1) tests should be a real test suite
10368 want an ld(1) regression test for i386 LD tls transition (10267)
5 lines changed: 5 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/test/elf-tests/tests/tls/amd64/ie/amd64-ie-test.sh (renamed and modified from usr/src/cmd/sgs/test/ld/x64/tls/ie/x64-ie-test.sh)

10367 ld(1) tests should be a real test suite
10368 want an ld(1) regression test for i386 LD tls transition (10267)
5 lines changed: 2 ins; 0 del; 3 mod; 59 unchg

------ ------ ------ ------ ------ Old New Patch Raw usr/src/test/elf-tests/tests/tls/amd64/ie/orig/style1-func.c (renamed from usr/src/cmd/sgs/test/ld/x64/tls/ie/orig/style1-func.c)

10367 ld(1) tests should be a real test suite
10368 want an ld(1) regression test for i386 LD tls transition (10267)
0 lines changed: 0 ins; 0 del; 0 mod; 24 unchg

------ ------ ------ ------ ------ Old New Patch Raw usr/src/test/elf-tests/tests/tls/amd64/ie/orig/style1-main.c (renamed from usr/src/cmd/sgs/test/ld/x64/tls/ie/orig/style1-main.c)

10367 ld(1) tests should be a real test suite
10368 want an ld(1) regression test for i386 LD tls transition (10267)
0 lines changed: 0 ins; 0 del; 0 mod; 29 unchg

------ ------ ------ ------ ------ Old New Patch Raw usr/src/test/elf-tests/tests/tls/amd64/ie/orig/style2.c (renamed from usr/src/cmd/sgs/test/ld/x64/tls/ie/orig/style2.c)

10367 ld(1) tests should be a real test suite
10368 want an ld(1) regression test for i386 LD tls transition (10267)
0 lines changed: 0 ins; 0 del; 0 mod; 25 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/test/elf-tests/tests/tls/amd64/ie/style1-func-with-r12.s (renamed and modified from usr/src/cmd/sgs/test/ld/x64/tls/ie/style1-func-with-r12.s)

10367 ld(1) tests should be a real test suite
10368 want an ld(1) regression test for i386 LD tls transition (10267)
1 line changed: 0 ins; 0 del; 1 mod; 38 unchg

------ ------ ------ ------ ------ Old New Patch Raw usr/src/test/elf-tests/tests/tls/amd64/ie/style1-func-with-r13.s (renamed from usr/src/cmd/sgs/test/ld/x64/tls/ie/style1-func-with-r13.s)

10367 ld(1) tests should be a real test suite
10368 want an ld(1) regression test for i386 LD tls transition (10267)
0 lines changed: 0 ins; 0 del; 0 mod; 38 unchg

------ ------ ------ ------ ------ Old New Patch Raw usr/src/test/elf-tests/tests/tls/amd64/ie/style1-func.s (renamed from usr/src/cmd/sgs/test/ld/x64/tls/ie/style1-func.s)

10367 ld(1) tests should be a real test suite
10368 want an ld(1) regression test for i386 LD tls transition (10267)
0 lines changed: 0 ins; 0 del; 0 mod; 38 unchg

------ ------ ------ ------ ------ Old New Patch Raw usr/src/test/elf-tests/tests/tls/amd64/ie/style1-main.s (renamed from usr/src/cmd/sgs/test/ld/x64/tls/ie/style1-main.s)

10367 ld(1) tests should be a real test suite
10368 want an ld(1) regression test for i386 LD tls transition (10267)
0 lines changed: 0 ins; 0 del; 0 mod; 60 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/test/elf-tests/tests/tls/amd64/ie/style2-with-badness.s (renamed and modified from usr/src/cmd/sgs/test/ld/x64/tls/ie/style2-with-badness.s)

10367 ld(1) tests should be a real test suite
10368 want an ld(1) regression test for i386 LD tls transition (10267)
1 line changed: 0 ins; 0 del; 1 mod; 46 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/test/elf-tests/tests/tls/amd64/ie/style2-with-r12.s (renamed and modified from usr/src/cmd/sgs/test/ld/x64/tls/ie/style2-with-r12.s)

10367 ld(1) tests should be a real test suite
10368 want an ld(1) regression test for i386 LD tls transition (10267)
2 lines changed: 1 ins; 0 del; 1 mod; 47 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/test/elf-tests/tests/tls/amd64/ie/style2-with-r13.s (renamed and modified from usr/src/cmd/sgs/test/ld/x64/tls/ie/style2-with-r13.s)

10367 ld(1) tests should be a real test suite
10368 want an ld(1) regression test for i386 LD tls transition (10267)
1 line changed: 0 ins; 0 del; 1 mod; 47 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/test/elf-tests/tests/tls/amd64/ie/style2.s (renamed and modified from usr/src/cmd/sgs/test/ld/x64/tls/ie/style2.s)

10367 ld(1) tests should be a real test suite
10368 want an ld(1) regression test for i386 LD tls transition (10267)
1 line changed: 0 ins; 0 del; 1 mod; 46 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/elf-tests/tests/tls/amd64/ld/Makefile

10471 ld(1) amd64 LD->LE TLS transition causes memory corruption
51 lines changed: 51 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/elf-tests/tests/tls/amd64/ld/Makefile.test

10471 ld(1) amd64 LD->LE TLS transition causes memory corruption
38 lines changed: 38 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/elf-tests/tests/tls/amd64/ld/amd64-ld-test.sh

10471 ld(1) amd64 LD->LE TLS transition causes memory corruption
46 lines changed: 46 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/elf-tests/tests/tls/amd64/ld/ld-with-addend.s

10471 ld(1) amd64 LD->LE TLS transition causes memory corruption
43 lines changed: 43 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/elf-tests/tests/tls/i386/Makefile

10367 ld(1) tests should be a real test suite
10368 want an ld(1) regression test for i386 LD tls transition (10267)
19 lines changed: 19 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/elf-tests/tests/tls/i386/ld/Makefile

10367 ld(1) tests should be a real test suite
10368 want an ld(1) regression test for i386 LD tls transition (10267)
51 lines changed: 51 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/elf-tests/tests/tls/i386/ld/Makefile.test

10367 ld(1) tests should be a real test suite
10368 want an ld(1) regression test for i386 LD tls transition (10267)
38 lines changed: 38 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/elf-tests/tests/tls/i386/ld/half-ldm.s

10367 ld(1) tests should be a real test suite
10368 want an ld(1) regression test for i386 LD tls transition (10267)
49 lines changed: 49 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/elf-tests/tests/tls/i386/ld/i386-ld-test.sh

10367 ld(1) tests should be a real test suite
10368 want an ld(1) regression test for i386 LD tls transition (10267)
43 lines changed: 43 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.