Code Review for il_10366-4

Prepared by:Richard Lowe on 2019-Apr-08 18:52 +0000 UTC
Workspace:/builds/richlowe/illumos-git (at a58c27ec6ca6)
Compare against: illumos/master (http://github.com/illumos/illumos-gate.git at 640abd28701e)
Summary of changes: 952 lines changed: 656 ins; 54 del; 242 mod; 43375 unchg
Patch of changes: il_10366-4.patch
Printable review: il_10366-4.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/file/Makefile 

10476 file(1) could be smatch clean
3 lines changed: 0 ins; 3 del; 0 mod; 112 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/file/elf_read.c 

10476 file(1) could be smatch clean
10366 ld(1) should support GNU-style linker sets
10581 ld(1) should know kernel modules are a thing
58 lines changed: 41 ins; 5 del; 12 mod; 542 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/file/elf_read.h 

10366 ld(1) should support GNU-style linker sets
10581 ld(1) should know kernel modules are a thing
13 lines changed: 7 ins; 2 del; 4 mod; 100 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/file/file.c 

10476 file(1) could be smatch clean
10366 ld(1) should support GNU-style linker sets
10581 ld(1) should know kernel modules are a thing
10 lines changed: 6 ins; 0 del; 4 mod; 1896 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/file/magicutils.c 

10476 file(1) could be smatch clean
12 lines changed: 0 ins; 2 del; 10 mod; 1130 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/dump/common/dump.c 

10366 ld(1) should support GNU-style linker sets
10581 ld(1) should know kernel modules are a thing
1 line changed: 1 ins; 0 del; 0 mod; 2130 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/include/_libelf.h 

10366 ld(1) should support GNU-style linker sets
10581 ld(1) should know kernel modules are a thing
1 line changed: 1 ins; 0 del; 0 mod; 57 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/include/libld.h 

10366 ld(1) should support GNU-style linker sets
10581 ld(1) should know kernel modules are a thing
28 lines changed: 6 ins; 0 del; 22 mod; 1548 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/include/sgs.h 

10366 ld(1) should support GNU-style linker sets
10581 ld(1) should know kernel modules are a thing
2 lines changed: 1 ins; 0 del; 1 mod; 274 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/libconv/common/dynamic.c 

10366 ld(1) should support GNU-style linker sets
10581 ld(1) should know kernel modules are a thing
11 lines changed: 6 ins; 0 del; 5 mod; 982 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/libconv/common/dynamic.msg 

10366 ld(1) should support GNU-style linker sets
10581 ld(1) should know kernel modules are a thing
4 lines changed: 3 ins; 0 del; 1 mod; 428 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/libconv/common/elf.c 

10366 ld(1) should support GNU-style linker sets
10581 ld(1) should know kernel modules are a thing
1 line changed: 1 ins; 0 del; 0 mod; 1229 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/libelf/common/gelf.c 

10366 ld(1) should support GNU-style linker sets
10581 ld(1) should know kernel modules are a thing
10 lines changed: 6 ins; 0 del; 4 mod; 1115 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/libelf/common/mapfile-vers 

10366 ld(1) should support GNU-style linker sets
10581 ld(1) should know kernel modules are a thing
1 line changed: 1 ins; 0 del; 0 mod; 177 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/libld/common/args.c 

10366 ld(1) should support GNU-style linker sets
10581 ld(1) should know kernel modules are a thing
95 lines changed: 75 ins; 2 del; 18 mod; 2163 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/libld/common/files.c 

10366 ld(1) should support GNU-style linker sets
10581 ld(1) should know kernel modules are a thing
16 lines changed: 15 ins; 0 del; 1 mod; 3723 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/libld/common/globals.c 

10366 ld(1) should support GNU-style linker sets
10581 ld(1) should know kernel modules are a thing
4 lines changed: 1 ins; 0 del; 3 mod; 136 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/libld/common/libld.msg 

10366 ld(1) should support GNU-style linker sets
10581 ld(1) should know kernel modules are a thing
32 lines changed: 16 ins; 0 del; 16 mod; 1588 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/libld/common/relocate.c 

10366 ld(1) should support GNU-style linker sets
10581 ld(1) should know kernel modules are a thing
6 lines changed: 0 ins; 0 del; 6 mod; 3154 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/libld/common/sections.c 

10366 ld(1) should support GNU-style linker sets
10581 ld(1) should know kernel modules are a thing
6 lines changed: 4 ins; 0 del; 2 mod; 3526 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/libld/common/syms.c 

10366 ld(1) should support GNU-style linker sets
10581 ld(1) should know kernel modules are a thing
105 lines changed: 97 ins; 2 del; 6 mod; 3127 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/libld/common/update.c 

10366 ld(1) should support GNU-style linker sets
10581 ld(1) should know kernel modules are a thing
25 lines changed: 19 ins; 0 del; 6 mod; 4310 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/packages/common/SUNWonld-README 

10366 ld(1) should support GNU-style linker sets
10581 ld(1) should know kernel modules are a thing
2 lines changed: 2 ins; 0 del; 0 mod; 1665 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/rtld/common/globals.c 

10366 ld(1) should support GNU-style linker sets
10581 ld(1) should know kernel modules are a thing
9 lines changed: 3 ins; 0 del; 6 mod; 284 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sgs/rtld/common/rtld.msg 

10366 ld(1) should support GNU-style linker sets
10581 ld(1) should know kernel modules are a thing
3 lines changed: 2 ins; 0 del; 1 mod; 426 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man1/ld.1
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw 

10366 ld(1) should support GNU-style linker sets
10581 ld(1) should know kernel modules are a thing
52 lines changed: 51 ins; 0 del; 1 mod; 1875 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/system-test-elftest.mf 

10366 ld(1) should support GNU-style linker sets
10581 ld(1) should know kernel modules are a thing
5 lines changed: 5 ins; 0 del; 0 mod; 57 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/test/elf-tests/runfiles/default.run 

10366 ld(1) should support GNU-style linker sets
10581 ld(1) should know kernel modules are a thing
4 lines changed: 3 ins; 1 del; 0 mod; 36 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/test/elf-tests/tests/Makefile 

10366 ld(1) should support GNU-style linker sets
10581 ld(1) should know kernel modules are a thing
1 line changed: 1 ins; 0 del; 0 mod; 21 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/elf-tests/tests/linker-sets/Makefile 

10366 ld(1) should support GNU-style linker sets
10581 ld(1) should know kernel modules are a thing
50 lines changed: 50 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/elf-tests/tests/linker-sets/in-use-check.sh 

10366 ld(1) should support GNU-style linker sets
10581 ld(1) should know kernel modules are a thing
53 lines changed: 53 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/elf-tests/tests/linker-sets/simple-src.c 

10366 ld(1) should support GNU-style linker sets
10581 ld(1) should know kernel modules are a thing
105 lines changed: 105 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/elf-tests/tests/linker-sets/simple.out 

10366 ld(1) should support GNU-style linker sets
10581 ld(1) should know kernel modules are a thing
10 lines changed: 10 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/elf-tests/tests/linker-sets/simple.sh 

10366 ld(1) should support GNU-style linker sets
10581 ld(1) should know kernel modules are a thing
51 lines changed: 51 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/link.h 

10366 ld(1) should support GNU-style linker sets
10581 ld(1) should know kernel modules are a thing
6 lines changed: 1 ins; 0 del; 5 mod; 636 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/genunix/Makefile 

10593 illumos build should not use kernel modules as link-editor input
13 lines changed: 11 ins; 0 del; 2 mod; 184 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/blade/platmod/Makefile 

10593 illumos build should not use kernel modules as link-editor input
4 lines changed: 0 ins; 2 del; 2 mod; 105 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/boston/platmod/Makefile 

10593 illumos build should not use kernel modules as link-editor input
5 lines changed: 0 ins; 2 del; 3 mod; 104 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/cheetah/Makefile 

10593 illumos build should not use kernel modules as link-editor input
2 lines changed: 0 ins; 0 del; 2 mod; 127 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/cheetahplus/Makefile 

10593 illumos build should not use kernel modules as link-editor input
2 lines changed: 0 ins; 0 del; 2 mod; 134 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/cherrystone/platmod/Makefile 

10593 illumos build should not use kernel modules as link-editor input
2 lines changed: 0 ins; 0 del; 2 mod; 110 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/chicago/platmod/Makefile 

10593 illumos build should not use kernel modules as link-editor input
2 lines changed: 0 ins; 0 del; 2 mod; 106 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/daktari/platmod/Makefile 

10593 illumos build should not use kernel modules as link-editor input
3 lines changed: 0 ins; 0 del; 3 mod; 110 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/darwin/platmod/Makefile 

10593 illumos build should not use kernel modules as link-editor input
4 lines changed: 0 ins; 2 del; 2 mod; 105 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/enchilada/platmod/Makefile 

10593 illumos build should not use kernel modules as link-editor input
4 lines changed: 0 ins; 2 del; 2 mod; 105 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/excalibur/platmod/Makefile 

10593 illumos build should not use kernel modules as link-editor input
4 lines changed: 0 ins; 2 del; 2 mod; 106 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/fjlite/platmod/Makefile 

10593 illumos build should not use kernel modules as link-editor input
4 lines changed: 0 ins; 2 del; 2 mod; 105 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/genunix/Makefile 

10593 illumos build should not use kernel modules as link-editor input
6 lines changed: 0 ins; 0 del; 6 mod; 173 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/grover/platmod/Makefile 

10593 illumos build should not use kernel modules as link-editor input
4 lines changed: 0 ins; 2 del; 2 mod; 105 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/hummingbird/Makefile 

10593 illumos build should not use kernel modules as link-editor input
2 lines changed: 0 ins; 0 del; 2 mod; 122 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/jalapeno/Makefile 

10593 illumos build should not use kernel modules as link-editor input
6 lines changed: 0 ins; 0 del; 6 mod; 128 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/javelin/platmod/Makefile 

10593 illumos build should not use kernel modules as link-editor input
4 lines changed: 0 ins; 2 del; 2 mod; 103 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/littleneck/platmod/Makefile 

10593 illumos build should not use kernel modules as link-editor input
4 lines changed: 0 ins; 2 del; 2 mod; 109 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/lw8/platmod/Makefile 

10593 illumos build should not use kernel modules as link-editor input
2 lines changed: 0 ins; 0 del; 2 mod; 114 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/opl/olympus_c/Makefile 

10593 illumos build should not use kernel modules as link-editor input
2 lines changed: 0 ins; 0 del; 2 mod; 115 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/platmod/Makefile 

10593 illumos build should not use kernel modules as link-editor input
4 lines changed: 0 ins; 2 del; 2 mod; 98 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/seattle/platmod/Makefile 

10593 illumos build should not use kernel modules as link-editor input
5 lines changed: 0 ins; 2 del; 3 mod; 104 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/serengeti/cheetah/Makefile 

10593 illumos build should not use kernel modules as link-editor input
2 lines changed: 0 ins; 0 del; 2 mod; 126 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/serengeti/cheetahplus/Makefile 

10593 illumos build should not use kernel modules as link-editor input
2 lines changed: 0 ins; 0 del; 2 mod; 132 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/serengeti/platmod/Makefile 

10593 illumos build should not use kernel modules as link-editor input
3 lines changed: 0 ins; 0 del; 3 mod; 114 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/serrano/Makefile 

10593 illumos build should not use kernel modules as link-editor input
6 lines changed: 0 ins; 0 del; 6 mod; 128 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/snowbird/platmod/Makefile 

10593 illumos build should not use kernel modules as link-editor input
4 lines changed: 0 ins; 2 del; 2 mod; 106 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/spitfire/Makefile 

10593 illumos build should not use kernel modules as link-editor input
2 lines changed: 0 ins; 0 del; 2 mod; 123 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/starcat/cheetah/Makefile 

10593 illumos build should not use kernel modules as link-editor input
2 lines changed: 0 ins; 0 del; 2 mod; 121 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/starcat/cheetahplus/Makefile 

10593 illumos build should not use kernel modules as link-editor input
2 lines changed: 0 ins; 0 del; 2 mod; 128 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/starcat/platmod/Makefile 

10593 illumos build should not use kernel modules as link-editor input
2 lines changed: 0 ins; 0 del; 2 mod; 96 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/taco/platmod/Makefile 

10593 illumos build should not use kernel modules as link-editor input
4 lines changed: 0 ins; 2 del; 2 mod; 105 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4u/tazmo/platmod/Makefile 

10593 illumos build should not use kernel modules as link-editor input
4 lines changed: 0 ins; 2 del; 2 mod; 105 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4v/generic/Makefile 

10593 illumos build should not use kernel modules as link-editor input
2 lines changed: 0 ins; 0 del; 2 mod; 127 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4v/genunix/Makefile 

10593 illumos build should not use kernel modules as link-editor input
6 lines changed: 0 ins; 0 del; 6 mod; 176 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4v/kt/Makefile 

10593 illumos build should not use kernel modules as link-editor input
2 lines changed: 0 ins; 0 del; 2 mod; 114 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4v/montoya/platmod/Makefile 

10593 illumos build should not use kernel modules as link-editor input
6 lines changed: 0 ins; 2 del; 4 mod; 111 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4v/niagara/Makefile 

10593 illumos build should not use kernel modules as link-editor input
2 lines changed: 0 ins; 0 del; 2 mod; 107 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4v/niagara2/Makefile 

10593 illumos build should not use kernel modules as link-editor input
4 lines changed: 0 ins; 1 del; 3 mod; 115 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4v/ontario/platmod/Makefile 

10593 illumos build should not use kernel modules as link-editor input
5 lines changed: 0 ins; 2 del; 3 mod; 112 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4v/platmod/Makefile 

10593 illumos build should not use kernel modules as link-editor input
4 lines changed: 0 ins; 2 del; 2 mod; 95 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sun4v/vfalls/Makefile 

10593 illumos build should not use kernel modules as link-editor input
5 lines changed: 1 ins; 2 del; 2 mod; 115 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.