Code Review for il_10051

Prepared by:Richard Lowe on 2018-Dec-07 21:22 +0000 UTC
Workspace:/builds/richlowe/illumos-git (at 59dce7ce2a5e)
Compare against: illumos/master (http://github.com/illumos/illumos-gate.git at a949e73d2676)
Summary of changes: 146 lines changed: 7 ins; 71 del; 68 mod; 8996 unchg
Patch of changes: il_10051.patch
Printable review: il_10051.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/Makefile.master

10051 cw(1) shouldn't have to translate -g
13 lines changed: 5 ins; 0 del; 8 mod; 1191 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/backup/Makefile.targ

10051 cw(1) shouldn't have to translate -g
5 lines changed: 0 ins; 3 del; 2 mod; 49 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/backup/dump/Makefile

10051 cw(1) shouldn't have to translate -g
6 lines changed: 0 ins; 5 del; 1 mod; 149 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/backup/lib/Makefile

10051 cw(1) shouldn't have to translate -g
2 lines changed: 0 ins; 0 del; 2 mod; 121 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/cmd-inet/sbin/dhcpagent/Makefile

10051 cw(1) shouldn't have to translate -g
4 lines changed: 0 ins; 4 del; 0 mod; 69 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/file/Makefile

10051 cw(1) shouldn't have to translate -g
2 lines changed: 0 ins; 0 del; 2 mod; 109 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fs.d/pcfs/fsck/Makefile

10051 cw(1) shouldn't have to translate -g
5 lines changed: 0 ins; 5 del; 0 mod; 73 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fs.d/smbclnt/mount/Makefile

10051 cw(1) shouldn't have to translate -g
8 lines changed: 0 ins; 6 del; 2 mod; 63 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fs.d/smbclnt/smbiod/Makefile

10051 cw(1) shouldn't have to translate -g
6 lines changed: 0 ins; 6 del; 0 mod; 61 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/fs.d/smbclnt/smbutil/Makefile

10051 cw(1) shouldn't have to translate -g
6 lines changed: 0 ins; 6 del; 0 mod; 89 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/geniconvtbl/Makefile.com

10051 cw(1) shouldn't have to translate -g
11 lines changed: 0 ins; 6 del; 5 mod; 189 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/hal/addons/cpufreq/Makefile

10051 cw(1) shouldn't have to translate -g
2 lines changed: 1 ins; 0 del; 1 mod; 65 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/idmap/idmap/Makefile

10051 cw(1) shouldn't have to translate -g
3 lines changed: 0 ins; 0 del; 3 mod; 80 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/idmap/nltest/Makefile

10051 cw(1) shouldn't have to translate -g
3 lines changed: 0 ins; 0 del; 3 mod; 64 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/idmap/test-getdc/Makefile

10051 cw(1) shouldn't have to translate -g
3 lines changed: 0 ins; 0 del; 3 mod; 67 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/sun4u/Makefile.kmdb

10051 cw(1) shouldn't have to translate -g
1 line changed: 0 ins; 0 del; 1 mod; 112 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/sun4v/Makefile.kmdb

10051 cw(1) shouldn't have to translate -g
1 line changed: 0 ins; 0 del; 1 mod; 128 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/print/printmgr/com/sun/admin/pm/server/Makefile

10051 cw(1) shouldn't have to translate -g
2 lines changed: 0 ins; 0 del; 2 mod; 124 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/sort/Makefile.com

10051 cw(1) shouldn't have to translate -g
3 lines changed: 0 ins; 0 del; 3 mod; 145 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/stmfproxy/stmfproxy/Makefile

10051 cw(1) shouldn't have to translate -g
5 lines changed: 0 ins; 5 del; 0 mod; 98 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/svc/svccfg/Makefile

10051 cw(1) shouldn't have to translate -g
3 lines changed: 0 ins; 2 del; 1 mod; 176 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/tnf/prex/Makefile.com

10051 cw(1) shouldn't have to translate -g
3 lines changed: 0 ins; 2 del; 1 mod; 113 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/zlook/Makefile.com

10051 cw(1) shouldn't have to translate -g
2 lines changed: 0 ins; 0 del; 2 mod; 49 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/sparc/Makefile.com

10051 cw(1) shouldn't have to translate -g
1 line changed: 0 ins; 0 del; 1 mod; 1431 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/sparcv9/Makefile.com

10051 cw(1) shouldn't have to translate -g
1 line changed: 0 ins; 0 del; 1 mod; 1342 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libexacct/Makefile.com

10051 cw(1) shouldn't have to translate -g
4 lines changed: 0 ins; 0 del; 4 mod; 57 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libsmbfs/Makefile.com

10051 cw(1) shouldn't have to translate -g
8 lines changed: 0 ins; 6 del; 2 mod; 129 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libtnfctl/Makefile.com

10051 cw(1) shouldn't have to translate -g
3 lines changed: 0 ins; 2 del; 1 mod; 116 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libzpool/Makefile.com

10051 cw(1) shouldn't have to translate -g
2 lines changed: 0 ins; 0 del; 2 mod; 112 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/smbsrv/libfksmbsrv/Makefile.com

10051 cw(1) shouldn't have to translate -g
3 lines changed: 0 ins; 0 del; 3 mod; 250 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/udapl/libdat/Makefile.com

10051 cw(1) shouldn't have to translate -g
7 lines changed: 0 ins; 2 del; 5 mod; 61 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/udapl/udapl_tavor/Makefile.com

10051 cw(1) shouldn't have to translate -g
5 lines changed: 0 ins; 2 del; 3 mod; 166 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/cw/cw.c

10051 cw(1) shouldn't have to translate -g
11 lines changed: 1 ins; 9 del; 1 mod; 1748 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/cxgbe/cxgbe/Makefile

10051 cw(1) shouldn't have to translate -g
1 line changed: 0 ins; 0 del; 1 mod; 84 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/cxgbe/t4nex/Makefile

10051 cw(1) shouldn't have to translate -g
1 line changed: 0 ins; 0 del; 1 mod; 116 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.