Code Review for il-def-privs

Prepared by:Richard Lowe (richlowe) on 2015-Dec-28 20:03 -0500 EST
Workspace:/builds/work/illumos/illumos-git (at ba453c9b9c9f)
Compare against: illumos/master (http://github.com/illumos/illumos-gate.git at 043552b77d3f)
Summary of changes: 120 lines changed: 75 ins; 6 del; 39 mod; 19827 unchg
Patch of changes: il-def-privs.patch
Printable review: il-def-privs.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/head/priv.h

uts: add a concept of a 'default' set of privileges, separate from 'basic'
1 line changed: 1 ins; 0 del; 0 mod; 86 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/inc/priv_private.h

uts: add a concept of a 'default' set of privileges, separate from 'basic'
4 lines changed: 2 ins; 2 del; 0 mod; 120 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/gen/priv_str_xlate.c

uts: add a concept of a 'default' set of privileges, separate from 'basic'
17 lines changed: 15 ins; 0 del; 2 mod; 452 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/gen/privlib.c

uts: add a concept of a 'default' set of privileges, separate from 'basic'
11 lines changed: 11 ins; 0 del; 0 mod; 1028 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/mapfile-vers

uts: add a concept of a 'default' set of privileges, separate from 'basic'
4 lines changed: 4 ins; 0 del; 0 mod; 3322 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/pam_modules/unix_cred/unix_cred.c

uts: add a concept of a 'default' set of privileges, separate from 'basic'
3 lines changed: 2 ins; 0 del; 1 mod; 670 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/Makefile

uts: add a concept of a 'default' set of privileges, separate from 'basic'
2 lines changed: 2 ins; 0 del; 0 mod; 2406 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man3c/priv_addset.3c
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

uts: add a concept of a 'default' set of privileges, separate from 'basic'
11 lines changed: 9 ins; 0 del; 2 mod; 235 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/man/man5/privileges.5
man: Cdiffs Udiffs Wdiffs Sdiffs Frames TXT HTML Raw

uts: add a concept of a 'default' set of privileges, separate from 'basic'
10 lines changed: 7 ins; 0 del; 3 mod; 1348 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/system-library.man3c.inc

uts: add a concept of a 'default' set of privileges, separate from 'basic'
1 line changed: 1 ins; 0 del; 0 mod; 1414 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/cred.c

uts: add a concept of a 'default' set of privileges, separate from 'basic'
1 line changed: 0 ins; 0 del; 1 mod; 1477 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/exec.c

uts: give privilege macros more sensible names
1 line changed: 0 ins; 0 del; 1 mod; 2032 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/policy.c

uts: give privilege macros more sensible names
6 lines changed: 0 ins; 0 del; 6 mod; 2577 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/priv.c

uts: add a concept of a 'default' set of privileges, separate from 'basic'
uts: give privilege macros more sensible names
14 lines changed: 9 ins; 0 del; 5 mod; 741 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/priv_defs

uts: add a concept of a 'default' set of privileges, separate from 'basic'
2 lines changed: 1 ins; 0 del; 1 mod; 622 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/privs.awk

uts: add a concept of a 'default' set of privileges, separate from 'basic'
uts: give privilege macros more sensible names
11 lines changed: 7 ins; 0 del; 4 mod; 402 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/priv.h

uts: add a concept of a 'default' set of privileges, separate from 'basic'
1 line changed: 1 ins; 0 del; 0 mod; 251 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/priv_impl.h

uts: give privilege macros more sensible names
14 lines changed: 0 ins; 2 del; 12 mod; 110 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/tsol/priv.h

uts: give privilege macros more sensible names
5 lines changed: 3 ins; 2 del; 0 mod; 114 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/syscall/ppriv.c

uts: give privilege macros more sensible names
1 line changed: 0 ins; 0 del; 1 mod; 420 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.