Prepared by: | Richard Lowe (richlowe) on 2016-Jan-11 15:37 -0500 EST |
---|---|
Workspace: | /builds/work/illumos/illumos-git (at 94167e252498) |
Compare against: | illumos/master (http://github.com/illumos/illumos-gate.git at 97e813095718) |
Summary of changes: | 49 lines changed: 36 ins; 1 del; 12 mod; 2975 unchg |
Patch of changes: | il-adjunct-fix.patch |
Printable review: | il-adjunct-fix.pdf |
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/Makefile.master
native tools must reliably use a native adjunct, even if that's inconvenient While it is perhaps convenient for native tools to use updated versions of certain things like libxml it is imperative that those versions are _also_ build for the build machine. Thus they need to be in the native adjunct (even if that native adjunct is thus not /). Fix the native adjunct to be rooted similarly to the adjunct proto (that is, at /), and fix SMF to use it correctly2 lines changed: 0 ins; 0 del; 2 mod; 1171 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/hal/Makefile.hal
gag Studio warnings that only occur with an adjunct proto Studio has no equivalent to -isystem, and no option to its -errhdr that seems equivalent. As such, we have to gag the warnings that are induced from the 3rd party headers when those headers are found via the adjunct, as they will not match Studio's seemingly hard-coded exception on `/usr/include`4 lines changed: 4 ins; 0 del; 0 mod; 72 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/latencytop/Makefile.com
gag Studio warnings that only occur with an adjunct proto Studio has no equivalent to -isystem, and no option to its -errhdr that seems equivalent. As such, we have to gag the warnings that are induced from the 3rd party headers when those headers are found via the adjunct, as they will not match Studio's seemingly hard-coded exception on `/usr/include`3 lines changed: 2 ins; 1 del; 0 mod; 83 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/intel/ia32/libpython2.6/Makefile
gag Studio warnings that only occur with an adjunct proto Studio has no equivalent to -isystem, and no option to its -errhdr that seems equivalent. As such, we have to gag the warnings that are induced from the 3rd party headers when those headers are found via the adjunct, as they will not match Studio's seemingly hard-coded exception on `/usr/include`4 lines changed: 4 ins; 0 del; 0 mod; 46 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/rmmount/Makefile
gag Studio warnings that only occur with an adjunct proto Studio has no equivalent to -isystem, and no option to its -errhdr that seems equivalent. As such, we have to gag the warnings that are induced from the 3rd party headers when those headers are found via the adjunct, as they will not match Studio's seemingly hard-coded exception on `/usr/include`4 lines changed: 4 ins; 0 del; 0 mod; 75 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/rmvolmgr/Makefile
gag Studio warnings that only occur with an adjunct proto Studio has no equivalent to -isystem, and no option to its -errhdr that seems equivalent. As such, we have to gag the warnings that are induced from the 3rd party headers when those headers are found via the adjunct, as they will not match Studio's seemingly hard-coded exception on `/usr/include`4 lines changed: 4 ins; 0 del; 0 mod; 76 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/svc/configd/Makefile
native tools must reliably use a native adjunct, even if that's inconvenient While it is perhaps convenient for native tools to use updated versions of certain things like libxml it is imperative that those versions are _also_ build for the build machine. Thus they need to be in the native adjunct (even if that native adjunct is thus not /). Fix the native adjunct to be rooted similarly to the adjunct proto (that is, at /), and fix SMF to use it correctly2 lines changed: 1 ins; 0 del; 1 mod; 131 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/svc/svccfg/Makefile
native tools must reliably use a native adjunct, even if that's inconvenient While it is perhaps convenient for native tools to use updated versions of certain things like libxml it is imperative that those versions are _also_ build for the build machine. Thus they need to be in the native adjunct (even if that native adjunct is thus not /). Fix the native adjunct to be rooted similarly to the adjunct proto (that is, at /), and fix SMF to use it correctly3 lines changed: 2 ins; 0 del; 1 mod; 175 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/volrmmount/Makefile
gag Studio warnings that only occur with an adjunct proto Studio has no equivalent to -isystem, and no option to its -errhdr that seems equivalent. As such, we have to gag the warnings that are induced from the 3rd party headers when those headers are found via the adjunct, as they will not match Studio's seemingly hard-coded exception on `/usr/include`4 lines changed: 4 ins; 0 del; 0 mod; 71 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libscf/Makefile.com
native tools must reliably use a native adjunct, even if that's inconvenient While it is perhaps convenient for native tools to use updated versions of certain things like libxml it is imperative that those versions are _also_ build for the build machine. Thus they need to be in the native adjunct (even if that native adjunct is thus not /). Fix the native adjunct to be rooted similarly to the adjunct proto (that is, at /), and fix SMF to use it correctly3 lines changed: 1 ins; 0 del; 2 mod; 82 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/policykit/Makefile.com
gag Studio warnings that only occur with an adjunct proto Studio has no equivalent to -isystem, and no option to its -errhdr that seems equivalent. As such, we have to gag the warnings that are induced from the 3rd party headers when those headers are found via the adjunct, as they will not match Studio's seemingly hard-coded exception on `/usr/include`4 lines changed: 4 ins; 0 del; 0 mod; 54 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/Makefile
pkg: If the adjunct proto is a package image, use it for dependency resolution9 lines changed: 6 ins; 0 del; 3 mod; 737 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/ctf/Makefile.ctf
native tools must reliably use a native adjunct, even if that's inconvenient While it is perhaps convenient for native tools to use updated versions of certain things like libxml it is imperative that those versions are _also_ build for the build machine. Thus they need to be in the native adjunct (even if that native adjunct is thus not /). Fix the native adjunct to be rooted similarly to the adjunct proto (that is, at /), and fix SMF to use it correctly1 line changed: 0 ins; 0 del; 1 mod; 47 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/ctf/cvt/Makefile.com
native tools must reliably use a native adjunct, even if that's inconvenient While it is perhaps convenient for native tools to use updated versions of certain things like libxml it is imperative that those versions are _also_ build for the build machine. Thus they need to be in the native adjunct (even if that native adjunct is thus not /). Fix the native adjunct to be rooted similarly to the adjunct proto (that is, at /), and fix SMF to use it correctly1 line changed: 0 ins; 0 del; 1 mod; 89 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/ctf/dump/Makefile.com
native tools must reliably use a native adjunct, even if that's inconvenient While it is perhaps convenient for native tools to use updated versions of certain things like libxml it is imperative that those versions are _also_ build for the build machine. Thus they need to be in the native adjunct (even if that native adjunct is thus not /). Fix the native adjunct to be rooted similarly to the adjunct proto (that is, at /), and fix SMF to use it correctly1 line changed: 0 ins; 0 del; 1 mod; 66 unchg
This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.