3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero

@@ -18,12 +18,14 @@
  *
  * CDDL HEADER END
  */
 /*
  * Copyright (c) 2005, 2010, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2012 by Delphix. All rights reserved.
  */
 
+
 /* Portions Copyright 2007 Jeremy Teo */
 
 #ifdef _KERNEL
 #include <sys/types.h>
 #include <sys/param.h>

@@ -804,11 +806,11 @@
         if (vap->va_type == VDIR) {
                 if (zfsvfs->z_replay) {
                         err = zap_create_claim_norm(zfsvfs->z_os, obj,
                             zfsvfs->z_norm, DMU_OT_DIRECTORY_CONTENTS,
                             obj_type, bonuslen, tx);
-                        ASSERT3U(err, ==, 0);
+                        ASSERT0(err);
                 } else {
                         obj = zap_create_norm(zfsvfs->z_os,
                             zfsvfs->z_norm, DMU_OT_DIRECTORY_CONTENTS,
                             obj_type, bonuslen, tx);
                 }

@@ -815,11 +817,11 @@
         } else {
                 if (zfsvfs->z_replay) {
                         err = dmu_object_claim(zfsvfs->z_os, obj,
                             DMU_OT_PLAIN_FILE_CONTENTS, 0,
                             obj_type, bonuslen, tx);
-                        ASSERT3U(err, ==, 0);
+                        ASSERT0(err);
                 } else {
                         obj = dmu_object_alloc(zfsvfs->z_os,
                             DMU_OT_PLAIN_FILE_CONTENTS, 0,
                             obj_type, bonuslen, tx);
                 }

@@ -997,11 +999,11 @@
                 zfs_xvattr_set(*zpp, (xvattr_t *)vap, tx);
 
         if (obj_type == DMU_OT_ZNODE ||
             acl_ids->z_aclp->z_version < ZFS_ACL_VERSION_FUID) {
                 err = zfs_aclset_common(*zpp, acl_ids->z_aclp, cr, tx);
-                ASSERT3P(err, ==, 0);
+                ASSERT0(err);
         }
         ZFS_OBJ_HOLD_EXIT(zfsvfs, obj);
 }
 
 /*

@@ -1418,11 +1420,11 @@
         error = dmu_object_set_blocksize(zp->z_zfsvfs->z_os, zp->z_id,
             size, 0, tx);
 
         if (error == ENOTSUP)
                 return;
-        ASSERT3U(error, ==, 0);
+        ASSERT0(error);
 
         /* What blocksize did we actually get? */
         dmu_object_size_from_db(sa_get_db(zp->z_sa_hdl), &zp->z_blksz, &dummy);
 }