3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero

*** 489,502 ****
           * Remove our reservation. The impl() routine avoids setting the
           * actual property, which would require the (already destroyed) ds.
           */
          dsl_dir_set_reservation_sync_impl(dd, 0, tx);
  
!         ASSERT3U(dd->dd_phys->dd_used_bytes, ==, 0);
!         ASSERT3U(dd->dd_phys->dd_reserved, ==, 0);
          for (t = 0; t < DD_USED_NUM; t++)
!                 ASSERT3U(dd->dd_phys->dd_used_breakdown[t], ==, 0);
  
          VERIFY(0 == zap_destroy(mos, dd->dd_phys->dd_child_dir_zapobj, tx));
          VERIFY(0 == zap_destroy(mos, dd->dd_phys->dd_props_zapobj, tx));
          VERIFY(0 == dsl_deleg_destroy(mos, dd->dd_phys->dd_deleg_zapobj, tx));
          VERIFY(0 == zap_remove(mos,
--- 489,502 ----
           * Remove our reservation. The impl() routine avoids setting the
           * actual property, which would require the (already destroyed) ds.
           */
          dsl_dir_set_reservation_sync_impl(dd, 0, tx);
  
!         ASSERT0(dd->dd_phys->dd_used_bytes);
!         ASSERT0(dd->dd_phys->dd_reserved);
          for (t = 0; t < DD_USED_NUM; t++)
!                 ASSERT0(dd->dd_phys->dd_used_breakdown[t]);
  
          VERIFY(0 == zap_destroy(mos, dd->dd_phys->dd_child_dir_zapobj, tx));
          VERIFY(0 == zap_destroy(mos, dd->dd_phys->dd_props_zapobj, tx));
          VERIFY(0 == dsl_deleg_destroy(mos, dd->dd_phys->dd_deleg_zapobj, tx));
          VERIFY(0 == zap_remove(mos,
*** 583,593 ****
          ASSERT(dmu_tx_is_syncing(tx));
  
          dmu_buf_will_dirty(dd->dd_dbuf, tx);
  
          mutex_enter(&dd->dd_lock);
!         ASSERT3U(dd->dd_tempreserved[tx->tx_txg&TXG_MASK], ==, 0);
          dprintf_dd(dd, "txg=%llu towrite=%lluK\n", tx->tx_txg,
              dd->dd_space_towrite[tx->tx_txg&TXG_MASK] / 1024);
          dd->dd_space_towrite[tx->tx_txg&TXG_MASK] = 0;
          mutex_exit(&dd->dd_lock);
  
--- 583,593 ----
          ASSERT(dmu_tx_is_syncing(tx));
  
          dmu_buf_will_dirty(dd->dd_dbuf, tx);
  
          mutex_enter(&dd->dd_lock);
!         ASSERT0(dd->dd_tempreserved[tx->tx_txg&TXG_MASK]);
          dprintf_dd(dd, "txg=%llu towrite=%lluK\n", tx->tx_txg,
              dd->dd_space_towrite[tx->tx_txg&TXG_MASK] / 1024);
          dd->dd_space_towrite[tx->tx_txg&TXG_MASK] = 0;
          mutex_exit(&dd->dd_lock);
  
*** 1332,1342 ****
          dmu_buf_will_dirty(dd->dd_dbuf, tx);
  
          /* remove from old parent zapobj */
          err = zap_remove(mos, dd->dd_parent->dd_phys->dd_child_dir_zapobj,
              dd->dd_myname, tx);
!         ASSERT3U(err, ==, 0);
  
          (void) strcpy(dd->dd_myname, ra->mynewname);
          dsl_dir_close(dd->dd_parent, dd);
          dd->dd_phys->dd_parent_obj = ra->newparent->dd_object;
          VERIFY(0 == dsl_dir_open_obj(dd->dd_pool,
--- 1332,1342 ----
          dmu_buf_will_dirty(dd->dd_dbuf, tx);
  
          /* remove from old parent zapobj */
          err = zap_remove(mos, dd->dd_parent->dd_phys->dd_child_dir_zapobj,
              dd->dd_myname, tx);
!         ASSERT0(err);
  
          (void) strcpy(dd->dd_myname, ra->mynewname);
          dsl_dir_close(dd->dd_parent, dd);
          dd->dd_phys->dd_parent_obj = ra->newparent->dd_object;
          VERIFY(0 == dsl_dir_open_obj(dd->dd_pool,
*** 1343,1353 ****
              ra->newparent->dd_object, NULL, dd, &dd->dd_parent));
  
          /* add to new parent zapobj */
          err = zap_add(mos, ra->newparent->dd_phys->dd_child_dir_zapobj,
              dd->dd_myname, 8, 1, &dd->dd_object, tx);
!         ASSERT3U(err, ==, 0);
  
  }
  
  int
  dsl_dir_rename(dsl_dir_t *dd, const char *newname)
--- 1343,1353 ----
              ra->newparent->dd_object, NULL, dd, &dd->dd_parent));
  
          /* add to new parent zapobj */
          err = zap_add(mos, ra->newparent->dd_phys->dd_child_dir_zapobj,
              dd->dd_myname, 8, 1, &dd->dd_object, tx);
!         ASSERT0(err);
  
  }
  
  int
  dsl_dir_rename(dsl_dir_t *dd, const char *newname)