Code Review for illumos-gate

Prepared by:Madhav Suresh <madhav.a.suresh@gmail.com> on 2012-Jul-26 14:19 -0700 PDT
Workspace:/data/madhav/illumos-gate (at be758e20c026)}
Compare against: ssh://anonhg@hg.illumos.org/illumos-gate (at 9f5f6c52ba19)
Summary of changes: 437 lines changed: 33 ins; 58 del; 346 mod; 77652 unchg
Patch of changes: illumos-gate.patch
Printable review: illumos-gate.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/zdb/Makefile.com 

3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero
5 lines changed: 2 ins; 0 del; 3 mod; 64 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/zdb/zdb.c 

3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero
3 lines changed: 0 ins; 0 del; 3 mod; 3247 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/zhack/Makefile.com 

3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero
1 line changed: 0 ins; 0 del; 1 mod; 66 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/zhack/zhack.c 

3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero
2 lines changed: 0 ins; 0 del; 2 mod; 538 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/ztest/Makefile.com 

3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero
3 lines changed: 0 ins; 0 del; 3 mod; 62 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/ztest/ztest.c 

3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero
57 lines changed: 0 ins; 2 del; 55 mod; 5946 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/nvpair/fnvpair.c 

3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero
58 lines changed: 0 ins; 0 del; 58 mod; 438 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/threads/assfail.c 

3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero
2 lines changed: 0 ins; 0 del; 2 mod; 461 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libzpool/Makefile.com 

3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero
3 lines changed: 1 ins; 0 del; 2 mod; 76 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libzpool/common/sys/zfs_context.h 

3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero
56 lines changed: 1 ins; 55 del; 0 mod; 577 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/disp/sysdc.c 

3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero
4 lines changed: 1 ins; 0 del; 3 mod; 1313 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/arc.c 

3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero
5 lines changed: 0 ins; 0 del; 5 mod; 4670 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/bpobj.c 

3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero
15 lines changed: 0 ins; 0 del; 15 mod; 485 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/bptree.c 

3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero
10 lines changed: 0 ins; 0 del; 10 mod; 214 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/dbuf.c 

3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero
3 lines changed: 0 ins; 0 del; 3 mod; 2717 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/dmu_objset.c 

3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero
4 lines changed: 0 ins; 0 del; 4 mod; 1846 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/dmu_send.c 

3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero
3 lines changed: 0 ins; 0 del; 3 mod; 1688 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/dmu_traverse.c 

3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero
1 line changed: 0 ins; 0 del; 1 mod; 568 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/dmu_tx.c 

3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero
1 line changed: 0 ins; 0 del; 1 mod; 1384 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/dnode.c 

3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero
37 lines changed: 0 ins; 0 del; 37 mod; 1959 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/dnode_sync.c 

3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero
4 lines changed: 0 ins; 0 del; 4 mod; 691 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/dsl_dataset.c 

3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero
27 lines changed: 0 ins; 1 del; 26 mod; 4276 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/dsl_deadlist.c 

3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero
23 lines changed: 0 ins; 0 del; 23 mod; 475 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/dsl_dir.c 

3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero
6 lines changed: 0 ins; 0 del; 6 mod; 1414 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/dsl_pool.c 

3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero
11 lines changed: 0 ins; 0 del; 11 mod; 856 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/dsl_scan.c 

3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero
11 lines changed: 0 ins; 0 del; 11 mod; 1733 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/dsl_synctask.c 

3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero
1 line changed: 0 ins; 0 del; 1 mod; 241 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/metaslab.c 

3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero
1 line changed: 0 ins; 0 del; 1 mod; 1654 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/spa.c 

3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero
6 lines changed: 0 ins; 0 del; 6 mod; 6320 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/space_map.c 

3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero
8 lines changed: 5 ins; 0 del; 3 mod; 613 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/vdev.c 

3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero
7 lines changed: 0 ins; 0 del; 7 mod; 3148 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/vdev_raidz.c 

3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero
3 lines changed: 0 ins; 0 del; 3 mod; 2147 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/zap.c 

3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero
5 lines changed: 0 ins; 0 del; 5 mod; 1363 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/zap_micro.c 

3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero
2 lines changed: 0 ins; 0 del; 2 mod; 1454 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/zfeature.c 

3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero
3 lines changed: 0 ins; 0 del; 3 mod; 411 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/zfs_debug.c 

3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero
4 lines changed: 2 ins; 0 del; 2 mod; 93 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/zfs_dir.c 

3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero
5 lines changed: 1 ins; 0 del; 4 mod; 1085 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/zfs_ioctl.c 

3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero
1 line changed: 0 ins; 0 del; 1 mod; 5905 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/zfs_rlock.c 

3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero
9 lines changed: 6 ins; 0 del; 3 mod; 599 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/zfs_vfsops.c 

3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero
1 line changed: 0 ins; 0 del; 1 mod; 2316 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/zfs_vnops.c 

3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero
9 lines changed: 4 ins; 0 del; 5 mod; 5247 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/zfs_znode.c 

3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero
6 lines changed: 2 ins; 0 del; 4 mod; 2117 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/zil.c 

3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero
2 lines changed: 0 ins; 0 del; 2 mod; 1997 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/zfs/zio.c 

3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero
1 line changed: 0 ins; 0 del; 1 mod; 3032 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/debug.h 

3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero
8 lines changed: 8 ins; 0 del; 0 mod; 146 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.