11506 smatch resync

*** 21,31 ****
  
  #
  # Copyright 2008 Sun Microsystems, Inc.  All rights reserved.
  # Use is subject to license terms.
  #
! # Copyright (c) 2018, Joyent, Inc.
  
  #
  #       Paths to the base of the uts directory trees
  #
  UTSBASE   = ../..
--- 21,32 ----
  
  #
  # Copyright 2008 Sun Microsystems, Inc.  All rights reserved.
  # Use is subject to license terms.
  #
! # Copyright 2019 Joyent, Inc.
! #
  
  #
  #       Paths to the base of the uts directory trees
  #
  UTSBASE   = ../..
*** 33,43 ****
  #
  #       Define the module and object file sets.
  #
  MODULE          = xge
  OBJECTS         = $(XGE_HAL_OBJS:%=$(OBJS_DIR)/%) $(XGE_OBJS:%=$(OBJS_DIR)/%)
- LINTS           = $(XGE_HAL_OBJS:%.o=$(LINTS_DIR)/%.ln) $(XGE_OBJS:%.o=$(LINTS_DIR)/%.ln)
  ROOTMODULE      = $(ROOT_DRV_DIR)/$(MODULE)
  
  #
  #       Include common rules.
  #
--- 34,43 ----
*** 45,55 ****
  
  #
  #       Define targets
  #
  ALL_TARGET      = $(BINARY)
- LINT_TARGET     = $(MODULE).lint
  INSTALL_TARGET  = $(BINARY) $(ROOTMODULE)
  
  #
  #       GENERAL PURPOUSE HAL FLAGS: Tuning HAL for Solaris specific modes
  #
--- 45,54 ----
*** 89,119 ****
  #
  #       Driver depends on MAC & IP
  #
  LDFLAGS         +=  -dy -N misc/mac -N drv/ip
  
- #       Lint flag
- #
- LINTFLAGS       += $(XGE_CFLAGS) -Xc99=%all
- 
- #
- # For now, disable these lint checks; maintainers should endeavor
- # to investigate and remove these for maximum lint coverage.
- # Please do not carry these forward to new Makefiles.
- #
- LINTTAGS        += -erroff=E_BAD_PTR_CAST_ALIGN
- LINTTAGS        += -erroff=E_STATIC_UNUSED
- LINTTAGS        += -erroff=E_PTRDIFF_OVERFLOW
- 
  CERRWARN        += -_gcc=-Wno-parentheses
  CERRWARN        += -_gcc=-Wno-unused-variable
  CERRWARN        += -_gcc=-Wno-unused-label
  CERRWARN        += -_gcc=-Wno-empty-body
  CERRWARN        += -_gcc=-Wno-uninitialized
  
  # needs work
! SMOFF += indenting,all_func_returns,no_if_block
  
  #
  #
  #       Default build targets.
  #
--- 88,108 ----
  #
  #       Driver depends on MAC & IP
  #
  LDFLAGS         +=  -dy -N misc/mac -N drv/ip
  
  CERRWARN        += -_gcc=-Wno-parentheses
  CERRWARN        += -_gcc=-Wno-unused-variable
  CERRWARN        += -_gcc=-Wno-unused-label
  CERRWARN        += -_gcc=-Wno-empty-body
  CERRWARN        += -_gcc=-Wno-uninitialized
  
  # needs work
! SMOFF += indenting
! SMOFF += all_func_returns
! SMOFF += no_if_block
! SMOFF += allocating_enough_data
  
  #
  #
  #       Default build targets.
  #
*** 125,140 ****
  
  clean:          $(CLEAN_DEPS)
  
  clobber:        $(CLOBBER_DEPS)
  
- lint:           $(LINT_DEPS)
- 
- modlintlib:     $(MODLINTLIB_DEPS)
- 
- clean.lint:     $(CLEAN_LINT_DEPS)
- 
  install:        $(INSTALL_DEPS)
  
  #
  #       Include common targets.
  #
--- 114,123 ----