11506 smatch resync

*** 23,33 ****
  #
  # Copyright 2007 Sun Microsystems, Inc.  All rights reserved.
  # Use is subject to license terms.
  # Copyright (c) 2011 Bayard G. Bell. All rights reserved.
  #
! # Copyright (c) 2018, Joyent, Inc.
  
  #
  #       Path to the base of the uts directory tree (usually /usr/src/uts).
  #
  UTSBASE = ../..
--- 23,34 ----
  #
  # Copyright 2007 Sun Microsystems, Inc.  All rights reserved.
  # Use is subject to license terms.
  # Copyright (c) 2011 Bayard G. Bell. All rights reserved.
  #
! # Copyright 2019 Joyent, Inc.
! #
  
  #
  #       Path to the base of the uts directory tree (usually /usr/src/uts).
  #
  UTSBASE = ../..
*** 35,45 ****
  #
  #       Define the module and object file sets.
  #
  MODULE          = spppcomp
  OBJECTS         = $(SPPPCOMP_OBJS:%=$(OBJS_DIR)/%)
- LINTS           = $(SPPPCOMP_OBJS:%.o=$(LINTS_DIR)/%.ln)
  ROOTMODULE      = $(USR_STRMOD_DIR)/$(MODULE)
  
  #
  #       Include common rules.
  #
--- 36,45 ----
*** 47,57 ****
  
  #
  #       Define targets
  #
  ALL_TARGET      = $(BINARY)
- LINT_TARGET     = $(MODULE).lint
  INSTALL_TARGET  = $(BINARY) $(ROOTMODULE)
  
  #
  #       Internal build definitions
  #
--- 47,56 ----
*** 60,83 ****
  # 
  #       Additional compiler definitions
  # 
  INC_PATH        += -I$(UTSBASE)/common/io/ppp/common
  
- #
- # For now, disable these lint checks; maintainers should endeavor
- # to investigate and remove these for maximum lint coverage.
- # Please do not carry these forward to new Makefiles.
- #
- LINTTAGS        += -erroff=E_BAD_PTR_CAST_ALIGN
- LINTTAGS        += -erroff=E_PTRDIFF_OVERFLOW
- LINTTAGS        += -erroff=E_ASSIGN_NARROW_CONV
- 
  CERRWARN        += -_gcc=-Wno-parentheses
  CERRWARN        += -_gcc=-Wno-uninitialized
  
  # needs work
! SMOFF += indenting
  
  #
  # Depends on sppp
  #
  LDFLAGS         += -dy -N drv/sppp
--- 59,73 ----
  #
  #       Additional compiler definitions
  #
  INC_PATH        += -I$(UTSBASE)/common/io/ppp/common
  
  CERRWARN        += -_gcc=-Wno-parentheses
  CERRWARN        += -_gcc=-Wno-uninitialized
  
  # needs work
! SMOFF += indenting,index_overflow
  
  #
  # Depends on sppp
  #
  LDFLAGS         += -dy -N drv/sppp
*** 93,113 ****
  
  clean:          $(CLEAN_DEPS)
  
  clobber:        $(CLOBBER_DEPS)
  
- lint:           $(LINT_DEPS)
- 
- modlintlib:     $(MODLINTLIB_DEPS)
- 
- clean.lint:     $(CLEAN_LINT_DEPS)
- 
  install:        $(INSTALL_DEPS)
  
- $(LINTS_DIR)/%.ln:              $(UTSBASE)/common/io/ppp/spppcomp/%.c
-         @($(LHEAD) $(LINT.c) $< $(LTAIL))
- 
  $(OBJS_DIR)/%.o:                $(UTSBASE)/common/io/ppp/spppcomp/%.c
          $(COMPILE.c) -o $@ $<
          $(CTFCONVERT_O)
  
  #
--- 83,94 ----