11506 smatch resync

*** 20,30 ****
  #
  #
  # Copyright 2009 Sun Microsystems, Inc.  All rights reserved.
  # Use is subject to license terms.
  # Copyright (c) 2011 Bayard G. Bell. All rights reserved.
! # Copyright (c) 2018, Joyent, Inc.
  #
  # This makefile drives the production of the emlxs driver kernel module.
  #
  # Path to the base of the uts directory tree (usually /usr/src/uts).
  #
--- 20,30 ----
  #
  #
  # Copyright 2009 Sun Microsystems, Inc.  All rights reserved.
  # Use is subject to license terms.
  # Copyright (c) 2011 Bayard G. Bell. All rights reserved.
! # Copyright 2019 Joyent, Inc.
  #
  # This makefile drives the production of the emlxs driver kernel module.
  #
  # Path to the base of the uts directory tree (usually /usr/src/uts).
  #
*** 34,44 ****
  #
  #       Define the module and object file sets.
  #
  MODULE          = emlxs
  OBJECTS         = $(EMLXS_OBJS:%=$(OBJS_DIR)/%)
- LINTS           = $(EMLXS_OBJS:%.o=$(LINTS_DIR)/%.ln)
  ROOTMODULE      = $(ROOT_DRV_DIR)/$(MODULE)
  CONF_SRCDIR     = $(UTSBASE)/common/io/fibre-channel/fca/emlxs
  
  #
  #       Include common rules.
--- 34,43 ----
*** 48,68 ****
  
  #
  #       Define targets
  #
  ALL_TARGET      = $(BINARY) $(SRC_CONFILE)
- LINT_TARGET     = $(MODULE).lint
  INSTALL_TARGET  = $(BINARY) $(ROOTMODULE) $(ROOT_CONFFILE)
  
  EMLXS_FLAGS             = -DEMLXS_I386
  EMLXS_FLAGS             += -DS11
  EMLXS_FLAGS             += -DVERSION=\"11\"
  EMLXS_FLAGS             += -DMACH=\"$(MACH)\"
  EMLXS_CFLAGS            = $(EMLXS_FLAGS)
  EMLXS_LFLAGS            = $(EMLXS_FLAGS)
  CFLAGS                  += $(EMLXS_CFLAGS) -DEMLXS_ARCH=\"$(CLASS)\"
- LINTTAGS                += $(EMLXS_LFLAGS) -DEMLXS_ARCH=\"$(CLASS)\"
  
  
  #
  #       Overrides and depends_on
  #
--- 47,65 ----
*** 80,104 ****
  #       triggered by -DS11; uses DDI calls to load FCA symbols
  #
  LDFLAGS         += -dy -Nmisc/md5 -Nmisc/sha1
  LDFLAGS         += -Nmisc/bignum -Nmisc/fctl
  
- #
- # For now, disable these lint checks; maintainers should endeavor
- # to investigate and remove these for maximum lint coverage.
- #
- LINTTAGS        += -erroff=E_BAD_PTR_CAST_ALIGN
- LINTTAGS        += -erroff=E_STATIC_UNUSED
- LINTTAGS        += -erroff=E_ASSIGN_NARROW_CONV
- LINTTAGS        += -erroff=E_SUSPICIOUS_COMPARISON
- LINTTAGS        += -erroff=E_INCONS_VAL_TYPE_DECL2
- 
  CERRWARN        += -_gcc=-Wno-parentheses
  CERRWARN        += -_gcc=-Wno-unused-label
  CERRWARN        += -_gcc=-Wno-uninitialized
  
! SMOFF += indenting,deref_check,all_func_returns
  
  # seems definitely wrong
  $(OBJS_DIR)/emlxs_fcf.o := SMOFF += logical_instead_of_bitwise
  
  #
--- 77,92 ----
  #       triggered by -DS11; uses DDI calls to load FCA symbols
  #
  LDFLAGS         += -dy -Nmisc/md5 -Nmisc/sha1
  LDFLAGS         += -Nmisc/bignum -Nmisc/fctl
  
  CERRWARN        += -_gcc=-Wno-parentheses
  CERRWARN        += -_gcc=-Wno-unused-label
  CERRWARN        += -_gcc=-Wno-uninitialized
  
! # needs work
! SMOFF += indenting,deref_check,all_func_returns,index_overflow
  
  # seems definitely wrong
  $(OBJS_DIR)/emlxs_fcf.o := SMOFF += logical_instead_of_bitwise
  
  #
*** 112,127 ****
  
  clean:          $(CLEAN_DEPS)
  
  clobber:        $(CLOBBER_DEPS)
  
- lint:           $(LINT_DEPS)
- 
- modlintlib:     $(MODLINTLIB_DEPS)
- 
- clean.lint:     $(CLEAN_LINT_DEPS)
- 
  install:        $(INSTALL_DEPS)
  
  #
  #       Include common targets.
  #
--- 100,109 ----