11506 smatch resync

*** 18,58 ****
  #include "smatch.h"
  
  int list_has_string(struct string_list *str_list, const char *str)
  {
          char *tmp;
  
          if (!str)
                  return 0;
  
          FOR_EACH_PTR(str_list, tmp) {
!                 if (strcmp(tmp, str) < 0)
                          continue;
!                 if (strcmp(tmp, str) == 0)
                          return 1;
                  return 0;
          } END_FOR_EACH_PTR(tmp);
          return 0;
  }
  
! void insert_string(struct string_list **str_list, const char *_new)
  {
          char *new = (char *)_new;
          char *tmp;
  
          FOR_EACH_PTR(*str_list, tmp) {
!                 if (strcmp(tmp, new) < 0)
                          continue;
!                 else if (strcmp(tmp, new) == 0) {
!                         return;
                  } else {
                          INSERT_CURRENT(alloc_string(new), tmp);
!                         return;
                  }
          } END_FOR_EACH_PTR(tmp);
          new = alloc_string(new);
          add_ptr_list(str_list, new);
  }
  
  struct string_list *clone_str_list(struct string_list *orig)
  {
          char *tmp;
--- 18,63 ----
  #include "smatch.h"
  
  int list_has_string(struct string_list *str_list, const char *str)
  {
          char *tmp;
+         int cmp;
  
          if (!str)
                  return 0;
  
          FOR_EACH_PTR(str_list, tmp) {
!                 cmp = strcmp(tmp, str);
!                 if (cmp < 0)
                          continue;
!                 if (cmp == 0)
                          return 1;
                  return 0;
          } END_FOR_EACH_PTR(tmp);
          return 0;
  }
  
! int insert_string(struct string_list **str_list, const char *_new)
  {
          char *new = (char *)_new;
          char *tmp;
+         int cmp;
  
          FOR_EACH_PTR(*str_list, tmp) {
!                 cmp = strcmp(tmp, new);
!                 if (cmp < 0)
                          continue;
!                 else if (cmp == 0) {
!                         return 0;
                  } else {
                          INSERT_CURRENT(alloc_string(new), tmp);
!                         return 1;
                  }
          } END_FOR_EACH_PTR(tmp);
          new = alloc_string(new);
          add_ptr_list(str_list, new);
+         return 1;
  }
  
  struct string_list *clone_str_list(struct string_list *orig)
  {
          char *tmp;