Print this page
11506 smatch resync
| Split |
Close |
| Expand all |
| Collapse all |
--- old/usr/src/tools/smatch/src/check_nospec.c
+++ new/usr/src/tools/smatch/src/check_nospec.c
1 1 /*
2 2 * Copyright (C) 2018 Oracle.
3 3 *
4 4 * This program is free software; you can redistribute it and/or
5 5 * modify it under the terms of the GNU General Public License
6 6 * as published by the Free Software Foundation; either version 2
7 7 * of the License, or (at your option) any later version.
8 8 *
9 9 * This program is distributed in the hope that it will be useful,
10 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 * GNU General Public License for more details.
13 13 *
14 14 * You should have received a copy of the GNU General Public License
15 15 * along with this program; if not, see http://www.gnu.org/copyleft/gpl.txt
16 16 */
17 17
18 18 #include <stdlib.h>
19 19 #include "parse.h"
20 20 #include "smatch.h"
21 21 #include "smatch_slist.h"
22 22 #include "smatch_extra.h"
23 23
24 24 static int my_id;
25 25 static int barrier_id;
26 26
27 27 STATE(nospec);
28 28
29 29 static bool in_nospec_stmt;
30 30
31 31 static struct smatch_state *unmatched_state(struct sm_state *sm)
32 32 {
33 33 struct range_list *rl;
34 34
35 35 if (__in_function_def && !get_user_rl_var_sym(sm->name, sm->sym, &rl))
36 36 return &nospec;
37 37 return &undefined;
38 38 }
39 39
40 40 bool is_nospec(struct expression *expr)
41 41 {
42 42 char *macro;
43 43
44 44 if (in_nospec_stmt)
45 45 return true;
46 46 if (!expr)
47 47 return false;
48 48 if (get_state_expr(my_id, expr) == &nospec)
49 49 return true;
50 50 macro = get_macro_name(expr->pos);
51 51 if (macro && strcmp(macro, "array_index_nospec") == 0)
52 52 return true;
53 53 return false;
54 54 }
55 55
56 56 static void nospec_assign(struct expression *expr)
57 57 {
58 58 if (is_nospec(expr->right))
59 59 set_state_expr(my_id, expr->left, &nospec);
60 60 }
61 61
62 62 static void set_param_nospec(const char *name, struct symbol *sym, char *key, char *value)
63 63 {
64 64 char fullname[256];
65 65
66 66 if (strcmp(key, "*$") == 0)
67 67 snprintf(fullname, sizeof(fullname), "*%s", name);
68 68 else if (strncmp(key, "$", 1) == 0)
69 69 snprintf(fullname, 256, "%s%s", name, key + 1);
70 70 else
71 71 return;
72 72
73 73 set_state(my_id, fullname, sym, &nospec);
74 74 }
75 75
76 76 static void match_call_info(struct expression *expr)
77 77 {
78 78 struct expression *arg;
79 79 int i = 0;
80 80
81 81 FOR_EACH_PTR(expr->args, arg) {
82 82 if (get_state_expr(my_id, arg) == &nospec)
83 83 sql_insert_caller_info(expr, NOSPEC, i, "$", "");
84 84 i++;
85 85 } END_FOR_EACH_PTR(arg);
86 86 }
87 87
88 88 static void struct_member_callback(struct expression *call, int param, char *printed_name, struct sm_state *sm)
|
↓ open down ↓ |
88 lines elided |
↑ open up ↑ |
89 89 {
90 90 struct range_list *rl;
91 91
92 92 if (!get_user_rl_var_sym(sm->name, sm->sym, &rl))
93 93 return;
94 94 sql_insert_caller_info(call, NOSPEC, param, printed_name, "");
95 95 }
96 96
97 97 static void returned_struct_members(int return_id, char *return_ranges, struct expression *expr)
98 98 {
99 + struct stree *start_states = get_start_states();
99 100 struct symbol *returned_sym;
100 101 struct sm_state *sm;
101 102 const char *param_name;
102 103 struct range_list *rl;
103 104 int param;
104 105
105 106 returned_sym = expr_to_sym(expr);
106 107
107 108 FOR_EACH_MY_SM(my_id, __get_cur_stree(), sm) {
109 + if (get_state_stree(start_states, my_id, sm->name, sm->sym) == sm->state)
110 + continue;
108 111 param = get_param_num_from_sym(sm->sym);
109 112 if (param < 0) {
110 113 if (!returned_sym || returned_sym != sm->sym)
111 114 continue;
112 115 param = -1;
113 116 }
114 117
115 118 param_name = get_param_name(sm);
116 119 if (!param_name)
117 120 continue;
118 121 if (param != -1 && strcmp(param_name, "$") == 0)
119 122 continue;
120 123
121 124 if (!get_user_rl_var_sym(sm->name, sm->sym, &rl))
122 125 continue;
123 126
124 127 sql_insert_return_states(return_id, return_ranges, NOSPEC, param, param_name, "");
125 128 } END_FOR_EACH_SM(sm);
126 129
127 130 if (is_nospec(expr) && get_user_rl(expr, &rl))
128 131 sql_insert_return_states(return_id, return_ranges, NOSPEC, -1, "$", "");
129 132
130 133 if (get_state(barrier_id, "barrier", NULL) == &nospec)
131 134 sql_insert_return_states(return_id, return_ranges, NOSPEC_WB, -1, "", "");
132 135 }
133 136
134 137 static int is_return_statement(void)
135 138 {
136 139 if (__cur_stmt && __cur_stmt->type == STMT_RETURN)
137 140 return 1;
138 141 return 0;
139 142 }
140 143
141 144 static void db_returns_nospec(struct expression *expr, int param, char *key, char *value)
142 145 {
143 146 struct expression *call;
144 147 struct expression *arg;
145 148 char *name;
146 149 struct symbol *sym;
147 150
148 151 call = expr;
149 152 while (call->type == EXPR_ASSIGNMENT)
150 153 call = strip_expr(call->right);
151 154 if (call->type != EXPR_CALL)
152 155 return;
153 156
154 157 if (param == -1 && expr->type == EXPR_ASSIGNMENT) {
155 158 name = get_variable_from_key(expr->left, key, &sym);
156 159 } else if (param == -1 && is_return_statement()) {
157 160 in_nospec_stmt = true;
158 161 return;
159 162 } else {
160 163 arg = get_argument_from_call_expr(call->args, param);
161 164 if (!arg)
162 165 return;
163 166 name = get_variable_from_key(arg, key, &sym);
164 167 }
165 168 if (!name || !sym)
166 169 goto free;
167 170
168 171 set_state(my_id, name, sym, &nospec);
169 172 free:
170 173 free_string(name);
171 174 }
172 175
173 176 static int is_nospec_asm(struct statement *stmt)
174 177 {
175 178 char *macro;
176 179
177 180 if (!stmt || stmt->type != STMT_ASM)
178 181 return 0;
179 182 macro = get_macro_name(stmt->asm_string->pos);
180 183 if (!macro || strcmp(macro, "CALL_NOSPEC") != 0)
181 184 return 0;
182 185 return 1;
183 186 }
184 187
185 188 static void match_asm(struct statement *stmt)
186 189 {
187 190 if (is_nospec_asm(stmt))
188 191 in_nospec_stmt = true;
189 192 }
190 193
191 194 static void match_after_nospec_asm(struct statement *stmt)
192 195 {
193 196 in_nospec_stmt = false;
194 197 }
195 198
196 199 static void mark_user_data_as_nospec(void)
197 200 {
198 201 struct stree *stree;
199 202 struct symbol *type;
200 203 struct sm_state *sm;
201 204
202 205 stree = get_user_stree();
203 206 FOR_EACH_SM(stree, sm) {
204 207 if (is_whole_rl(estate_rl(sm->state)))
205 208 continue;
206 209 type = estate_type(sm->state);
207 210 if (!type || type->type != SYM_BASETYPE)
208 211 continue;
209 212 if (!is_capped_var_sym(sm->name, sm->sym))
210 213 continue;
211 214 set_state(my_id, sm->name, sm->sym, &nospec);
212 215 } END_FOR_EACH_SM(sm);
213 216 free_stree(&stree);
214 217 }
|
↓ open down ↓ |
97 lines elided |
↑ open up ↑ |
215 218
216 219 static void match_barrier(struct statement *stmt)
217 220 {
218 221 char *macro;
219 222
220 223 macro = get_macro_name(stmt->pos);
221 224 if (!macro)
222 225 return;
223 226 if (strcmp(macro, "rmb") != 0 &&
224 227 strcmp(macro, "smp_rmb") != 0 &&
225 - strcmp(macro, "barrier_nospec") != 0)
228 + strcmp(macro, "barrier_nospec") != 0 &&
229 + strcmp(macro, "preempt_disable") != 0)
226 230 return;
227 231
228 232 set_state(barrier_id, "barrier", NULL, &nospec);
229 233 mark_user_data_as_nospec();
230 234 }
231 235
232 236 static void db_returns_barrier(struct expression *expr, int param, char *key, char *value)
233 237 {
234 238 mark_user_data_as_nospec();
235 239 }
236 240
241 +static void select_return_stmt_cnt(struct expression *expr, int param, char *key, char *value)
242 +{
243 + int cnt;
244 +
245 + cnt = atoi(value);
246 + if (cnt > 400)
247 + mark_user_data_as_nospec();
248 +}
249 +
237 250 void check_nospec(int id)
238 251 {
239 252 my_id = id;
240 253
241 254 add_hook(&nospec_assign, ASSIGNMENT_HOOK);
242 255
243 256 select_caller_info_hook(set_param_nospec, NOSPEC);
244 257 add_unmatched_state_hook(my_id, &unmatched_state);
245 258
246 259 add_hook(&match_call_info, FUNCTION_CALL_HOOK);
247 260 add_member_info_callback(my_id, struct_member_callback);
248 261 add_split_return_callback(&returned_struct_members);
249 262 select_return_states_hook(NOSPEC, &db_returns_nospec);
250 263 select_return_states_hook(NOSPEC_WB, &db_returns_barrier);
264 + select_return_states_hook(STMT_CNT, &select_return_stmt_cnt);
251 265
252 266 add_hook(&match_asm, ASM_HOOK);
253 267 add_hook(&match_after_nospec_asm, STMT_HOOK_AFTER);
254 268 }
255 269
256 270 void check_nospec_barrier(int id)
257 271 {
258 272 barrier_id = id;
259 273
260 274 add_hook(&match_barrier, ASM_HOOK);
261 275 }
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX