Print this page
new smatch
| Split |
Close |
| Expand all |
| Collapse all |
--- old/usr/src/tools/smatch/src/smatch_data/db/fixup_kernel.sh
+++ new/usr/src/tools/smatch/src/smatch_data/db/fixup_kernel.sh
1 1 #!/bin/bash
2 2
3 3 db_file=$1
4 4 cat << EOF | sqlite3 $db_file
5 5 /* we only care about the main ->read/write() functions. */
6 6 delete from caller_info where function = '(struct file_operations)->read' and file != 'fs/read_write.c';
7 7 delete from caller_info where function = '(struct file_operations)->write' and file != 'fs/read_write.c';
8 8 delete from caller_info where function = '(struct file_operations)->read' and caller != '__vfs_read';
9 9 delete from caller_info where function = '(struct file_operations)->write' and caller != '__vfs_write';
10 10 delete from function_ptr where function = '(struct file_operations)->read';
11 11 delete from function_ptr where function = '(struct file_operations)->write';
12 12 delete from caller_info where function = '__vfs_write' and caller != 'vfs_write';
13 13 delete from caller_info where function = '__vfs_read' and caller != 'vfs_read';
14 14 delete from caller_info where function = '(struct file_operations)->write' and caller = 'do_loop_readv_writev';
15 15 delete from caller_info where function = 'do_splice_from' and caller = 'direct_splice_actor';
16 16
17 17 /* delete these function pointers which cause false positives */
18 18 delete from caller_info where function = '(struct file_operations)->open' and type != 0;
19 19 delete from caller_info where function = '(struct notifier_block)->notifier_call' and type != 0;
20 20 delete from caller_info where function = '(struct mISDNchannel)->send' and type != 0;
21 21 delete from caller_info where function = '(struct irq_router)->get' and type != 0;
22 22 delete from caller_info where function = '(struct irq_router)->set' and type != 0;
23 23 delete from caller_info where function = '(struct net_device_ops)->ndo_change_mtu' and caller = 'i40e_dbg_netdev_ops_write';
24 24 delete from caller_info where function = '(struct timer_list)->function' and type != 0;
25 25
26 26 /* 8017 is USER_DATA and 9017 is USER_DATA_SET */
27 27 delete from caller_info where function = 'dev_hard_start_xmit' and type = 8017;
28 28 delete from return_states where function='vscnprintf' and type = 9017;
29 29 delete from return_states where function='scnprintf' and type = 9017;
30 30 delete from return_states where function='vsnprintf' and type = 9017;
31 31 delete from return_states where function='snprintf' and type = 9017;
32 32 delete from return_states where function='sprintf' and type = 9017;
33 33 delete from return_states where function='vscnprintf' and type = 8017;
|
↓ open down ↓ |
33 lines elided |
↑ open up ↑ |
34 34 delete from return_states where function='scnprintf' and type = 8017;
35 35 delete from return_states where function='vsnprintf' and type = 8017;
36 36 delete from return_states where function='snprintf' and type = 8017;
37 37 delete from return_states where function='sprintf' and type = 8017;
38 38 /* There is something setting skb->sk->sk_mark and friends to user_data and */
39 39 /* because of recursion it gets passed to everything and is impossible to debug */
40 40 delete from caller_info where function = '__dev_queue_xmit' and type = 8017;
41 41 delete from caller_info where function = '__netdev_start_xmit' and type = 8017;
42 42 delete from caller_info where function = '(struct packet_type)->func' and type = 8017;
43 43 delete from caller_info where function = '(struct bio)->bi_end_io' and type = 8017;
44 +delete from caller_info where type = 8017 and key = '*\$->bi_private';
45 +delete from caller_info where type = 8017 and key = '\$->bi_private';
44 46 delete from caller_info where caller = 'NF_HOOK_COND' and type = 8017;
45 47 delete from caller_info where caller = 'NF_HOOK' and type = 8017;
46 48 /* comparison doesn't deal with chunks, I guess. */
47 49 delete from return_states where function='get_tty_driver' and type = 8017;
48 50 delete from caller_info where caller = 'snd_ctl_elem_write' and function = '(struct snd_kcontrol)->put' and type = 8017;
49 51 delete from caller_info where caller = 'snd_ctl_elem_read' and function = '(struct snd_kcontrol)->get' and type = 8017;
50 52 delete from caller_info where function = 'nf_tables_newexpr' and type = 8017 and key = '\$->family';
51 53 delete from caller_info where caller = 'fb_set_var' and function = '(struct fb_ops)->fb_set_par' and type = 8017 and parameter = 0;
52 54 delete from return_states where function = 'tty_lookup_driver' and parameter = 2 and type = 8017;
55 +delete from caller_info where function = 'iomap_apply' and type = 8017 and key = '*\$';
53 56
54 57 insert into caller_info values ('userspace', '', 'compat_sys_ioctl', 0, 0, 8017, 0, '\$', '1');
55 58 insert into caller_info values ('userspace', '', 'compat_sys_ioctl', 0, 0, 8017, 1, '\$', '1');
56 59 insert into caller_info values ('userspace', '', 'compat_sys_ioctl', 0, 0, 8017, 2, '\$', '1');
57 60
58 61 delete from caller_info where function = '(struct timer_list)->function' and parameter = 0;
59 62
60 63 /*
61 64 * rw_verify_area is a very central function for the kernel. The 1000000000
62 65 * isn't accurate but I've picked it so that we can add "pos + count" without
63 66 * wrapping on 32 bits.
64 67 */
65 68 delete from return_states where function = 'rw_verify_area';
66 69 insert into return_states values ('faked', 'rw_verify_area', 0, 1, '0-1000000000[<=\$3]', 0, 0, -1, '', '');
67 70 insert into return_states values ('faked', 'rw_verify_area', 0, 1, '0-1000000000[<=\$3]', 0, 104, 2, '*\$', '0-1000000000');
68 71 insert into return_states values ('faked', 'rw_verify_area', 0, 1, '0-1000000000[<=\$3]', 0, 103, 3, '\$', '0-1000000000');
69 72 insert into return_states values ('faked', 'rw_verify_area', 0, 2, '(-4095)-(-1)', 0, 0, -1, '', '');
70 73
71 74 delete from return_states where function = 'is_kernel_rodata';
72 75 insert into return_states values ('faked', 'is_kernel_rodata', 0, 1, '1', 0, 0, -1, '', '');
73 76 insert into return_states values ('faked', 'is_kernel_rodata', 0, 1, '1', 0, 103, 0, '\$', '4096-ptr_max');
74 77 insert into return_states values ('faked', 'is_kernel_rodata', 0, 2, '0', 0, 0, -1, '', '');
75 78
76 79 /*
77 80 * Other kmalloc hacking.
78 81 */
79 82 delete from return_states where function = 'vmalloc';
80 83 insert into return_states values ('faked', 'vmalloc', 0, 1, '4096-ptr_max', 0, 0, -1, '', '');
81 84 insert into return_states values ('faked', 'vmalloc', 0, 1, '4096-ptr_max', 0, 103, 0, '\$', '1-128000000');
82 85 insert into return_states values ('faked', 'vmalloc', 0, 2, '0', 0, 0, -1, '', '');
83 86
84 87 delete from return_states where function = 'ksize';
85 88 insert into return_states values ('faked', 'ksize', 0, 1, '0', 0, 0, -1, '', '');
86 89 insert into return_states values ('faked', 'ksize', 0, 1, '0', 0, 103, 0, '\$', '16');
87 90 insert into return_states values ('faked', 'ksize', 0, 2, '1-4000000', 0, 0, -1, '', '');
88 91
89 92 /* store a bunch of capped functions */
90 93 update return_states set return = '0-u32max[<=\$2]' where function = 'copy_to_user';
91 94 update return_states set return = '0-u32max[<=\$2]' where function = '_copy_to_user';
92 95 update return_states set return = '0-u32max[<=\$2]' where function = '__copy_to_user';
93 96 update return_states set return = '0-u32max[<=\$2]' where function = 'copy_from_user';
94 97 update return_states set return = '0-u32max[<=\$2]' where function = '_copy_from_user';
95 98 update return_states set return = '0-u32max[<=\$2]' where function = '__copy_from_user';
96 99
97 100 update return_states set return = '0-8' where function = '__arch_hweight8';
98 101 update return_states set return = '0-16' where function = '__arch_hweight16';
99 102 update return_states set return = '0-32' where function = '__arch_hweight32';
100 103 update return_states set return = '0-64' where function = '__arch_hweight64';
101 104
102 105 /*
103 106 * Preserve the value across byte swapping. By the time we use it for math it
104 107 * will be byte swapped back to CPU endian.
105 108 */
106 109 update return_states set return = '0-u64max[==\$0]' where function = '__fswab64';
107 110 update return_states set return = '0-u32max[==\$0]' where function = '__fswab32';
108 111 update return_states set return = '0-u16max[==\$0]' where function = '__fswab16';
109 112 update return_states set return = '0-u64max[==\$0]' where function = '__builtin_bswap64';
110 113 update return_states set return = '0-u32max[==\$0]' where function = '__builtin_bswap32';
111 114 update return_states set return = '0-u16max[==\$0]' where function = '__builtin_bswap16';
112 115
113 116 delete from return_states where function = 'bitmap_allocate_region' and return = '1';
114 117 /* Just delete a lot of returns that everyone ignores */
115 118 delete from return_states where file = 'drivers/pci/access.c' and (return >= 129 and return <= 137);
116 119
117 120 /* Smatch can't parse wait_for_completion() */
118 121 update return_states set return = '(-108),(-22),0' where function = '__spi_sync' and return = '(-115),(-108),(-22)';
119 122
120 123 delete from caller_info where caller = '__kernel_write';
121 124
122 125 /* We sometimes use pre-allocated 4097 byte buffers for performance critical code but pretend it is always PAGE_SIZE */
123 126 update caller_info set value = 4096 where caller='kernfs_file_direct_read' and function='(struct kernfs_ops)->read' and type = 1002 and parameter = 1;
124 127 /* let's pretend firewire doesn't exist */
125 128 delete from caller_info where caller='init_fw_attribute_group' and function='(struct device_attribute)->show';
126 129 /* and let's fake the next dev_attr_show() call entirely */
127 130 delete from caller_info where caller='sysfs_kf_seq_show' and function='(struct sysfs_ops)->show';
128 131 insert into caller_info values ('fake', 'sysfs_kf_seq_show', '(struct sysfs_ops)->show', 0, 0, 1001, 0, '\$', '4096-ptr_max');
129 132 insert into caller_info values ('fake', 'sysfs_kf_seq_show', '(struct sysfs_ops)->show', 0, 0, 1002, 2, '\$', '4096');
130 133 insert into caller_info values ('fake', 'sysfs_kf_seq_show', '(struct sysfs_ops)->show', 0, 0, 1001, 2, '\$', '4096-ptr_max');
131 134 insert into caller_info values ('fake', 'sysfs_kf_seq_show', '(struct sysfs_ops)->show', 0, 0, 0, -1, '' , '');
132 135 /* config fs confuses smatch a little */
133 136 update caller_info set value = 4096 where caller='fill_read_buffer' and function='(struct configfs_item_operations)->show_attribute' and type = 1002 and parameter = 2;
134 137
135 138 /* smatch sees the memset() but not the subsequent changes */
136 139 update return_states set value = "" where function = 'gfs2_ea_find' and return = '0' and type = 101 and parameter = 3;
137 140
138 141 delete from type_value where type = '(struct fd)->file';
139 142 delete from type_value where type = '(struct fd)->flags';
140 143
141 144 /* This is sometimes an enum or a u64 */
142 145 delete from type_value where type = '(struct mc_cmd_header)->status';
143 146
144 147 /* this is handled in check_kernel.c */
145 148 delete from return_states where function = "__write_once_size";
146 149
147 150 update return_states set value = "s32min-s32max[\$1]" where function = 'atomic_set' and parameter = 0 and type = 1025;
148 151
149 152 /* handled in the check itself */
150 153 delete from return_states where function = 'atomic_inc_return' and (type = 8023 or type = 8024);
151 154 delete from return_states where function = 'atomic_add_return' and (type = 8023 or type = 8024);
152 155 delete from return_states where function = 'atomic_sub_return' and (type = 8023 or type = 8024);
153 156 delete from return_states where function = 'atomic_sub_and_test' and (type = 8023 or type = 8024);
154 157 delete from return_states where function = 'atomic_dec_and_test' and (type = 8023 or type = 8024);
155 158 delete from return_states where function = 'atomic_dec' and (type = 8023 or type = 8024);
156 159 delete from return_states where function = 'atomic_inc' and (type = 8023 or type = 8024);
157 160 delete from return_states where function = 'atomic_sub' and (type = 8023 or type = 8024);
158 161 delete from return_states where function = 'refcount_add_not_zero' and (type = 8023 or type = 8024);
159 162 delete from return_states where function = 'refcount_inc_not_zero' and (type = 8023 or type = 8024);
160 163 delete from return_states where function = 'refcount_sub_and_test' and (type = 8023 or type = 8024);
161 164
162 165 update return_states set return = '0-32,2147483648-2147483690' where function = '_parse_integer' and return = '0';
163 166 update return_states set value = '0-u64max' where function = '_parse_integer' and type = 1025 and parameter = 2 and key = '*$';
164 167
165 168 /* delete some function pointers which are sometimes byte units */
166 169 delete from caller_info where function = '(struct i2c_algorithm)->master_xfer' and type = 1027;
|
↓ open down ↓ |
104 lines elided |
↑ open up ↑ |
167 170
168 171 /* this if from READ_ONCE(). We can't know anything about the data. */
169 172 delete from type_info where key = '(union anonymous)->__val';
170 173
171 174 /* This is RIO_BAD_SIZE */
172 175 delete from return_states where file = 'drivers/rapidio/rio-access.c' and return = '129';
173 176
174 177 /* Smatch sucks at loops */
175 178 delete from return_states where function = 'ata_dev_next' and type = 103;
176 179
180 +/* The problem is that parsing big function pointers is hard. */
181 +delete from return_states where function = 'vfs_get_tree' and type = 1024;
182 +
177 183 EOF
178 184
179 185 # fixme: this is totally broken
180 186 call_id=$(echo "select distinct call_id from caller_info where function = '__kernel_write';" | sqlite3 $db_file)
181 187 for id in $call_id ; do
182 188 echo "insert into caller_info values ('fake', '', '__kernel_write', $id, 0, 8017, 1, '*\$', '');" | sqlite3 $db_file
183 189 done
184 190
185 191 for i in $(echo "select distinct return from return_states where function = 'clear_user';" | sqlite3 $db_file ) ; do
186 192 echo "update return_states set return = \"$i[<=\$1]\" where return = \"$i\" and function = 'clear_user';" | sqlite3 $db_file
187 193 done
188 194
189 195 echo "select distinct file, function from function_ptr where ptr='(struct rtl_hal_ops)->set_hw_reg';" \
190 196 | sqlite3 $db_file | sed -e 's/|/ /' | while read file function ; do
191 197
192 198 drv=$(echo $file | perl -ne 's/.*\/rtlwifi\/(.*?)\/sw.c/$1/; print')
193 199 if [ $drv = "" ] ; then
194 200 continue
195 201 fi
196 202
197 203 echo "update caller_info
198 204 set function = '$drv (struct rtl_hal_ops)->set_hw_reg'
199 205 where function = '(struct rtl_hal_ops)->set_hw_reg' and file like 'drivers/net/wireless/rtlwifi/$drv/%';" \
200 206 | sqlite3 $db_file
201 207
202 208 echo "insert into function_ptr values ('$file', '$function', '$drv (struct rtl_hal_ops)->set_hw_reg', 1);" \
203 209 | sqlite3 $db_file
204 210 done
205 211
206 212
207 213 for func in __kmalloc __kmalloc_track_caller ; do
208 214
209 215 cat << EOF | sqlite3 $db_file
210 216 delete from return_states where function = '$func';
211 217 insert into return_states values ('faked', '$func', 0, 1, '16', 0, 0, -1, '', '');
212 218 insert into return_states values ('faked', '$func', 0, 1, '16', 0, 103, 0, '\$', '0');
213 219 insert into return_states values ('faked', '$func', 0, 2, '4096-ptr_max', 0, 0, -1, '', '');
214 220 insert into return_states values ('faked', '$func', 0, 2, '4096-ptr_max', 0, 103, 0, '\$', '1-4000000');
215 221 insert into return_states values ('faked', '$func', 0, 2, '4096-ptr_max', 0, 1037, -1, '', 400);
216 222 insert into return_states values ('faked', '$func', 0, 3, '0', 0, 0, -1, '', '');
217 223 insert into return_states values ('faked', '$func', 0, 3, '0', 0, 103, 0, '\$', '1-long_max');
218 224 EOF
219 225 done
|
↓ open down ↓ |
33 lines elided |
↑ open up ↑ |
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX