Code Review for illumos-gate

Prepared by:John Levon on 2018-Nov-20 12:08 +0000 GMT
Workspace:/root/illumos-gate (at f51738668fcd)
Compare against: origin/master (git://github.com/illumos/illumos-gate.git at 50a7e957ddab)
Summary of changes: 305 lines changed: 239 ins; 39 del; 27 mod; 15068 unchg
Patch of changes: illumos-gate.patch
Printable review: illumos-gate.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/system-header.mf

9936 atomic ops in syscall_mstate() induce significant overhead
9942 zone secflags are not initialized correctly
1 line changed: 1 ins; 0 del; 0 mod; 2122 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/Makefile.files

9936 atomic ops in syscall_mstate() induce significant overhead
9942 zone secflags are not initialized correctly
1 line changed: 1 ins; 0 del; 0 mod; 2210 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/os/cpu_uarray.c

9936 atomic ops in syscall_mstate() induce significant overhead
9942 zone secflags are not initialized correctly
79 lines changed: 79 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/msacct.c

9936 atomic ops in syscall_mstate() induce significant overhead
9942 zone secflags are not initialized correctly
52 lines changed: 33 ins; 17 del; 2 mod; 811 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/zone.c

9936 atomic ops in syscall_mstate() induce significant overhead
9942 zone secflags are not initialized correctly
43 lines changed: 20 ins; 12 del; 11 mod; 7359 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/Makefile

9936 atomic ops in syscall_mstate() induce significant overhead
9942 zone secflags are not initialized correctly
2 lines changed: 1 ins; 0 del; 1 mod; 1342 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/sys/cpu_uarray.h

9936 atomic ops in syscall_mstate() induce significant overhead
9942 zone secflags are not initialized correctly
81 lines changed: 81 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/sysmacros.h

9936 atomic ops in syscall_mstate() induce significant overhead
9942 zone secflags are not initialized correctly
13 lines changed: 13 ins; 0 del; 0 mod; 380 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/zone.h

9936 atomic ops in syscall_mstate() induce significant overhead
9942 zone secflags are not initialized correctly
33 lines changed: 10 ins; 10 del; 13 mod; 844 unchg

This code review page was prepared using /root/illumos-gate/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.