1 /*
   2  * CDDL HEADER START
   3  *
   4  * The contents of this file are subject to the terms of the
   5  * Common Development and Distribution License (the "License").
   6  * You may not use this file except in compliance with the License.
   7  *
   8  * You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
   9  * or http://www.opensolaris.org/os/licensing.
  10  * See the License for the specific language governing permissions
  11  * and limitations under the License.
  12  *
  13  * When distributing Covered Code, include this CDDL HEADER in each
  14  * file and include the License file at usr/src/OPENSOLARIS.LICENSE.
  15  * If applicable, add the following below this CDDL HEADER, with the
  16  * fields enclosed by brackets "[]" replaced with your own identifying
  17  * information: Portions Copyright [yyyy] [name of copyright owner]
  18  *
  19  * CDDL HEADER END
  20  */
  21 
  22 /*
  23  * Copyright (c) 2003, 2010, Oracle and/or its affiliates. All rights reserved.
  24  * Copyright (c) 2012, 2014 by Delphix. All rights reserved.
  25  * Copyright 2020 Joyent, Inc.
  26  */
  27 
  28 #include <strings.h>
  29 #include <stdlib.h>
  30 #include <limits.h>
  31 #include <alloca.h>
  32 #include <assert.h>
  33 
  34 #include <dt_decl.h>
  35 #include <dt_parser.h>
  36 #include <dt_module.h>
  37 #include <dt_impl.h>
  38 
  39 static dt_decl_t *
  40 dt_decl_check(dt_decl_t *ddp)
  41 {
  42         if (ddp->dd_kind == CTF_K_UNKNOWN)
  43                 return (ddp); /* nothing to check if the type is not yet set */
  44 
  45         if (ddp->dd_name != NULL && strcmp(ddp->dd_name, "char") == 0 &&
  46             (ddp->dd_attr & (DT_DA_SHORT | DT_DA_LONG | DT_DA_LONGLONG))) {
  47                 xyerror(D_DECL_CHARATTR, "invalid type declaration: short and "
  48                     "long may not be used with char type\n");
  49         }
  50 
  51         if (ddp->dd_name != NULL && strcmp(ddp->dd_name, "void") == 0 &&
  52             (ddp->dd_attr & (DT_DA_SHORT | DT_DA_LONG | DT_DA_LONGLONG |
  53             (DT_DA_SIGNED | DT_DA_UNSIGNED)))) {
  54                 xyerror(D_DECL_VOIDATTR, "invalid type declaration: attributes "
  55                     "may not be used with void type\n");
  56         }
  57 
  58         if (ddp->dd_kind != CTF_K_INTEGER &&
  59             (ddp->dd_attr & (DT_DA_SIGNED | DT_DA_UNSIGNED))) {
  60                 xyerror(D_DECL_SIGNINT, "invalid type declaration: signed and "
  61                     "unsigned may only be used with integer type\n");
  62         }
  63 
  64         if (ddp->dd_kind != CTF_K_INTEGER && ddp->dd_kind != CTF_K_FLOAT &&
  65             (ddp->dd_attr & (DT_DA_LONG | DT_DA_LONGLONG))) {
  66                 xyerror(D_DECL_LONGINT, "invalid type declaration: long and "
  67                     "long long may only be used with integer or "
  68                     "floating-point type\n");
  69         }
  70 
  71         return (ddp);
  72 }
  73 
  74 dt_decl_t *
  75 dt_decl_alloc(ushort_t kind, char *name)
  76 {
  77         dt_decl_t *ddp = malloc(sizeof (dt_decl_t));
  78 
  79         if (ddp == NULL)
  80                 longjmp(yypcb->pcb_jmpbuf, EDT_NOMEM);
  81 
  82         ddp->dd_kind = kind;
  83         ddp->dd_attr = 0;
  84         ddp->dd_ctfp = NULL;
  85         ddp->dd_type = CTF_ERR;
  86         ddp->dd_name = name;
  87         ddp->dd_node = NULL;
  88         ddp->dd_next = NULL;
  89 
  90         return (ddp);
  91 }
  92 
  93 void
  94 dt_decl_free(dt_decl_t *ddp)
  95 {
  96         dt_decl_t *ndp;
  97 
  98         for (; ddp != NULL; ddp = ndp) {
  99                 ndp = ddp->dd_next;
 100                 free(ddp->dd_name);
 101                 dt_node_list_free(&ddp->dd_node);
 102                 free(ddp);
 103         }
 104 }
 105 
 106 void
 107 dt_decl_reset(void)
 108 {
 109         dt_scope_t *dsp = &yypcb->pcb_dstack;
 110         dt_decl_t *ddp = dsp->ds_decl;
 111 
 112         while (ddp->dd_next != NULL) {
 113                 dsp->ds_decl = ddp->dd_next;
 114                 ddp->dd_next = NULL;
 115                 dt_decl_free(ddp);
 116                 ddp = dsp->ds_decl;
 117         }
 118 }
 119 
 120 dt_decl_t *
 121 dt_decl_push(dt_decl_t *ddp)
 122 {
 123         dt_scope_t *dsp = &yypcb->pcb_dstack;
 124         dt_decl_t *top = dsp->ds_decl;
 125 
 126         if (top != NULL &&
 127             top->dd_kind == CTF_K_UNKNOWN && top->dd_name == NULL) {
 128                 top->dd_kind = CTF_K_INTEGER;
 129                 (void) dt_decl_check(top);
 130         }
 131 
 132         assert(ddp->dd_next == NULL);
 133         ddp->dd_next = top;
 134         dsp->ds_decl = ddp;
 135 
 136         return (ddp);
 137 }
 138 
 139 dt_decl_t *
 140 dt_decl_pop(void)
 141 {
 142         dt_scope_t *dsp = &yypcb->pcb_dstack;
 143         dt_decl_t *ddp = dt_decl_top();
 144 
 145         dsp->ds_decl = NULL;
 146         free(dsp->ds_ident);
 147         dsp->ds_ident = NULL;
 148         dsp->ds_ctfp = NULL;
 149         dsp->ds_type = CTF_ERR;
 150         dsp->ds_class = DT_DC_DEFAULT;
 151         dsp->ds_enumval = -1;
 152 
 153         return (ddp);
 154 }
 155 
 156 dt_decl_t *
 157 dt_decl_pop_param(char **idp)
 158 {
 159         dt_scope_t *dsp = &yypcb->pcb_dstack;
 160 
 161         if (dsp->ds_class != DT_DC_DEFAULT && dsp->ds_class != DT_DC_REGISTER) {
 162                 xyerror(D_DECL_PARMCLASS, "inappropriate storage class "
 163                     "for function or associative array parameter\n");
 164         }
 165 
 166         if (idp != NULL && dt_decl_top() != NULL) {
 167                 *idp = dsp->ds_ident;
 168                 dsp->ds_ident = NULL;
 169         }
 170 
 171         return (dt_decl_pop());
 172 }
 173 
 174 dt_decl_t *
 175 dt_decl_top(void)
 176 {
 177         dt_decl_t *ddp = yypcb->pcb_dstack.ds_decl;
 178 
 179         if (ddp == NULL)
 180                 longjmp(yypcb->pcb_jmpbuf, EDT_NODECL);
 181 
 182         if (ddp->dd_kind == CTF_K_UNKNOWN && ddp->dd_name == NULL) {
 183                 ddp->dd_kind = CTF_K_INTEGER;
 184                 (void) dt_decl_check(ddp);
 185         }
 186 
 187         return (ddp);
 188 }
 189 
 190 dt_decl_t *
 191 dt_decl_ident(char *name)
 192 {
 193         dt_scope_t *dsp = &yypcb->pcb_dstack;
 194         dt_decl_t *ddp = dsp->ds_decl;
 195 
 196         if (dsp->ds_ident != NULL) {
 197                 free(name);
 198                 xyerror(D_DECL_IDENT, "old-style declaration or "
 199                     "incorrect type specified\n");
 200         }
 201 
 202         dsp->ds_ident = name;
 203 
 204         if (ddp == NULL)
 205                 ddp = dt_decl_push(dt_decl_alloc(CTF_K_UNKNOWN, NULL));
 206 
 207         return (ddp);
 208 }
 209 
 210 void
 211 dt_decl_class(dt_dclass_t class)
 212 {
 213         dt_scope_t *dsp = &yypcb->pcb_dstack;
 214 
 215         if (dsp->ds_class != DT_DC_DEFAULT) {
 216                 xyerror(D_DECL_CLASS, "only one storage class allowed "
 217                     "in a declaration\n");
 218         }
 219 
 220         dsp->ds_class = class;
 221 }
 222 
 223 /*
 224  * Set the kind and name of the current declaration.  If none is allocated,
 225  * make a new decl and push it on to the top of our stack.  If the name or kind
 226  * is already set for the current decl, then we need to fail this declaration.
 227  * This can occur because too many types were given (e.g. "int int"), etc.
 228  */
 229 dt_decl_t *
 230 dt_decl_spec(ushort_t kind, char *name)
 231 {
 232         dt_decl_t *ddp = yypcb->pcb_dstack.ds_decl;
 233 
 234         if (ddp == NULL)
 235                 return (dt_decl_push(dt_decl_alloc(kind, name)));
 236 
 237         /*
 238          * If we already have a type name specified and we see another type
 239          * name, this is an error if the declaration is a typedef.  If the
 240          * declaration is not a typedef, then the user may be trying to declare
 241          * a variable whose name has been returned by lex as a TNAME token:
 242          * call dt_decl_ident() as if the grammar's IDENT rule was matched.
 243          */
 244         if (ddp->dd_name != NULL && kind == CTF_K_TYPEDEF) {
 245                 if (yypcb->pcb_dstack.ds_class != DT_DC_TYPEDEF)
 246                         return (dt_decl_ident(name));
 247                 xyerror(D_DECL_IDRED, "identifier redeclared: %s\n", name);
 248         }
 249 
 250         if (ddp->dd_name != NULL || ddp->dd_kind != CTF_K_UNKNOWN)
 251                 xyerror(D_DECL_COMBO, "invalid type combination\n");
 252 
 253         ddp->dd_kind = kind;
 254         ddp->dd_name = name;
 255 
 256         return (dt_decl_check(ddp));
 257 }
 258 
 259 dt_decl_t *
 260 dt_decl_attr(ushort_t attr)
 261 {
 262         dt_decl_t *ddp = yypcb->pcb_dstack.ds_decl;
 263 
 264         if (ddp == NULL) {
 265                 ddp = dt_decl_push(dt_decl_alloc(CTF_K_UNKNOWN, NULL));
 266                 ddp->dd_attr = attr;
 267                 return (ddp);
 268         }
 269 
 270         if ((attr & DT_DA_LONG) && (ddp->dd_attr & DT_DA_LONGLONG)) {
 271                 xyerror(D_DECL_COMBO, "the attribute 'long' may only "
 272                     "be used at most twice in a declaration");
 273         }
 274 
 275         if ((attr & DT_DA_SHORT) && (ddp->dd_attr & DT_DA_SHORT)) {
 276                 xyerror(D_DECL_COMBO, "the attribute 'short' may only be "
 277                     "used at most once in a declaration");
 278         }
 279 
 280         if ((attr & DT_DA_SIGNED) && (ddp->dd_attr & DT_DA_SIGNED)) {
 281                 xyerror(D_DECL_COMBO, "the attribute 'signed' may only be "
 282                     "used at most once in a declaration");
 283         }
 284 
 285         if ((attr & DT_DA_UNSIGNED) && (ddp->dd_attr & DT_DA_UNSIGNED)) {
 286                 xyerror(D_DECL_COMBO, "the attribute 'unsigned' may only be "
 287                     "used at most once in a declaration");
 288         }
 289 
 290         if (attr == DT_DA_LONG && (ddp->dd_attr & DT_DA_LONG)) {
 291                 ddp->dd_attr &= ~DT_DA_LONG;
 292                 attr = DT_DA_LONGLONG;
 293         }
 294 
 295         ddp->dd_attr |= attr;
 296         return (dt_decl_check(ddp));
 297 }
 298 
 299 /*
 300  * Examine the list of formal parameters 'flist' and determine if the formal
 301  * name fnp->dn_string is defined in this list (B_TRUE) or not (B_FALSE).
 302  * If 'fnp' is in 'flist', do not search beyond 'fnp' itself in 'flist'.
 303  */
 304 static int
 305 dt_decl_protoform(dt_node_t *fnp, dt_node_t *flist)
 306 {
 307         dt_node_t *dnp;
 308 
 309         for (dnp = flist; dnp != fnp && dnp != NULL; dnp = dnp->dn_list) {
 310                 if (dnp->dn_string != NULL &&
 311                     strcmp(dnp->dn_string, fnp->dn_string) == 0)
 312                         return (B_TRUE);
 313         }
 314 
 315         return (B_FALSE);
 316 }
 317 
 318 /*
 319  * Common code for parsing array, function, and probe definition prototypes.
 320  * The prototype node list is specified as 'plist'.  The formal prototype
 321  * against which to compare the prototype is specified as 'flist'.  If plist
 322  * and flist are the same, we require that named parameters are unique.  If
 323  * plist and flist are different, we require that named parameters in plist
 324  * match a name that is present in flist.
 325  */
 326 int
 327 dt_decl_prototype(dt_node_t *plist,
 328     dt_node_t *flist, const char *kind, uint_t flags)
 329 {
 330         char n[DT_TYPE_NAMELEN];
 331         int is_void, v = 0, i = 1;
 332         int form = plist != flist;
 333         dt_node_t *dnp;
 334 
 335         for (dnp = plist; dnp != NULL; dnp = dnp->dn_list, i++) {
 336 
 337                 if (dnp->dn_type == CTF_ERR && !(flags & DT_DP_VARARGS)) {
 338                         dnerror(dnp, D_DECL_PROTO_VARARGS, "%s prototype may "
 339                             "not use a variable-length argument list\n", kind);
 340                 }
 341 
 342                 if (dt_node_is_dynamic(dnp) && !(flags & DT_DP_DYNAMIC)) {
 343                         dnerror(dnp, D_DECL_PROTO_TYPE, "%s prototype may not "
 344                             "use parameter of type %s: %s, parameter #%d\n",
 345                             kind, dt_node_type_name(dnp, n, sizeof (n)),
 346                             dnp->dn_string ? dnp->dn_string : "(anonymous)", i);
 347                 }
 348 
 349                 is_void = dt_node_is_void(dnp);
 350                 v += is_void;
 351 
 352                 if (is_void && !(flags & DT_DP_VOID)) {
 353                         dnerror(dnp, D_DECL_PROTO_TYPE, "%s prototype may not "
 354                             "use parameter of type %s: %s, parameter #%d\n",
 355                             kind, dt_node_type_name(dnp, n, sizeof (n)),
 356                             dnp->dn_string ? dnp->dn_string : "(anonymous)", i);
 357                 }
 358 
 359                 if (is_void && dnp->dn_string != NULL) {
 360                         dnerror(dnp, D_DECL_PROTO_NAME, "void parameter may "
 361                             "not have a name: %s\n", dnp->dn_string);
 362                 }
 363 
 364                 if (dnp->dn_string != NULL &&
 365                     dt_decl_protoform(dnp, flist) != form) {
 366                         dnerror(dnp, D_DECL_PROTO_FORM, "parameter is "
 367                             "%s declared in %s prototype: %s, parameter #%d\n",
 368                             form ? "not" : "already", kind, dnp->dn_string, i);
 369                 }
 370 
 371                 if (dnp->dn_string == NULL &&
 372                     !is_void && !(flags & DT_DP_ANON)) {
 373                         dnerror(dnp, D_DECL_PROTO_NAME, "parameter declaration "
 374                             "requires a name: parameter #%d\n", i);
 375                 }
 376         }
 377 
 378         if (v != 0 && plist->dn_list != NULL)
 379                 xyerror(D_DECL_PROTO_VOID, "void must be sole parameter\n");
 380 
 381         return (v ? 0 : i - 1); /* return zero if sole parameter is 'void' */
 382 }
 383 
 384 dt_decl_t *
 385 dt_decl_array(dt_node_t *dnp)
 386 {
 387         dt_decl_t *ddp = dt_decl_push(dt_decl_alloc(CTF_K_ARRAY, NULL));
 388         dt_scope_t *dsp = &yypcb->pcb_dstack;
 389         dt_decl_t *ndp = ddp;
 390 
 391         /*
 392          * After pushing the array on to the decl stack, scan ahead for multi-
 393          * dimensional array declarations and push the current decl to the
 394          * bottom to match the resulting CTF type tree and data layout.  Refer
 395          * to the comments in dt_decl_type() and ISO C 6.5.2.1 for more info.
 396          */
 397         while (ndp->dd_next != NULL && ndp->dd_next->dd_kind == CTF_K_ARRAY)
 398                 ndp = ndp->dd_next; /* skip to bottom-most array declaration */
 399 
 400         if (ndp != ddp) {
 401                 if (dnp != NULL && dnp->dn_kind == DT_NODE_TYPE) {
 402                         xyerror(D_DECL_DYNOBJ,
 403                             "cannot declare array of associative arrays\n");
 404                 }
 405                 dsp->ds_decl = ddp->dd_next;
 406                 ddp->dd_next = ndp->dd_next;
 407                 ndp->dd_next = ddp;
 408         }
 409 
 410         if (ddp->dd_next->dd_name != NULL &&
 411             strcmp(ddp->dd_next->dd_name, "void") == 0)
 412                 xyerror(D_DECL_VOIDOBJ, "cannot declare array of void\n");
 413 
 414         if (dnp != NULL && dnp->dn_kind != DT_NODE_TYPE) {
 415                 dnp = ddp->dd_node = dt_node_cook(dnp, DT_IDFLG_REF);
 416 
 417                 if (dt_node_is_posconst(dnp) == 0) {
 418                         xyerror(D_DECL_ARRSUB, "positive integral constant "
 419                             "expression or tuple signature expected as "
 420                             "array declaration subscript\n");
 421                 }
 422 
 423                 if (dnp->dn_value > UINT_MAX)
 424                         xyerror(D_DECL_ARRBIG, "array dimension too big\n");
 425 
 426         } else if (dnp != NULL) {
 427                 ddp->dd_node = dnp;
 428                 (void) dt_decl_prototype(dnp, dnp, "array", DT_DP_ANON);
 429         }
 430 
 431         return (ddp);
 432 }
 433 
 434 /*
 435  * When a function is declared, we need to fudge the decl stack a bit if the
 436  * declaration uses the function pointer (*)() syntax.  In this case, the
 437  * dt_decl_func() call occurs *after* the dt_decl_ptr() call, even though the
 438  * resulting type is "pointer to function".  To make the pointer land on top,
 439  * we check to see if 'pdp' is non-NULL and a pointer.  If it is, we search
 440  * backward for a decl tagged with DT_DA_PAREN, and if one is found, the func
 441  * decl is inserted behind this node in the decl list instead of at the top.
 442  * In all cases, the func decl's dd_next pointer is set to the decl chain
 443  * for the function's return type and the function parameter list is discarded.
 444  */
 445 dt_decl_t *
 446 dt_decl_func(dt_decl_t *pdp, dt_node_t *dnp)
 447 {
 448         dt_decl_t *ddp = dt_decl_alloc(CTF_K_FUNCTION, NULL);
 449 
 450         ddp->dd_node = dnp;
 451 
 452         (void) dt_decl_prototype(dnp, dnp, "function",
 453             DT_DP_VARARGS | DT_DP_VOID | DT_DP_ANON);
 454 
 455         if (pdp == NULL || pdp->dd_kind != CTF_K_POINTER)
 456                 return (dt_decl_push(ddp));
 457 
 458         while (pdp->dd_next != NULL && !(pdp->dd_next->dd_attr & DT_DA_PAREN))
 459                 pdp = pdp->dd_next;
 460 
 461         if (pdp->dd_next == NULL)
 462                 return (dt_decl_push(ddp));
 463 
 464         ddp->dd_next = pdp->dd_next;
 465         pdp->dd_next = ddp;
 466 
 467         return (pdp);
 468 }
 469 
 470 dt_decl_t *
 471 dt_decl_ptr(void)
 472 {
 473         return (dt_decl_push(dt_decl_alloc(CTF_K_POINTER, NULL)));
 474 }
 475 
 476 dt_decl_t *
 477 dt_decl_sou(uint_t kind, char *name)
 478 {
 479         dt_decl_t *ddp = dt_decl_spec(kind, name);
 480         char n[DT_TYPE_NAMELEN];
 481         ctf_file_t *ctfp;
 482         ctf_id_t type;
 483         uint_t flag;
 484 
 485         if (yypcb->pcb_idepth != 0)
 486                 ctfp = yypcb->pcb_hdl->dt_cdefs->dm_ctfp;
 487         else
 488                 ctfp = yypcb->pcb_hdl->dt_ddefs->dm_ctfp;
 489 
 490         if (yypcb->pcb_dstack.ds_next != NULL)
 491                 flag = CTF_ADD_NONROOT;
 492         else
 493                 flag = CTF_ADD_ROOT;
 494 
 495         (void) snprintf(n, sizeof (n), "%s %s",
 496             kind == CTF_K_STRUCT ? "struct" : "union",
 497             name == NULL ? "(anon)" : name);
 498 
 499         if (name != NULL && (type = ctf_lookup_by_name(ctfp, n)) != CTF_ERR &&
 500             ctf_type_kind(ctfp, type) != CTF_K_FORWARD)
 501                 xyerror(D_DECL_TYPERED, "type redeclared: %s\n", n);
 502 
 503         if (kind == CTF_K_STRUCT)
 504                 type = ctf_add_struct(ctfp, flag, name);
 505         else
 506                 type = ctf_add_union(ctfp, flag, name);
 507 
 508         if (type == CTF_ERR || ctf_update(ctfp) == CTF_ERR) {
 509                 xyerror(D_UNKNOWN, "failed to define %s: %s\n",
 510                     n, ctf_errmsg(ctf_errno(ctfp)));
 511         }
 512 
 513         ddp->dd_ctfp = ctfp;
 514         ddp->dd_type = type;
 515 
 516         dt_scope_push(ctfp, type);
 517         return (ddp);
 518 }
 519 
 520 void
 521 dt_decl_member(dt_node_t *dnp)
 522 {
 523         dt_scope_t *dsp = yypcb->pcb_dstack.ds_next;
 524         dt_decl_t *ddp = yypcb->pcb_dstack.ds_decl;
 525         char *ident = yypcb->pcb_dstack.ds_ident;
 526 
 527         const char *idname = ident ? ident : "(anon)";
 528         char n[DT_TYPE_NAMELEN];
 529 
 530         dtrace_typeinfo_t dtt;
 531         ctf_encoding_t cte;
 532         ctf_id_t base;
 533         uint_t kind;
 534         ssize_t size;
 535 
 536         if (dsp == NULL)
 537                 longjmp(yypcb->pcb_jmpbuf, EDT_NOSCOPE);
 538 
 539         if (ddp == NULL)
 540                 longjmp(yypcb->pcb_jmpbuf, EDT_NODECL);
 541 
 542         if (dnp == NULL && ident == NULL)
 543                 xyerror(D_DECL_MNAME, "member declaration requires a name\n");
 544 
 545         if (ddp->dd_kind == CTF_K_UNKNOWN && ddp->dd_name == NULL) {
 546                 ddp->dd_kind = CTF_K_INTEGER;
 547                 (void) dt_decl_check(ddp);
 548         }
 549 
 550         if (dt_decl_type(ddp, &dtt) != 0)
 551                 longjmp(yypcb->pcb_jmpbuf, EDT_COMPILER);
 552 
 553         if (ident != NULL && strchr(ident, '`') != NULL) {
 554                 xyerror(D_DECL_SCOPE, "D scoping operator may not be used "
 555                     "in a member name (%s)\n", ident);
 556         }
 557 
 558         if (dtt.dtt_ctfp == DT_DYN_CTFP(yypcb->pcb_hdl) &&
 559             dtt.dtt_type == DT_DYN_TYPE(yypcb->pcb_hdl)) {
 560                 xyerror(D_DECL_DYNOBJ,
 561                     "cannot have dynamic member: %s\n", ident);
 562         }
 563 
 564         base = ctf_type_resolve(dtt.dtt_ctfp, dtt.dtt_type);
 565         kind = ctf_type_kind(dtt.dtt_ctfp, base);
 566         size = ctf_type_size(dtt.dtt_ctfp, base);
 567 
 568         if (kind == CTF_K_FORWARD || ((kind == CTF_K_STRUCT ||
 569             kind == CTF_K_UNION) && size == 0)) {
 570                 xyerror(D_DECL_INCOMPLETE, "incomplete struct/union/enum %s: "
 571                     "%s\n", dt_type_name(dtt.dtt_ctfp, dtt.dtt_type,
 572                     n, sizeof (n)), ident);
 573         }
 574 
 575         if (size == 0)
 576                 xyerror(D_DECL_VOIDOBJ, "cannot have void member: %s\n", ident);
 577 
 578         /*
 579          * If a bit-field qualifier was part of the member declaration, create
 580          * a new integer type of the same name and attributes as the base type
 581          * and size equal to the specified number of bits.  We reset 'dtt' to
 582          * refer to this new bit-field type and continue on to add the member.
 583          */
 584         if (dnp != NULL) {
 585                 dnp = dt_node_cook(dnp, DT_IDFLG_REF);
 586 
 587                 /*
 588                  * A bit-field member with no declarator is permitted to have
 589                  * size zero and indicates that no more fields are to be packed
 590                  * into the current storage unit.  We ignore these directives
 591                  * as the underlying ctf code currently does so for all fields.
 592                  */
 593                 if (ident == NULL && dnp->dn_kind == DT_NODE_INT &&
 594                     dnp->dn_value == 0) {
 595                         dt_node_free(dnp);
 596                         goto done;
 597                 }
 598 
 599                 if (dt_node_is_posconst(dnp) == 0) {
 600                         xyerror(D_DECL_BFCONST, "positive integral constant "
 601                             "expression expected as bit-field size\n");
 602                 }
 603 
 604                 if (ctf_type_kind(dtt.dtt_ctfp, base) != CTF_K_INTEGER ||
 605                     ctf_type_encoding(dtt.dtt_ctfp, base, &cte) == CTF_ERR ||
 606                     IS_VOID(cte)) {
 607                         xyerror(D_DECL_BFTYPE, "invalid type for "
 608                             "bit-field: %s\n", idname);
 609                 }
 610 
 611                 if (dnp->dn_value > cte.cte_bits) {
 612                         xyerror(D_DECL_BFSIZE, "bit-field too big "
 613                             "for type: %s\n", idname);
 614                 }
 615 
 616                 cte.cte_offset = 0;
 617                 cte.cte_bits = (uint_t)dnp->dn_value;
 618 
 619                 dtt.dtt_type = ctf_add_integer(dsp->ds_ctfp,
 620                     CTF_ADD_NONROOT, ctf_type_name(dtt.dtt_ctfp,
 621                     dtt.dtt_type, n, sizeof (n)), &cte);
 622 
 623                 if (dtt.dtt_type == CTF_ERR ||
 624                     ctf_update(dsp->ds_ctfp) == CTF_ERR) {
 625                         xyerror(D_UNKNOWN, "failed to create type for "
 626                             "member '%s': %s\n", idname,
 627                             ctf_errmsg(ctf_errno(dsp->ds_ctfp)));
 628                 }
 629 
 630                 dtt.dtt_ctfp = dsp->ds_ctfp;
 631                 dt_node_free(dnp);
 632         }
 633 
 634         /*
 635          * If the member type is not defined in the same CTF container as the
 636          * one associated with the current scope (i.e. the container for the
 637          * struct or union itself) or its parent, copy the member type into
 638          * this container and reset dtt to refer to the copied type.
 639          */
 640         if (dtt.dtt_ctfp != dsp->ds_ctfp &&
 641             dtt.dtt_ctfp != ctf_parent_file(dsp->ds_ctfp)) {
 642 
 643                 dtt.dtt_type = ctf_add_type(dsp->ds_ctfp,
 644                     dtt.dtt_ctfp, dtt.dtt_type);
 645                 dtt.dtt_ctfp = dsp->ds_ctfp;
 646 
 647                 if (dtt.dtt_type == CTF_ERR ||
 648                     ctf_update(dtt.dtt_ctfp) == CTF_ERR) {
 649                         xyerror(D_UNKNOWN, "failed to copy type of '%s': %s\n",
 650                             idname, ctf_errmsg(ctf_errno(dtt.dtt_ctfp)));
 651                 }
 652         }
 653 
 654         if (ctf_add_member(dsp->ds_ctfp, dsp->ds_type,
 655             ident, dtt.dtt_type, ULONG_MAX) == CTF_ERR) {
 656                 xyerror(D_UNKNOWN, "failed to define member '%s': %s\n",
 657                     idname, ctf_errmsg(ctf_errno(dsp->ds_ctfp)));
 658         }
 659 
 660 done:
 661         free(ident);
 662         yypcb->pcb_dstack.ds_ident = NULL;
 663         dt_decl_reset();
 664 }
 665 
 666 /*ARGSUSED*/
 667 static int
 668 dt_decl_hasmembers(const char *name, int value, void *private)
 669 {
 670         return (1); /* abort search and return true if a member exists */
 671 }
 672 
 673 dt_decl_t *
 674 dt_decl_enum(char *name)
 675 {
 676         dt_decl_t *ddp = dt_decl_spec(CTF_K_ENUM, name);
 677         char n[DT_TYPE_NAMELEN];
 678         ctf_file_t *ctfp;
 679         ctf_id_t type;
 680         uint_t flag;
 681 
 682         if (yypcb->pcb_idepth != 0)
 683                 ctfp = yypcb->pcb_hdl->dt_cdefs->dm_ctfp;
 684         else
 685                 ctfp = yypcb->pcb_hdl->dt_ddefs->dm_ctfp;
 686 
 687         if (yypcb->pcb_dstack.ds_next != NULL)
 688                 flag = CTF_ADD_NONROOT;
 689         else
 690                 flag = CTF_ADD_ROOT;
 691 
 692         (void) snprintf(n, sizeof (n), "enum %s", name ? name : "(anon)");
 693 
 694         if (name != NULL && (type = ctf_lookup_by_name(ctfp, n)) != CTF_ERR) {
 695                 if (ctf_enum_iter(ctfp, type, dt_decl_hasmembers, NULL))
 696                         xyerror(D_DECL_TYPERED, "type redeclared: %s\n", n);
 697         } else if ((type = ctf_add_enum(ctfp, flag, name, 0)) == CTF_ERR) {
 698                 xyerror(D_UNKNOWN, "failed to define %s: %s\n",
 699                     n, ctf_errmsg(ctf_errno(ctfp)));
 700         }
 701 
 702         ddp->dd_ctfp = ctfp;
 703         ddp->dd_type = type;
 704 
 705         dt_scope_push(ctfp, type);
 706         return (ddp);
 707 }
 708 
 709 void
 710 dt_decl_enumerator(char *s, dt_node_t *dnp)
 711 {
 712         dt_scope_t *dsp = yypcb->pcb_dstack.ds_next;
 713         dtrace_hdl_t *dtp = yypcb->pcb_hdl;
 714 
 715         dt_idnode_t *inp;
 716         dt_ident_t *idp;
 717         char *name;
 718         int value;
 719 
 720         name = strdupa(s);
 721         free(s);
 722 
 723         if (dsp == NULL)
 724                 longjmp(yypcb->pcb_jmpbuf, EDT_NOSCOPE);
 725 
 726         assert(dsp->ds_decl->dd_kind == CTF_K_ENUM);
 727         value = dsp->ds_enumval + 1; /* default is previous value plus one */
 728 
 729         if (strchr(name, '`') != NULL) {
 730                 xyerror(D_DECL_SCOPE, "D scoping operator may not be used in "
 731                     "an enumerator name (%s)\n", name);
 732         }
 733 
 734         /*
 735          * If the enumerator is being assigned a value, cook and check the node
 736          * and then free it after we get the value.  We also permit references
 737          * to identifiers which are previously defined enumerators in the type.
 738          */
 739         if (dnp != NULL) {
 740                 if (dnp->dn_kind != DT_NODE_IDENT || ctf_enum_value(
 741                     dsp->ds_ctfp, dsp->ds_type, dnp->dn_string, &value) != 0) {
 742                         dnp = dt_node_cook(dnp, DT_IDFLG_REF);
 743 
 744                         if (dnp->dn_kind != DT_NODE_INT) {
 745                                 xyerror(D_DECL_ENCONST, "enumerator '%s' must "
 746                                     "be assigned to an integral constant "
 747                                     "expression\n", name);
 748                         }
 749 
 750                         if ((intmax_t)dnp->dn_value > INT_MAX ||
 751                             (intmax_t)dnp->dn_value < INT_MIN) {
 752                                 xyerror(D_DECL_ENOFLOW, "enumerator '%s' value "
 753                                     "overflows INT_MAX (%d)\n", name, INT_MAX);
 754                         }
 755 
 756                         value = (int)dnp->dn_value;
 757                 }
 758                 dt_node_free(dnp);
 759         }
 760 
 761         if (ctf_add_enumerator(dsp->ds_ctfp, dsp->ds_type,
 762             name, value) == CTF_ERR || ctf_update(dsp->ds_ctfp) == CTF_ERR) {
 763                 xyerror(D_UNKNOWN, "failed to define enumerator '%s': %s\n",
 764                     name, ctf_errmsg(ctf_errno(dsp->ds_ctfp)));
 765         }
 766 
 767         dsp->ds_enumval = value; /* save most recent value */
 768 
 769         /*
 770          * If the enumerator name matches an identifier in the global scope,
 771          * flag this as an error.  We only do this for "D" enumerators to
 772          * prevent "C" header file enumerators from conflicting with the ever-
 773          * growing list of D built-in global variables and inlines.  If a "C"
 774          * enumerator conflicts with a global identifier, we add the enumerator
 775          * but do not insert a corresponding inline (i.e. the D variable wins).
 776          */
 777         if (dt_idstack_lookup(&yypcb->pcb_globals, name) != NULL) {
 778                 if (dsp->ds_ctfp == dtp->dt_ddefs->dm_ctfp) {
 779                         xyerror(D_DECL_IDRED,
 780                             "identifier redeclared: %s\n", name);
 781                 } else
 782                         return;
 783         }
 784 
 785         dt_dprintf("add global enumerator %s = %d\n", name, value);
 786 
 787         idp = dt_idhash_insert(dtp->dt_globals, name, DT_IDENT_ENUM,
 788             DT_IDFLG_INLINE | DT_IDFLG_REF, 0, _dtrace_defattr, 0,
 789             &dt_idops_inline, NULL, dtp->dt_gen);
 790 
 791         if (idp == NULL)
 792                 longjmp(yypcb->pcb_jmpbuf, EDT_NOMEM);
 793 
 794         yyintprefix = 0;
 795         yyintsuffix[0] = '\0';
 796         yyintdecimal = 0;
 797 
 798         dnp = dt_node_int(value);
 799         dt_node_type_assign(dnp, dsp->ds_ctfp, dsp->ds_type, B_FALSE);
 800 
 801         if ((inp = malloc(sizeof (dt_idnode_t))) == NULL)
 802                 longjmp(yypcb->pcb_jmpbuf, EDT_NOMEM);
 803 
 804         /*
 805          * Remove the INT node from the node allocation list and store it in
 806          * din_list and din_root so it persists with and is freed by the ident.
 807          */
 808         assert(yypcb->pcb_list == dnp);
 809         yypcb->pcb_list = dnp->dn_link;
 810         dnp->dn_link = NULL;
 811 
 812         bzero(inp, sizeof (dt_idnode_t));
 813         inp->din_list = dnp;
 814         inp->din_root = dnp;
 815 
 816         idp->di_iarg = inp;
 817         idp->di_ctfp = dsp->ds_ctfp;
 818         idp->di_type = dsp->ds_type;
 819 }
 820 
 821 /*
 822  * Look up the type corresponding to the specified decl stack.  The scoping of
 823  * the underlying type names is handled by dt_type_lookup().  We build up the
 824  * name from the specified string and prefixes and then lookup the type.  If
 825  * we fail, an errmsg is saved and the caller must abort with EDT_COMPILER.
 826  */
 827 int
 828 dt_decl_type(dt_decl_t *ddp, dtrace_typeinfo_t *tip)
 829 {
 830         dtrace_hdl_t *dtp = yypcb->pcb_hdl;
 831 
 832         dt_module_t *dmp;
 833         ctf_arinfo_t r;
 834         ctf_id_t type;
 835 
 836         char n[DT_TYPE_NAMELEN];
 837         uint_t flag;
 838         char *name;
 839         int rv;
 840 
 841         tip->dtt_flags = 0;
 842 
 843         /*
 844          * Based on our current #include depth and decl stack depth, determine
 845          * which dynamic CTF module and scope to use when adding any new types.
 846          */
 847         dmp = yypcb->pcb_idepth ? dtp->dt_cdefs : dtp->dt_ddefs;
 848         flag = yypcb->pcb_dstack.ds_next ? CTF_ADD_NONROOT : CTF_ADD_ROOT;
 849 
 850         if (ddp->dd_attr & DT_DA_USER)
 851                 tip->dtt_flags = DTT_FL_USER;
 852 
 853         /*
 854          * If we have already cached a CTF type for this decl, then we just
 855          * return the type information for the cached type.
 856          */
 857         if (ddp->dd_ctfp != NULL &&
 858             (dmp = dt_module_lookup_by_ctf(dtp, ddp->dd_ctfp)) != NULL) {
 859                 tip->dtt_object = dmp->dm_name;
 860                 tip->dtt_ctfp = ddp->dd_ctfp;
 861                 tip->dtt_type = ddp->dd_type;
 862                 return (0);
 863         }
 864 
 865         /*
 866          * Currently CTF treats all function pointers identically.  We cache a
 867          * representative ID of kind CTF_K_FUNCTION and just return that type.
 868          * If we want to support full function declarations, dd_next refers to
 869          * the declaration of the function return type, and the parameter list
 870          * should be parsed and hung off a new pointer inside of this decl.
 871          */
 872         if (ddp->dd_kind == CTF_K_FUNCTION) {
 873                 tip->dtt_object = dtp->dt_ddefs->dm_name;
 874                 tip->dtt_ctfp = DT_FUNC_CTFP(dtp);
 875                 tip->dtt_type = DT_FUNC_TYPE(dtp);
 876                 return (0);
 877         }
 878 
 879         /*
 880          * If the decl is a pointer, resolve the rest of the stack by calling
 881          * dt_decl_type() recursively and then compute a pointer to the result.
 882          * Similar to the code above, we return a cached id for function ptrs.
 883          */
 884         if (ddp->dd_kind == CTF_K_POINTER) {
 885                 if (ddp->dd_next->dd_kind == CTF_K_FUNCTION) {
 886                         tip->dtt_object = dtp->dt_ddefs->dm_name;
 887                         tip->dtt_ctfp = DT_FPTR_CTFP(dtp);
 888                         tip->dtt_type = DT_FPTR_TYPE(dtp);
 889                         return (0);
 890                 }
 891 
 892                 if ((rv = dt_decl_type(ddp->dd_next, tip)) == 0 &&
 893                     (rv = dt_type_pointer(tip)) != 0) {
 894                         xywarn(D_UNKNOWN, "cannot find type: %s*: %s\n",
 895                             dt_type_name(tip->dtt_ctfp, tip->dtt_type,
 896                             n, sizeof (n)), ctf_errmsg(dtp->dt_ctferr));
 897                 }
 898 
 899                 return (rv);
 900         }
 901 
 902         /*
 903          * If the decl is an array, we must find the base type and then call
 904          * dt_decl_type() recursively and then build an array of the result.
 905          * The C and D multi-dimensional array syntax requires that consecutive
 906          * array declarations be processed from right-to-left (i.e. top-down
 907          * from the perspective of the declaration stack).  For example, an
 908          * array declaration such as int x[3][5] is stored on the stack as:
 909          *
 910          * (bottom) NULL <- ( INT "int" ) <- ( ARR [3] ) <- ( ARR [5] ) (top)
 911          *
 912          * but means that x is declared to be an array of 3 objects each of
 913          * which is an array of 5 integers, or in CTF representation:
 914          *
 915          * type T1:( content=int, nelems=5 ) type T2:( content=T1, nelems=3 )
 916          *
 917          * For more details, refer to K&R[5.7] and ISO C 6.5.2.1.  Rather than
 918          * overcomplicate the implementation of dt_decl_type(), we push array
 919          * declarations down into the stack in dt_decl_array(), above, so that
 920          * by the time dt_decl_type() is called, the decl stack looks like:
 921          *
 922          * (bottom) NULL <- ( INT "int" ) <- ( ARR [5] ) <- ( ARR [3] ) (top)
 923          *
 924          * which permits a straightforward recursive descent of the decl stack
 925          * to build the corresponding CTF type tree in the appropriate order.
 926          */
 927         if (ddp->dd_kind == CTF_K_ARRAY) {
 928                 /*
 929                  * If the array decl has a parameter list associated with it,
 930                  * this is an associative array declaration: return <DYN>.
 931                  */
 932                 if (ddp->dd_node != NULL &&
 933                     ddp->dd_node->dn_kind == DT_NODE_TYPE) {
 934                         tip->dtt_object = dtp->dt_ddefs->dm_name;
 935                         tip->dtt_ctfp = DT_DYN_CTFP(dtp);
 936                         tip->dtt_type = DT_DYN_TYPE(dtp);
 937                         return (0);
 938                 }
 939 
 940                 if ((rv = dt_decl_type(ddp->dd_next, tip)) != 0)
 941                         return (rv);
 942 
 943                 /*
 944                  * If the array base type is not defined in the target
 945                  * container or its parent, copy the type to the target
 946                  * container and reset dtt_ctfp and dtt_type to the copy.
 947                  */
 948                 if (tip->dtt_ctfp != dmp->dm_ctfp &&
 949                     tip->dtt_ctfp != ctf_parent_file(dmp->dm_ctfp)) {
 950 
 951                         tip->dtt_type = ctf_add_type(dmp->dm_ctfp,
 952                             tip->dtt_ctfp, tip->dtt_type);
 953                         tip->dtt_ctfp = dmp->dm_ctfp;
 954 
 955                         if (tip->dtt_type == CTF_ERR ||
 956                             ctf_update(tip->dtt_ctfp) == CTF_ERR) {
 957                                 xywarn(D_UNKNOWN, "failed to copy type: %s\n",
 958                                     ctf_errmsg(ctf_errno(tip->dtt_ctfp)));
 959                                 return (-1);
 960                         }
 961                 }
 962 
 963                 /*
 964                  * The array index type is irrelevant in C and D: just set it
 965                  * to "long" for all array types that we create on-the-fly.
 966                  */
 967                 r.ctr_contents = tip->dtt_type;
 968                 r.ctr_index = ctf_lookup_by_name(tip->dtt_ctfp, "long");
 969                 r.ctr_nelems = ddp->dd_node ?
 970                     (uint_t)ddp->dd_node->dn_value : 0;
 971 
 972                 tip->dtt_object = dmp->dm_name;
 973                 tip->dtt_ctfp = dmp->dm_ctfp;
 974                 tip->dtt_type = ctf_add_array(dmp->dm_ctfp, CTF_ADD_ROOT, &r);
 975 
 976                 if (tip->dtt_type == CTF_ERR ||
 977                     ctf_update(tip->dtt_ctfp) == CTF_ERR) {
 978                         xywarn(D_UNKNOWN, "failed to create array type: %s\n",
 979                             ctf_errmsg(ctf_errno(tip->dtt_ctfp)));
 980                         return (-1);
 981                 }
 982 
 983                 return (0);
 984         }
 985 
 986         /*
 987          * Allocate space for the type name and enough space for the maximum
 988          * additional text ("unsigned long long \0" requires 20 more bytes).
 989          */
 990         name = alloca(ddp->dd_name ? strlen(ddp->dd_name) + 20 : 20);
 991         name[0] = '\0';
 992 
 993         switch (ddp->dd_kind) {
 994         case CTF_K_INTEGER:
 995         case CTF_K_FLOAT:
 996                 if (ddp->dd_attr & DT_DA_SIGNED)
 997                         (void) strcat(name, "signed ");
 998                 if (ddp->dd_attr & DT_DA_UNSIGNED)
 999                         (void) strcat(name, "unsigned ");
1000                 if (ddp->dd_attr & DT_DA_SHORT)
1001                         (void) strcat(name, "short ");
1002                 if (ddp->dd_attr & DT_DA_LONG)
1003                         (void) strcat(name, "long ");
1004                 if (ddp->dd_attr & DT_DA_LONGLONG)
1005                         (void) strcat(name, "long long ");
1006                 if (ddp->dd_attr == 0 && ddp->dd_name == NULL)
1007                         (void) strcat(name, "int");
1008                 break;
1009         case CTF_K_STRUCT:
1010                 (void) strcpy(name, "struct ");
1011                 break;
1012         case CTF_K_UNION:
1013                 (void) strcpy(name, "union ");
1014                 break;
1015         case CTF_K_ENUM:
1016                 (void) strcpy(name, "enum ");
1017                 break;
1018         case CTF_K_TYPEDEF:
1019                 break;
1020         default:
1021                 xywarn(D_UNKNOWN, "internal error -- "
1022                     "bad decl kind %u\n", ddp->dd_kind);
1023                 return (-1);
1024         }
1025 
1026         /*
1027          * Add dd_name unless a short, long, or long long is explicitly
1028          * suffixed by int.  We use the C/CTF canonical names for integers.
1029          */
1030         if (ddp->dd_name != NULL && (ddp->dd_kind != CTF_K_INTEGER ||
1031             (ddp->dd_attr & (DT_DA_SHORT | DT_DA_LONG | DT_DA_LONGLONG)) == 0))
1032                 (void) strcat(name, ddp->dd_name);
1033 
1034         /*
1035          * Lookup the type.  If we find it, we're done.  Otherwise create a
1036          * forward tag for the type if it is a struct, union, or enum.  If
1037          * we can't find it and we can't create a tag, return failure.
1038          */
1039         if ((rv = dt_type_lookup(name, tip)) == 0)
1040                 return (rv);
1041 
1042         switch (ddp->dd_kind) {
1043         case CTF_K_STRUCT:
1044         case CTF_K_UNION:
1045         case CTF_K_ENUM:
1046                 type = ctf_add_forward(dmp->dm_ctfp, flag,
1047                     ddp->dd_name, ddp->dd_kind);
1048                 break;
1049         default:
1050                 xywarn(D_UNKNOWN, "failed to resolve type %s: %s\n", name,
1051                     dtrace_errmsg(dtp, dtrace_errno(dtp)));
1052                 return (rv);
1053         }
1054 
1055         if (type == CTF_ERR || ctf_update(dmp->dm_ctfp) == CTF_ERR) {
1056                 xywarn(D_UNKNOWN, "failed to add forward tag for %s: %s\n",
1057                     name, ctf_errmsg(ctf_errno(dmp->dm_ctfp)));
1058                 return (-1);
1059         }
1060 
1061         ddp->dd_ctfp = dmp->dm_ctfp;
1062         ddp->dd_type = type;
1063 
1064         tip->dtt_object = dmp->dm_name;
1065         tip->dtt_ctfp = dmp->dm_ctfp;
1066         tip->dtt_type = type;
1067 
1068         return (0);
1069 }
1070 
1071 void
1072 dt_scope_create(dt_scope_t *dsp)
1073 {
1074         dsp->ds_decl = NULL;
1075         dsp->ds_next = NULL;
1076         dsp->ds_ident = NULL;
1077         dsp->ds_ctfp = NULL;
1078         dsp->ds_type = CTF_ERR;
1079         dsp->ds_class = DT_DC_DEFAULT;
1080         dsp->ds_enumval = -1;
1081 }
1082 
1083 void
1084 dt_scope_destroy(dt_scope_t *dsp)
1085 {
1086         dt_scope_t *nsp;
1087 
1088         for (; dsp != NULL; dsp = nsp) {
1089                 dt_decl_free(dsp->ds_decl);
1090                 free(dsp->ds_ident);
1091                 nsp = dsp->ds_next;
1092                 if (dsp != &yypcb->pcb_dstack)
1093                         free(dsp);
1094         }
1095 }
1096 
1097 void
1098 dt_scope_push(ctf_file_t *ctfp, ctf_id_t type)
1099 {
1100         dt_scope_t *rsp = &yypcb->pcb_dstack;
1101         dt_scope_t *dsp = malloc(sizeof (dt_scope_t));
1102 
1103         if (dsp == NULL)
1104                 longjmp(yypcb->pcb_jmpbuf, EDT_NOMEM);
1105 
1106         dsp->ds_decl = rsp->ds_decl;
1107         dsp->ds_next = rsp->ds_next;
1108         dsp->ds_ident = rsp->ds_ident;
1109         dsp->ds_ctfp = ctfp;
1110         dsp->ds_type = type;
1111         dsp->ds_class = rsp->ds_class;
1112         dsp->ds_enumval = rsp->ds_enumval;
1113 
1114         dt_scope_create(rsp);
1115         rsp->ds_next = dsp;
1116 }
1117 
1118 dt_decl_t *
1119 dt_scope_pop(void)
1120 {
1121         dt_scope_t *rsp = &yypcb->pcb_dstack;
1122         dt_scope_t *dsp = rsp->ds_next;
1123 
1124         if (dsp == NULL)
1125                 longjmp(yypcb->pcb_jmpbuf, EDT_NOSCOPE);
1126 
1127         if (dsp->ds_ctfp != NULL && ctf_update(dsp->ds_ctfp) == CTF_ERR) {
1128                 xyerror(D_UNKNOWN, "failed to update type definitions: %s\n",
1129                     ctf_errmsg(ctf_errno(dsp->ds_ctfp)));
1130         }
1131 
1132         dt_decl_free(rsp->ds_decl);
1133         free(rsp->ds_ident);
1134 
1135         rsp->ds_decl = dsp->ds_decl;
1136         rsp->ds_next = dsp->ds_next;
1137         rsp->ds_ident = dsp->ds_ident;
1138         rsp->ds_ctfp = dsp->ds_ctfp;
1139         rsp->ds_type = dsp->ds_type;
1140         rsp->ds_class = dsp->ds_class;
1141         rsp->ds_enumval = dsp->ds_enumval;
1142 
1143         free(dsp);
1144         return (rsp->ds_decl);
1145 }