Code Review for 2

Prepared by:John Levon on 2020-Jan-07 08:01 -0800 PST
Workspace:/export/home/gk/src/2 (explicit head at 52747083a6bf)
Compare against: previous revision (at da9bf00574dd)
Summary of changes: 2768 lines changed: 1639 ins; 583 del; 546 mod; 25335 unchg
Patch of changes: 2.patch

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/Makefile

12166 resync smatch to 0.6.1-rc1-il-3
5 lines changed: 2 ins; 0 del; 3 mod; 257 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/Makefile

12166 resync smatch to 0.6.1-rc1-il-3
3 lines changed: 1 ins; 0 del; 2 mod; 388 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/check_debug.c

12166 resync smatch to 0.6.1-rc1-il-3
15 lines changed: 14 ins; 0 del; 1 mod; 789 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/check_debug.h

12166 resync smatch to 0.6.1-rc1-il-3
3 lines changed: 3 ins; 0 del; 0 mod; 79 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/check_frees_param.c

12166 resync smatch to 0.6.1-rc1-il-3
17 lines changed: 0 ins; 17 del; 0 mod; 105 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/check_list.h

12166 resync smatch to 0.6.1-rc1-il-3
8 lines changed: 5 ins; 3 del; 0 mod; 222 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/check_locking.c

12166 resync smatch to 0.6.1-rc1-il-3
1247 lines changed: 564 ins; 272 del; 411 mod; 315 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/check_param_mapper.c

12166 resync smatch to 0.6.1-rc1-il-3
66 lines changed: 9 ins; 54 del; 3 mod; 57 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch.c

12166 resync smatch to 0.6.1-rc1-il-3
3 lines changed: 0 ins; 3 del; 0 mod; 368 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch.h

12166 resync smatch to 0.6.1-rc1-il-3
87 lines changed: 74 ins; 9 del; 4 mod; 1331 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_address.c

12166 resync smatch to 0.6.1-rc1-il-3
52 lines changed: 47 ins; 1 del; 4 mod; 297 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_buf_size.c

12166 resync smatch to 0.6.1-rc1-il-3
1 line changed: 1 ins; 0 del; 0 mod; 958 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_comparison.c

12166 resync smatch to 0.6.1-rc1-il-3
104 lines changed: 61 ins; 0 del; 43 mod; 2692 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_container_of.c

12166 resync smatch to 0.6.1-rc1-il-3
297 lines changed: 105 ins; 164 del; 28 mod; 511 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_data/db/create_db.sh

12166 resync smatch to 0.6.1-rc1-il-3
1 line changed: 1 ins; 0 del; 0 mod; 56 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_data/db/fixup_kernel.sh

12166 resync smatch to 0.6.1-rc1-il-3
5 lines changed: 5 ins; 0 del; 0 mod; 225 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/tools/smatch/src/smatch_data/db/insert_manual_states.pl

12166 resync smatch to 0.6.1-rc1-il-3
93 lines changed: 93 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/tools/smatch/src/smatch_data/db/kernel.insert.return_states

12166 resync smatch to 0.6.1-rc1-il-3
12 lines changed: 12 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_data/illumos_kernel.skipped_functions

12166 resync smatch to 0.6.1-rc1-il-3
1 line changed: 1 ins; 0 del; 0 mod; 14 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_data/kernel.no_inline_functions

12166 resync smatch to 0.6.1-rc1-il-3
2 lines changed: 2 ins; 0 del; 0 mod; 14 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_db.c

12166 resync smatch to 0.6.1-rc1-il-3
202 lines changed: 130 ins; 47 del; 25 mod; 2594 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_expressions.c

12166 resync smatch to 0.6.1-rc1-il-3
13 lines changed: 13 ins; 0 del; 0 mod; 320 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_extra.c

12166 resync smatch to 0.6.1-rc1-il-3
25 lines changed: 16 ins; 5 del; 4 mod; 2937 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_extra.h

12166 resync smatch to 0.6.1-rc1-il-3
1 line changed: 1 ins; 0 del; 0 mod; 237 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_function_hooks.c

12166 resync smatch to 0.6.1-rc1-il-3
20 lines changed: 13 ins; 7 del; 0 mod; 1251 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_helper.c

12166 resync smatch to 0.6.1-rc1-il-3
27 lines changed: 27 ins; 0 del; 0 mod; 1215 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_implied.c

12166 resync smatch to 0.6.1-rc1-il-3
47 lines changed: 35 ins; 1 del; 11 mod; 1133 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_math.c

12166 resync smatch to 0.6.1-rc1-il-3
3 lines changed: 3 ins; 0 del; 0 mod; 1874 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/tools/smatch/src/smatch_parsed_conditions.c

12166 resync smatch to 0.6.1-rc1-il-3
121 lines changed: 121 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_ranges.c

12166 resync smatch to 0.6.1-rc1-il-3
11 lines changed: 10 ins; 0 del; 1 mod; 2150 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_scripts/build_generic_data.sh

12166 resync smatch to 0.6.1-rc1-il-3
1 line changed: 0 ins; 0 del; 1 mod; 73 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_scripts/build_kernel_data.sh

12166 resync smatch to 0.6.1-rc1-il-3
1 line changed: 0 ins; 0 del; 1 mod; 48 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_scripts/gen_rosenberg_funcs.sh

12166 resync smatch to 0.6.1-rc1-il-3
1 line changed: 1 ins; 0 del; 0 mod; 33 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_scripts/kpatch.sh

12166 resync smatch to 0.6.1-rc1-il-3
5 lines changed: 3 ins; 0 del; 2 mod; 118 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_states.c

12166 resync smatch to 0.6.1-rc1-il-3
9 lines changed: 9 ins; 0 del; 0 mod; 1170 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_sval.c

12166 resync smatch to 0.6.1-rc1-il-3
167 lines changed: 165 ins; 0 del; 2 mod; 713 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/smatch/src/smatch_type.c

12166 resync smatch to 0.6.1-rc1-il-3
72 lines changed: 72 ins; 0 del; 0 mod; 791 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/tools/smatch/src/validation/sm_float1.c

12166 resync smatch to 0.6.1-rc1-il-3
20 lines changed: 20 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /export/home/gk/src/grot/cwebrev. Webrev is maintained by the illumos project. The latest version may be obtained here.