Code Review for 2

Prepared by:John Levon on 2019-Aug-20 09:24 -0700 PDT
Workspace:/export/home/gk/src/2 (explicit head at ec5730b82cc0)
Compare against: previous revision (at e534abf630a8)
Summary of changes: 349 lines changed: 288 ins; 35 del; 26 mod; 4584 unchg
Patch of changes: 2.patch

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/common/mdb/mdb_ctf.c

11584 ::xcall would be useful
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
Reviewed by: Robert Mustacchi <rm@joyent.com>
18 lines changed: 7 ins; 1 del; 10 mod; 2203 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/common/mdb/mdb_ctf.h

11584 ::xcall would be useful
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
Reviewed by: Robert Mustacchi <rm@joyent.com>
2 lines changed: 1 ins; 0 del; 1 mod; 167 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/i86pc/modules/unix/amd64/Makefile

11584 ::xcall would be useful
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
Reviewed by: Robert Mustacchi <rm@joyent.com>
2 lines changed: 0 ins; 0 del; 2 mod; 47 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/i86pc/modules/unix/unix.c

11584 ::xcall would be useful
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
Reviewed by: Robert Mustacchi <rm@joyent.com>
8 lines changed: 4 ins; 0 del; 4 mod; 1088 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/mdb/i86pc/modules/unix/xcall.c

11584 ::xcall would be useful
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
Reviewed by: Robert Mustacchi <rm@joyent.com>
237 lines changed: 237 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/i86xpv/modules/unix/amd64/Makefile

11584 ::xcall would be useful
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
Reviewed by: Robert Mustacchi <rm@joyent.com>
2 lines changed: 0 ins; 0 del; 2 mod; 51 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/os/x_call.c

11584 ::xcall would be useful
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
Reviewed by: Robert Mustacchi <rm@joyent.com>
64 lines changed: 29 ins; 29 del; 6 mod; 673 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/sys/machcpuvar.h

11584 ::xcall would be useful
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
Reviewed by: Robert Mustacchi <rm@joyent.com>
2 lines changed: 1 ins; 0 del; 1 mod; 270 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/sys/x_call.h

11584 ::xcall would be useful
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
Reviewed by: Robert Mustacchi <rm@joyent.com>
14 lines changed: 9 ins; 5 del; 0 mod; 85 unchg

This code review page was prepared using /export/home/gk/src/grot/cwebrev. Webrev is maintained by the illumos project. The latest version may be obtained here.