11422 ztest needs smatch flag

          --- old/usr/src/cmd/ztest/Makefile.com
          +++ new/usr/src/cmd/ztest/Makefile.com

   1    1  #
   2    2  # CDDL HEADER START
   3    3  #
   4    4  # The contents of this file are subject to the terms of the
   5    5  # Common Development and Distribution License (the "License").
   6    6  # You may not use this file except in compliance with the License.
   7    7  #
   8    8  # You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
   9    9  # or http://www.opensolaris.org/os/licensing.
  10   10  # See the License for the specific language governing permissions
  11   11  # and limitations under the License.
  12   12  #
  13   13  # When distributing Covered Code, include this CDDL HEADER in each
  14   14  # file and include the License file at usr/src/OPENSOLARIS.LICENSE.

  15   15  # If applicable, add the following below this CDDL HEADER, with the
  16   16  # fields enclosed by brackets "[]" replaced with your own identifying
  17   17  # information: Portions Copyright [yyyy] [name of copyright owner]
  18   18  #
  19   19  # CDDL HEADER END
  20   20  #
  21   21  #
  22   22  # Copyright (c) 2005, 2010, Oracle and/or its affiliates. All rights reserved.
  23   23  # Copyright (c) 2012, 2016 by Delphix. All rights reserved.
  24   24  # Copyright 2017 RackTop Systems.
  25      -# Copyright 2019, Joyent, Inc.
       25 +# Copyright 2019 Joyent, Inc.
  26   26  
  27   27  PROG= ztest
  28   28  OBJS= $(PROG).o
  29   29  SRCS= $(OBJS:%.o=../%.c)
  30   30  
  31   31  include ../../Makefile.cmd
  32   32  include ../../Makefile.ctf
  33   33  
  34   34  INCS += -I../../../lib/libzpool/common
  35   35  INCS += -I../../../uts/common/fs/zfs

  36   36  INCS += -I../../../uts/common/fs/zfs/lua
  37   37  INCS += -I../../../common/zfs
  38   38  
  39   39  LDLIBS += -lumem -lzpool -lcmdutils -lm -lnvpair -lfakekernel -lzfs
  40   40  
  41   41  CSTD= $(CSTD_GNU99)
  42   42  C99LMODE= -Xc99=%all
  43   43  CFLAGS += -g $(CCVERBOSE)
  44   44  CFLAGS64 += -g $(CCVERBOSE)
  45   45  CPPFLAGS.first = -I$(SRC)/lib/libfakekernel/common -D_FAKE_KERNEL
  46   46  CPPFLAGS += -D_LARGEFILE64_SOURCE=1 -D_REENTRANT $(INCS) -DDEBUG
  47   47  
  48   48  # lint complains about unused _umem_* functions
  49   49  LINTFLAGS += -xerroff=E_NAME_DEF_NOT_USED2
  50   50  LINTFLAGS64 += -xerroff=E_NAME_DEF_NOT_USED2
  51   51  
  52   52  # lint complains about unused inline functions, even though

  53   53  # they are "inline", not "static inline", with "extern inline"
  54   54  # implementations and usage in libzpool.
  55   55  LINTFLAGS += -erroff=E_STATIC_UNUSED
  56   56  LINTFLAGS64 += -erroff=E_STATIC_UNUSED
  57   57  
  58   58  CERRWARN += -_gcc=-Wno-switch
  59   59  
  60   60  # false positive
  61   61  SMOFF += signed
  62   62  
       63 +# needs work
       64 +SMOFF += all_func_returns
       65 +
  63   66  .KEEP_STATE:
  64   67  
  65   68  all: $(PROG)
  66   69  
  67   70  $(PROG): $(OBJS)
  68   71          $(LINK.c) -o $(PROG) $(OBJS) $(LDLIBS)
  69   72          $(POST_PROCESS)
  70   73  
  71   74  clean:
  72   75          $(RM) $(OBJS)
  73   76  
  74   77  lint:   lint_SRCS
  75   78  
  76   79  include ../../Makefile.targ
  77   80  
  78   81  %.o: ../%.c
  79   82          $(COMPILE.c) $<
  80   83          $(POST_PROCESS_O)
    

XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX