Code Review for illumos-gate

Prepared by:John Levon on 2019-Apr-23 05:35 -0700 PDT
Workspace:/export/home/gk/src/illumos-gate (explicit head at bd687a44e5b3)
Compare against: previous revision (at dc0fabdd506f)
Summary of changes: 4694 lines changed: 4693 ins; 0 del; 1 mod; 21 unchg
Patch of changes: illumos-gate.patch
Printable review: illumos-gate.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/test/util-tests/tests/Makefile

10814 Want primordial CTF test suite
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
2 lines changed: 1 ins; 0 del; 1 mod; 21 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/ctf/Makefile

10814 Want primordial CTF test suite
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
149 lines changed: 149 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/ctf/Makefile.ctftest.com

10814 Want primordial CTF test suite
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
92 lines changed: 92 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/ctf/README

10814 Want primordial CTF test suite
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
54 lines changed: 54 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/ctf/check-array.c

10814 Want primordial CTF test suite
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
116 lines changed: 116 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/ctf/check-common.c

10814 Want primordial CTF test suite
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
802 lines changed: 802 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/ctf/check-common.h

10814 Want primordial CTF test suite
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
141 lines changed: 141 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/ctf/check-enum.c

10814 Want primordial CTF test suite
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
143 lines changed: 143 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/ctf/check-float.c

10814 Want primordial CTF test suite
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
80 lines changed: 80 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/ctf/check-forward.c

10814 Want primordial CTF test suite
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
130 lines changed: 130 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/ctf/check-function.c

10814 Want primordial CTF test suite
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
88 lines changed: 88 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/ctf/check-int.c

10814 Want primordial CTF test suite
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
88 lines changed: 88 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/ctf/check-merge-dedup.c

10814 Want primordial CTF test suite
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
82 lines changed: 82 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/ctf/check-merge-forward.c

10814 Want primordial CTF test suite
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
132 lines changed: 132 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/ctf/check-merge-reduction.c

10814 Want primordial CTF test suite
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
72 lines changed: 72 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/ctf/check-merge-static.c

10814 Want primordial CTF test suite
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
290 lines changed: 290 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/ctf/check-merge-weak.c

10814 Want primordial CTF test suite
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
70 lines changed: 70 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/ctf/check-reference.c

10814 Want primordial CTF test suite
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
197 lines changed: 197 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/ctf/check-sou.c

10814 Want primordial CTF test suite
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
405 lines changed: 405 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/ctf/check-weak.c

10814 Want primordial CTF test suite
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
70 lines changed: 70 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/ctf/ctftest.ksh

10814 Want primordial CTF test suite
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
257 lines changed: 257 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/ctf/test-array.c

10814 Want primordial CTF test suite
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/ctf/test-enum.c

10814 Want primordial CTF test suite
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
74 lines changed: 74 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/ctf/test-float.c

10814 Want primordial CTF test suite
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
28 lines changed: 28 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/ctf/test-forward.c

10814 Want primordial CTF test suite
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
34 lines changed: 34 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/ctf/test-function.c

10814 Want primordial CTF test suite
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
71 lines changed: 71 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/ctf/test-int.c

10814 Want primordial CTF test suite
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
34 lines changed: 34 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/ctf/test-merge-dedup/Makefile.ctftest

10814 Want primordial CTF test suite
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
39 lines changed: 39 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/ctf/test-merge-dedup/test-merge-1.c

10814 Want primordial CTF test suite
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
27 lines changed: 27 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/ctf/test-merge-dedup/test-merge-2.c

10814 Want primordial CTF test suite
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
27 lines changed: 27 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/ctf/test-merge-dedup/test-merge-3.c

10814 Want primordial CTF test suite
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
27 lines changed: 27 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/ctf/test-merge-dedup/test-merge-dedup.c

10814 Want primordial CTF test suite
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
33 lines changed: 33 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/ctf/test-merge-forward/Makefile.ctftest

10814 Want primordial CTF test suite
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/ctf/test-merge-forward/test-impl.c

10814 Want primordial CTF test suite
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/ctf/test-merge-forward/test-merge.c

10814 Want primordial CTF test suite
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/ctf/test-merge-reduction/Makefile.ctftest

10814 Want primordial CTF test suite
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
92 lines changed: 92 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/ctf/test-merge-reduction/mapfile-vers

10814 Want primordial CTF test suite
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
37 lines changed: 37 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/ctf/test-merge-reduction/test-global.c

10814 Want primordial CTF test suite
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
25 lines changed: 25 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/ctf/test-merge-reduction/test-scoped.c

10814 Want primordial CTF test suite
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/ctf/test-merge-static/Makefile.ctftest

10814 Want primordial CTF test suite
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
42 lines changed: 42 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/ctf/test-merge-static/test-a.c

10814 Want primordial CTF test suite
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/ctf/test-merge-static/test-b.c

10814 Want primordial CTF test suite
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/ctf/test-merge-static/test-c.c

10814 Want primordial CTF test suite
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/ctf/test-merge-static/test-d.c

10814 Want primordial CTF test suite
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
24 lines changed: 24 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/ctf/test-merge-static/test-main.c

10814 Want primordial CTF test suite
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
28 lines changed: 28 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/ctf/test-merge-weak/Makefile.ctftest

10814 Want primordial CTF test suite
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
23 lines changed: 23 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/ctf/test-merge-weak/test-merge-weak.c

10814 Want primordial CTF test suite
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
33 lines changed: 33 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/ctf/test-reference.c

10814 Want primordial CTF test suite
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
44 lines changed: 44 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/ctf/test-sou.c

10814 Want primordial CTF test suite
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
246 lines changed: 246 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/test/util-tests/tests/ctf/test-weak.c

10814 Want primordial CTF test suite
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
25 lines changed: 25 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /export/home/gk/bin/cwebrev. Webrev is maintained by the illumos project. The latest version may be obtained here.