Code Review for illumos-gate

Prepared by:John Levon on 2019-Apr-23 05:24 -0700 PDT
Workspace:/export/home/gk/src/illumos-gate (explicit head at dc0fabdd506f)
Compare against: previous revision (at b4aa415ef0fc)
Summary of changes: 696 lines changed: 393 ins; 166 del; 137 mod; 7474 unchg
Patch of changes: illumos-gate.patch
Printable review: illumos-gate.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/common/ctf/ctf_create.c

10812 ctf tools shouldn't add blank labels
10813 ctf symbol mapping needs work
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
2 lines changed: 1 ins; 0 del; 1 mod; 2195 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libctf/common/ctf_convert.c

10812 ctf tools shouldn't add blank labels
10813 ctf symbol mapping needs work
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
4 lines changed: 0 ins; 2 del; 2 mod; 206 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libctf/common/ctf_dwarf.c

10812 ctf tools shouldn't add blank labels
10813 ctf symbol mapping needs work
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
184 lines changed: 74 ins; 65 del; 45 mod; 2885 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libctf/common/ctf_lib.c

10812 ctf tools shouldn't add blank labels
10813 ctf symbol mapping needs work
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
93 lines changed: 89 ins; 0 del; 4 mod; 762 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libctf/common/ctf_merge.c

10812 ctf tools shouldn't add blank labels
10813 ctf symbol mapping needs work
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
403 lines changed: 221 ins; 99 del; 83 mod; 1369 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libctf/common/libctf_impl.h

10812 ctf tools shouldn't add blank labels
10813 ctf symbol mapping needs work
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
10 lines changed: 8 ins; 0 del; 2 mod; 57 unchg

This code review page was prepared using /export/home/gk/bin/cwebrev. Webrev is maintained by the illumos project. The latest version may be obtained here.