Print this page
10703 smatch unreachable code checking needs reworking
Reviewed by: Toomas Soome <tsoome@me.com>
Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>

Split Close
Expand all
Collapse all
          --- old/usr/src/uts/common/io/usbgem/usbgem.c
          +++ new/usr/src/uts/common/io/usbgem/usbgem.c
↓ open down ↓ 24 lines elided ↑ open up ↑
  25   25   * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
  26   26   * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
  27   27   * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
  28   28   * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
  29   29   * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT
  30   30   * OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH
  31   31   * DAMAGE.
  32   32   */
  33   33  
  34   34  /*
       35 + * Copyright 2019 Joyent, Inc.
       36 + */
       37 +
       38 +/*
  35   39   * Change log
  36   40   */
  37   41  
  38   42  /*
  39   43   * TODO:
  40   44   *      implement DELAYED_START
  41   45   */
  42   46  
  43   47  /*
  44   48   * System Header files.
↓ open down ↓ 1999 lines elided ↑ open up ↑
2044 2048                  if (!dp->mii_supress_msg) {
2045 2049                          cmn_err(CE_CONT, "!%s: restarting auto-negotiation",
2046 2050                              dp->name);
2047 2051                  }
2048 2052                  dp->mii_supress_msg = B_TRUE;
2049 2053                  goto autonego;
2050 2054  
2051 2055          default:
2052 2056                  cmn_err(CE_PANIC, "!%s: unknowm linkdown action: %d",
2053 2057                      dp->name, dp->ugc.usbgc_mii_linkdown_action);
2054      -                dp->mii_supress_msg = B_TRUE;
2055 2058          }
2056 2059          /* NOTREACHED */
2057 2060  
2058 2061  reset_phy:
2059 2062          if (!dp->mii_supress_msg) {
2060 2063                  cmn_err(CE_CONT, "!%s: resetting PHY", dp->name);
2061 2064          }
2062 2065          dp->mii_state = MII_STATE_RESETTING;
2063 2066          dp->mii_timer = dp->ugc.usbgc_mii_reset_timeout;
2064 2067          if (!dp->ugc.usbgc_mii_dont_reset) {
↓ open down ↓ 4319 lines elided ↑ open up ↑
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX