Print this page
10703 smatch unreachable code checking needs reworking
Reviewed by: Toomas Soome <tsoome@me.com>
Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>

Split Close
Expand all
Collapse all
          --- old/usr/src/uts/common/io/i40e/i40e_main.c
          +++ new/usr/src/uts/common/io/i40e/i40e_main.c
↓ open down ↓ 1676 lines elided ↑ open up ↑
1677 1677                              DDI_SERVICE_DEGRADED);
1678 1678                          return (B_FALSE);
1679 1679                  }
1680 1680                  request = (reg & I40E_GLPCI_CNF2_MSI_X_PF_N_MASK) >>
1681 1681                      I40E_GLPCI_CNF2_MSI_X_PF_N_SHIFT;
1682 1682                  request++;      /* the register value is n - 1 */
1683 1683                  break;
1684 1684          default:
1685 1685                  panic("bad interrupt type passed to i40e_alloc_intr_handles: "
1686 1686                      "%d", intr_type);
1687      -                return (B_FALSE);
1688 1687          }
1689 1688  
1690 1689          rc = ddi_intr_get_nintrs(devinfo, intr_type, &count);
1691 1690          if (rc != DDI_SUCCESS || count < min) {
1692 1691                  i40e_log(i40e, "Get interrupt number failed, "
1693 1692                      "returned %d, count %d", rc, count);
1694 1693                  return (B_FALSE);
1695 1694          }
1696 1695  
1697 1696          rc = ddi_intr_get_navail(devinfo, intr_type, &count);
↓ open down ↓ 1854 lines elided ↑ open up ↑
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX