Print this page
10703 smatch unreachable code checking needs reworking
Reviewed by: Toomas Soome <tsoome@me.com>
Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>

@@ -9101,11 +9101,10 @@
                                  * ip_*put_options should have already
                                  * dropped this packet.
                                  */
                                 cmn_err(CE_PANIC, "ip_forward_options: "
                                     "unknown IT - bug in ip_input_options?\n");
-                                return (B_TRUE);        /* Keep "lint" happy */
                         }
                         if (opt[IPOPT_OFFSET] - 1 + off > optlen) {
                                 /* Increase overflow counter */
                                 off = (opt[IPOPT_POS_OV_FLG] >> 4) + 1;
                                 opt[IPOPT_POS_OV_FLG] =

@@ -9328,11 +9327,10 @@
                                  * ip_*put_options should have already
                                  * dropped this packet.
                                  */
                                 cmn_err(CE_PANIC, "ip_input_local_options: "
                                     "unknown IT - bug in ip_input_options?\n");
-                                return (B_TRUE);        /* Keep "lint" happy */
                         }
                         if (opt[IPOPT_OFFSET] - 1 + off > optlen) {
                                 /* Increase overflow counter */
                                 off = (opt[IPOPT_POS_OV_FLG] >> 4) + 1;
                                 opt[IPOPT_POS_OV_FLG] =

@@ -12016,11 +12014,10 @@
                                  * ip_*put_options should have already
                                  * dropped this packet.
                                  */
                                 cmn_err(CE_PANIC, "ip_output_local_options: "
                                     "unknown IT - bug in ip_output_options?\n");
-                                return; /* Keep "lint" happy */
                         }
                         if (opt[IPOPT_OFFSET] - 1 + off > optlen) {
                                 /* Increase overflow counter */
                                 off = (opt[IPOPT_POS_OV_FLG] >> 4) + 1;
                                 opt[IPOPT_POS_OV_FLG] = (uint8_t)