10703 smatch unreachable code checking needs reworking
Reviewed by: Toomas Soome <tsoome@me.com>
Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>

          --- old/usr/src/test/libc-tests/tests/Makefile
          +++ new/usr/src/test/libc-tests/tests/Makefile

   1    1  #
   2    2  # This file and its contents are supplied under the terms of the
   3    3  # Common Development and Distribution License ("CDDL"), version 1.0.
   4    4  # You may only use this file in accordance with the terms of version

   5    5  # 1.0 of the CDDL.
   6    6  #
   7    7  # A full copy of the text of the CDDL should have accompanied this
   8    8  # source.  A copy of the CDDL is also available via the Internet at
   9    9  # http://www.illumos.org/license/CDDL.
  10   10  #
  11   11  
  12   12  #
  13   13  # Copyright (c) 2012 by Delphix. All rights reserved.
  14   14  # Copyright 2015 Garrett D'Amore <garrett@damore.org>
  15      -# Copyright (c) 2018, Joyent, Inc.
       15 +# Copyright 2019 Joyent, Inc.
  16   16  #
  17   17  
  18   18  SUBDIRS = \
  19   19          catopen \
  20   20          fpround \
  21   21          newlocale \
  22   22          nl_langinfo \
  23   23          priv_gettext \
  24   24          random \
  25   25          regex \

  26   26          select \
  27   27          strerror \
  28   28          symbols \
  29   29          threads \
  30   30          wcsrtombs \
  31   31          wctype
  32   32  
  33   33  PROGS = \
  34   34          aligned_alloc \
  35   35          c11_threads \
  36   36          c11_tss \
  37   37          call_once \
  38   38          endian \
  39   39          env-7076 \
  40   40          fnmatch \
  41   41          memset_s \
  42   42          posix_memalign \
  43   43          printf-9511 \
  44   44          psignal-5097 \
  45   45          quick_exit_order \
  46   46          quick_exit_status \
  47   47          set_constraint_handler_s \
  48   48          strcoll-strxfrm-6907 \
  49   49          timespec_get \
  50   50          wcsncasecmp \

  51   51          wcsncasecmp-7344 \
  52   52          wcsncasecmp-7350
  53   53  
  54   54  SCRIPTS = \
  55   55          quick_exit \
  56   56          psignal
  57   57  
  58   58  CPPFLAGS += -D_REENTRANT
  59   59  
  60   60  # needs work
  61      -SMOFF += all_func_returns,snprintf_overflow
       61 +SMOFF += all_func_returns,snprintf_overflow,unreachable
  62   62  
  63   63  PROGS32 = $(PROGS:%=%.32)
  64   64  PROGS64 = \
  65   65          $(PROGS:%=%.64) \
  66   66          printf-6961.64
  67   67  
  68   68  aligned_alloc.32 :=     LDLIBS += -lproc
  69   69  aligned_alloc.64 :=     LDLIBS64 += -lproc
  70   70  posix_memalign.32 :=    LDLIBS += -lproc
  71   71  posix_memalign.64 :=    LDLIBS64 += -lproc

  72   72  
  73   73  memset_s.32 :=  CPPFLAGS += -D__STDC_WANT_LIB_EXT1__=1
  74   74  memset_s.64 :=  CPPFLAGS += -D__STDC_WANT_LIB_EXT1__=1
  75   75  set_constraint_handler_s.32 := CPPFLAGS += -D__STDC_WANT_LIB_EXT1__=1
  76   76  set_constraint_handler_s.64 := CPPFLAGS += -D__STDC_WANT_LIB_EXT1__=1
  77   77  
  78   78  ROOTOPTDIR = $(ROOT)/opt/libc-tests/tests
  79   79  ROOTOPTPROGS = $(PROGS32:%=$(ROOTOPTDIR)/%) \
  80   80          $(PROGS64:%=$(ROOTOPTDIR)/%) \
  81   81          $(SCRIPTS:%=$(ROOTOPTDIR)/%)
  82   82  
  83   83  include $(SRC)/cmd/Makefile.cmd
  84   84  
  85   85  all     :=      TARGET = all
  86   86  install :=      TARGET = install
  87   87  clean   :=      TARGET = clean
  88   88  clobber :=      TARGET = clobber
  89   89  lint    :=      TARGET = lint
  90   90  
  91   91  .KEEP_STATE:
  92   92  
  93   93  install: $(SUBDIRS) $(ROOTOPTPROGS)
  94   94  
  95   95  all: $(SUBDIRS) $(PROGS32) $(PROGS64)
  96   96  
  97   97  clean lint: $(SUBDIRS)
  98   98  
  99   99  $(ROOTOPTPROGS): $(PROGS32) $(PROGS64) $(ROOTOPTDIR)
 100  100  
 101  101  $(ROOTOPTDIR):
 102  102          $(INS.dir)
 103  103  
 104  104  $(ROOTOPTDIR)/%: %
 105  105          $(INS.file)
 106  106  
 107  107  $(ROOTOPTDIR)/%: %.ksh
 108  108          $(INS.rename)
 109  109  
 110  110  %.64: %.c
 111  111          $(LINK64.c) -o $@ $< $(LDLIBS64)
 112  112          $(POST_PROCESS)
 113  113  
 114  114  %.32: %.c
 115  115          $(LINK.c) -o $@ $< $(LDLIBS)
 116  116          $(POST_PROCESS)
 117  117  
 118  118  clobber: $(SUBDIRS)
 119  119          $(RM) $(PROGS32) $(PROGS64)
 120  120  
 121  121  $(SUBDIRS): FRC
 122  122          @cd $@; pwd; $(MAKE) $(TARGET)
 123  123  
 124  124  FRC:

XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX