10703 smatch unreachable code checking needs reworking
Reviewed by: Toomas Soome <tsoome@me.com>
Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>

          --- old/usr/src/lib/fm/libfmd_snmp/common/debug_subr.c
          +++ new/usr/src/lib/fm/libfmd_snmp/common/debug_subr.c

   1    1  /*
   2    2   * CDDL HEADER START
   3    3   *
   4    4   * The contents of this file are subject to the terms of the
   5    5   * Common Development and Distribution License (the "License").
   6    6   * You may not use this file except in compliance with the License.
   7    7   *
   8    8   * You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
   9    9   * or http://www.opensolaris.org/os/licensing.
  10   10   * See the License for the specific language governing permissions
  11   11   * and limitations under the License.
  12   12   *
  13   13   * When distributing Covered Code, include this CDDL HEADER in each
  14   14   * file and include the License file at usr/src/OPENSOLARIS.LICENSE.
  15   15   * If applicable, add the following below this CDDL HEADER, with the
  16   16   * fields enclosed by brackets "[]" replaced with your own identifying

  17   17   * information: Portions Copyright [yyyy] [name of copyright owner]
  18   18   *
  19   19   * CDDL HEADER END
  20   20   */
  21   21  
  22   22  /*
  23   23   * Copyright 2009 Sun Microsystems, Inc.  All rights reserved.
  24   24   * Use is subject to license terms.
  25   25   */
  26   26  
       27 +/*
       28 + * Copyright 2019 Joyent, Inc.
       29 + */
       30 +
  27   31  #include <net-snmp/net-snmp-config.h>
  28   32  #include <net-snmp/net-snmp-includes.h>
  29   33  #include <net-snmp/agent/net-snmp-agent-includes.h>
  30   34  #include <stdarg.h>
  31   35  
  32   36  void
  33   37  sunFm_vpanic(const char *format, va_list ap)
  34   38  {
  35   39          (void) snmp_vlog(LOG_ERR, format, ap);
  36   40  #ifdef DEBUG
  37   41          abort();
  38      -        exit(1);
  39   42  #endif
  40   43  }
  41   44  
  42   45  void
  43   46  sunFm_panic(const char *format, ...)
  44   47  {
  45   48          va_list ap;
  46   49  
  47   50          va_start(ap, format);
  48   51          sunFm_vpanic(format, ap);
  49   52          va_end(ap);
  50   53  }
  51   54  
  52   55  int
  53   56  sunFm_assert(const char *expr, const char *file, int line)
  54   57  {
  55   58          sunFm_panic("\"%s\", line %d: assertion failed: %s\n", file, line,
  56   59              expr);
  57   60          return (0);
  58   61  }
    

XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX