Print this page
10703 smatch unreachable code checking needs reworking
Reviewed by: Toomas Soome <tsoome@me.com>
Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>

Split Close
Expand all
Collapse all
          --- old/usr/src/cmd/zonecfg/Makefile
          +++ new/usr/src/cmd/zonecfg/Makefile
↓ open down ↓ 14 lines elided ↑ open up ↑
  15   15  # If applicable, add the following below this CDDL HEADER, with the
  16   16  # fields enclosed by brackets "[]" replaced with your own identifying
  17   17  # information: Portions Copyright [yyyy] [name of copyright owner]
  18   18  #
  19   19  # CDDL HEADER END
  20   20  #
  21   21  #
  22   22  # Copyright 2008 Sun Microsystems, Inc.  All rights reserved.
  23   23  # Use is subject to license terms.
  24   24  #
  25      -# Copyright (c) 2018, Joyent, Inc.
       25 +# Copyright 2019 Joyent, Inc.
       26 +#
  26   27  
  27   28  PROG=   zonecfg
  28   29  OBJS=   zonecfg.o zonecfg_lex.o zonecfg_grammar.tab.o
  29   30  
  30   31  include ../Makefile.cmd
  31   32  
  32   33  # zonecfg has a name clash with main() and libl.so.1.  However, zonecfg must
  33   34  # still export a number of "yy*" (libl) interfaces.  Reduce all other symbols
  34   35  # to local scope.
  35   36  MAPFILES +=     $(MAPFILE.LEX) $(MAPFILE.NGB)
↓ open down ↓ 6 lines elided ↑ open up ↑
  42   43  LDFLAGS +=      $(MAPOPTS)
  43   44  CLEANFILES +=   zonecfg_lex.c zonecfg_grammar.tab.c zonecfg_grammar.tab.h
  44   45  
  45   46  CERRWARN +=     $(CNOWARN_UNINIT)
  46   47  CERRWARN +=     -_gcc=-Wno-unused-label
  47   48  CERRWARN +=     -_gcc=-Wno-unused-variable
  48   49  CERRWARN +=     -_gcc=-Wno-implicit-function-declaration
  49   50  
  50   51  SMOFF += all_func_returns
  51   52  
       53 +# false positive
       54 +zonecfg_lex.o := SMOFF += free
       55 +
  52   56  CLOBBERFILES += $(PROG).ln
  53   57  
  54   58  .KEEP_STATE:
  55   59  
  56   60  all: $(PROG)
  57   61  
  58   62  $(PROG): $(OBJS) $(MAPFILES)
  59   63          $(LINK.c) -o $@ $(OBJS) $(LDLIBS)
  60   64          $(POST_PROCESS)
  61   65  
↓ open down ↓ 24 lines elided ↑ open up ↑
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX