10703 smatch unreachable code checking needs reworking
Reviewed by: Toomas Soome <tsoome@me.com>
Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>

@@ -22,10 +22,12 @@
 /*
  *      Copyright (c) 1988 AT&T
  *        All Rights Reserved
  *
  * Copyright (c) 2010, Oracle and/or its affiliates. All rights reserved.
+ *
+ * Copyright 2019 Joyent, Inc.
  */
 
 /*
  * Map file parsing (Shared Core Code).
  */

@@ -2071,14 +2073,10 @@
                 default:        /* Non-OP token */
                         mf->mf_next++;
                         return (tok);
                 }
         }
-
-        /*NOTREACHED*/
-        assert(0);
-        return (TK_ERROR);
 }
 
 /*
  * Given a token and value returned by ld_map_gettoken(), return a string
  * representation of it suitable for use in an error message.