10703 smatch unreachable code checking needs reworking
Reviewed by: Toomas Soome <tsoome@me.com>
Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>

@@ -22,11 +22,11 @@
  * Copyright 2009 Sun Microsystems, Inc.  All rights reserved.
  * Use is subject to license terms.
  */
 
 /*
- * Copyright (c) 2018, Joyent, Inc.
+ * Copyright 2019 Joyent, Inc.
  */
 
 /*
  * Reparsed daemon
  */

@@ -185,11 +185,11 @@
             PRIV_FILE_LINK_ANY, PRIV_PROC_INFO, (char *)NULL);
 
         return (start_reparsed_svcs());
 }
 
-static void
+__NORETURN static void
 reparsed_door_call_error(int error, int buflen)
 {
         reparsed_door_res_t rpd_res;
 
         memset(&rpd_res, 0, sizeof (reparsed_door_res_t));

@@ -352,12 +352,8 @@
         (void) close(dfd);
 
         /*
          * Wait for incoming calls
          */
-        /*CONSTCOND*/
         while (1)
                 (void) pause();
-
-        syslog(LOG_ERR, "Door server exited");
-        return (10);
 }