10703 smatch unreachable code checking needs reworking
Reviewed by: Toomas Soome <tsoome@me.com>
Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>

          --- old/usr/src/Makefile.smatch
          +++ new/usr/src/Makefile.smatch

   1    1  #
   2    2  # This file and its contents are supplied under the terms of the
   3    3  # Common Development and Distribution License ("CDDL"), version 1.0.
   4    4  # You may only use this file in accordance with the terms of version
   5    5  # 1.0 of the CDDL.
   6    6  #
   7    7  # A full copy of the text of the CDDL should have accompanied this
   8    8  # source.  A copy of the CDDL is also available via the Internet at

   9    9  # http://www.illumos.org/license/CDDL.
  10   10  #
  11   11  # Copyright 2019 Joyent, Inc.
  12   12  #
  13   13  
  14   14  #
  15   15  # smatch/sparse checks we always disable, due to too many false positives (or
  16   16  # simply too much legacy).
  17   17  #
  18   18  
  19      -SMATCH_ARGS = --disable=uninitialized,check_check_deref,unreachable
       19 +SMATCH_ARGS = --disable=uninitialized,check_check_deref
  20   20  
  21   21  # VLAs are OK by us
  22   22  SMATCH_ARGS += -Wno-vla
  23   23  # don't care
  24   24  SMATCH_ARGS += -Wno-one-bit-signed-bitfield
  25   25  # there are lots of "extern void myfunc() { ... }" around
  26   26  SMATCH_ARGS += -Wno-external-function-has-definition
  27   27  # we have lots of legacy "void foo();" in headers
  28   28  SMATCH_ARGS += -Wno-old-style-definition
  29   29  SMATCH_ARGS += -Wno-strict-prototypes

  30   30  SMATCH_ARGS += --fatal-checks
  31   31  SMATCH_ARGS += --timeout=0
  32   32  
  33   33  CERRWARN += $(SMATCH_ARGS:%=-_smatch=%)
  34   34  
  35   35  CERRWARN += $(SMOFF:%=-_smatch=--disable=%)
  36   36  
  37   37  SMATCH_ =
  38   38  SMATCH_on =
  39   39  SMATCH_off = -_smatch=off
  40   40  
  41   41  CERRWARN += $(SMATCH_$(SMATCH))

XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX