Print this page
10689 srpt_cm_conn_closed_hdlr() needs a smatch fix

@@ -22,10 +22,14 @@
 /*
  * Copyright (c) 2009, 2010, Oracle and/or its affiliates. All rights reserved.
  */
 
 /*
+ * Copyright 2019, Joyent, Inc.
+ */
+
+/*
  * IB CM handlers for s Solaris SCSI RDMA Protocol Target (SRP)
  * transport port provider module for the COMSTAR framework.
  */
 
 #include <sys/cpuvar.h>

@@ -242,16 +246,12 @@
                  * ports reference to the channel and then release the
                  * reference held by the CM.
                  */
                 SRPT_DPRINTF_L3("cm_conn_closed_hdlr, remote close,"
                     " free channel");
-                if (ch != NULL) {
                         srpt_ch_cleanup(ch);
                         srpt_ch_release_ref(ch, 1);
-                } else {
-                        SRPT_DPRINTF_L2("cm_conn_closed_hdlr, NULL channel");
-                }
                 break;
 
         default:
                 SRPT_DPRINTF_L2("cm_conn_closed_hdlr, unknown close type (%d)",
                     event->cm_event.closed);