10685 SMB code needs smatch fixes

          --- old/usr/src/lib/smbclnt/libfksmbfs/Makefile.com
          +++ new/usr/src/lib/smbclnt/libfksmbfs/Makefile.com

   1    1  #
   2    2  # CDDL HEADER START
   3    3  #
   4    4  # The contents of this file are subject to the terms of the
   5    5  # Common Development and Distribution License (the "License").
   6    6  # You may not use this file except in compliance with the License.
   7    7  #
   8    8  # You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
   9    9  # or http://www.opensolaris.org/os/licensing.
  10   10  # See the License for the specific language governing permissions
  11   11  # and limitations under the License.
  12   12  #
  13   13  # When distributing Covered Code, include this CDDL HEADER in each
  14   14  # file and include the License file at usr/src/OPENSOLARIS.LICENSE.
  15   15  # If applicable, add the following below this CDDL HEADER, with the
  16   16  # fields enclosed by brackets "[]" replaced with your own identifying

  17   17  # information: Portions Copyright [yyyy] [name of copyright owner]
  18   18  #
  19   19  # CDDL HEADER END
  20   20  #
  21   21  #
  22   22  # Copyright 2008 Sun Microsystems, Inc.  All rights reserved.
  23   23  # Use is subject to license terms.
  24   24  #
  25   25  # Copyright 2018 Nexenta Systems, Inc.  All rights reserved.
  26   26  #
       27 +# Copyright 2019, Joyent, Inc.
       28 +#
  27   29  
  28   30  LIBRARY =       libfksmbfs.a
  29   31  VERS =          .1
  30   32  
  31   33  OBJS_LOCAL = \
  32   34          fksmbfs_rwlock.o \
  33   35          fake_fssub.o \
  34   36          fake_getdents.o \
  35   37          fake_lookup.o \
  36   38          fake_misc.o \

  37   39          fake_modconf.o \
  38   40          fake_nbmlock.o \
  39   41          fake_open.o \
  40   42          fake_rename.o \
  41   43          fake_rw.o \
  42   44          fake_stat.o \
  43   45          fake_unlink.o \
  44   46          fake_vfs.o \
  45   47          fake_vnode.o \
  46   48          fake_zone.o
  47   49  
  48   50  # See also: $SRC/uts/common/Makefile.files
  49   51  # NB: Intentionally ommitted, compared w/ the above:
  50   52  #  smbfs_rwlock.o
  51   53  #
  52   54  OBJS_FS_SMBFS = \
  53   55          smbfs_vfsops.o \
  54   56          smbfs_vnops.o \
  55   57          smbfs_client.o \
  56   58          smbfs_node.o \
  57   59          smbfs_smb.o \
  58   60          smbfs_smb1.o \
  59   61          smbfs_smb2.o \
  60   62          smbfs_subr.o \
  61   63          smbfs_subr2.o \
  62   64          smbfs_acl.o \
  63   65          smbfs_xattr.o
  64   66  
  65   67  OBJS_CMN_SMBFS = \
  66   68          smbfs_ntacl.o
  67   69  
  68   70  OBJS_MISC = \
  69   71          acl_common.o \
  70   72          pathname.o \
  71   73          refstr.o
  72   74  
  73   75  OBJECTS = \
  74   76          $(OBJS_LOCAL) \
  75   77          $(OBJS_FS_SMBFS) \
  76   78          $(OBJS_CMN_SMBFS) \
  77   79          $(OBJS_MISC)
  78   80  
  79   81  include ../../../Makefile.lib
  80   82  include ../../Makefile.lib
  81   83  
  82   84  # Force SOURCEDEBUG
  83   85  CSOURCEDEBUGFLAGS       = -g
  84   86  CCSOURCEDEBUGFLAGS      = -g
  85   87  STRIP_STABS     = :
  86   88  
  87   89  # Note: need our sys includes _before_ ENVCPPFLAGS, proto etc.
  88   90  # Also, like Makefile.uts, reset CPPFLAGS
  89   91  CPPFLAGS.first += -I../../../libfakekernel/common
  90   92  CPPFLAGS.first += -I../../libfknsmb/common
  91   93  CPPFLAGS.first += -I../common
  92   94  CPPFLAGS= $(CPPFLAGS.first)
  93   95  
  94   96  INCS += -I$(SRC)/uts/common/fs/smbclnt
  95   97  INCS += -I$(SRC)/uts/common
  96   98  INCS += -I$(SRC)/common/smbclnt

  97   99  INCS += -I$(SRC)/common
  98  100  
  99  101  CPPFLAGS += $(INCS) -D_REENTRANT -D_FAKE_KERNEL
 100  102  CPPFLAGS += -D_FILE_OFFSET_BITS=64
 101  103  # Always want DEBUG here
 102  104  CPPFLAGS += -DDEBUG
 103  105  
 104  106  CERRWARN += -_gcc=-Wno-switch
 105  107  CERRWARN += -_gcc=-Wno-parentheses
 106  108  
      109 +# needs work
      110 +SMOFF += all_func_returns,deref_check,signed,or_vs_and
      111 +
 107  112  LDLIBS +=       $(MACH_LDLIBS)
 108  113  LDLIBS +=       -lfknsmb -lfakekernel -lidmap -lcmdutils -lavl -lc
 109  114  
 110  115  FS_SMBFS_DIR=$(SRC)/uts/common/fs/smbclnt/smbfs
 111  116  CMN_SMBFS_DIR=$(SRC)/common/smbclnt
 112  117  SRCS=   $(OBJS_LOCAL:%.o=$(SRCDIR)/%.c) \
 113  118          $(OBJS_FS_SMBFS:%.o=$(FS_SMBFS_DIR)/%.c) \
 114  119          $(OBJS_CMN_SMBFS:%.o=$(CMN_SMBFS_DIR)/%.c)
 115  120  
 116  121  all:

 117  122  
 118  123  pics/%.o:       $(FS_SMBFS_DIR)/%.c
 119  124          $(COMPILE.c) -o $@ $<
 120  125          $(POST_PROCESS_O)
 121  126  
 122  127  # pathname.o
 123  128  pics/%.o:       $(SRC)/uts/common/fs/%.c
 124  129          $(COMPILE.c) -o $@ $<
 125  130          $(POST_PROCESS_O)
 126  131  
 127  132  # refstr.o
 128  133  pics/%.o:       $(SRC)/uts/common/os/%.c
 129  134          $(COMPILE.c) -o $@ $<
 130  135          $(POST_PROCESS_O)
 131  136  
 132  137  pics/acl_common.o:         $(SRC)/common/acl/acl_common.c
 133  138          $(COMPILE.c) -o $@ $(SRC)/common/acl/acl_common.c
 134  139          $(POST_PROCESS_O)
 135  140  
 136  141  .KEEP_STATE:
 137  142  
 138  143  include ../../Makefile.targ
 139  144  include ../../../Makefile.targ

XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX