10685 SMB code needs smatch fixes

          --- old/usr/src/lib/smbclnt/libfknsmb/Makefile.com
          +++ new/usr/src/lib/smbclnt/libfknsmb/Makefile.com

   1    1  #
   2    2  # CDDL HEADER START
   3    3  #
   4    4  # The contents of this file are subject to the terms of the
   5    5  # Common Development and Distribution License (the "License").
   6    6  # You may not use this file except in compliance with the License.
   7    7  #
   8    8  # You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
   9    9  # or http://www.opensolaris.org/os/licensing.
  10   10  # See the License for the specific language governing permissions
  11   11  # and limitations under the License.
  12   12  #
  13   13  # When distributing Covered Code, include this CDDL HEADER in each
  14   14  # file and include the License file at usr/src/OPENSOLARIS.LICENSE.
  15   15  # If applicable, add the following below this CDDL HEADER, with the
  16   16  # fields enclosed by brackets "[]" replaced with your own identifying

  17   17  # information: Portions Copyright [yyyy] [name of copyright owner]
  18   18  #
  19   19  # CDDL HEADER END
  20   20  #
  21   21  #
  22   22  # Copyright 2008 Sun Microsystems, Inc.  All rights reserved.
  23   23  # Use is subject to license terms.
  24   24  #
  25   25  # Copyright 2018 Nexenta Systems, Inc.  All rights reserved.
  26   26  #
       27 +# Copyright 2019, Joyent, Inc.
       28 +#
  27   29  
  28   30  LIBRARY =       libfknsmb.a
  29   31  VERS =          .1
  30   32  
  31   33  OBJS_LOCAL = \
  32   34          fksmb_sign_pkcs.o \
  33   35          fake_ddi.o \
  34   36          fake_fio.o \
  35   37          fake_kmem.o \
  36   38          fake_ktli.o \

  37   39          fake_pkey.o \
  38   40          fake_policy.o \
  39   41          fake_sdt.o \
  40   42          fake_softc.o \
  41   43          fake_stream.o \
  42   44          fake_strsubr.o
  43   45  
  44   46  # See also: $SRC/uts/common/Makefile.files
  45   47  # NB: Intentionally ommitted, compared w/ the above:
  46   48  #  smb_dev.o smb_pass.o smb_sign_kcf.o
  47   49  #
  48   50  OBJS_NSMB = \
  49   51          smb_dev.o \
  50   52          smb_conn.o \
  51   53          smb_iod.o \
  52   54          smb_rq.o \
  53   55          smb_sign.o \
  54   56          smb_smb.o \
  55   57          smb_subrs.o \
  56   58          smb_time.o \
  57   59          smb_tran.o \
  58   60          smb_trantcp.o \
  59   61          smb_usr.o \
  60   62          smb2_rq.o \
  61   63          smb2_sign.o \
  62   64          smb2_smb.o \
  63   65          subr_mchain.o
  64   66  
  65   67  OBJECTS = \
  66   68          $(OBJS_LOCAL) \
  67   69          $(OBJS_NSMB)
  68   70  
  69   71  include ../../../Makefile.lib
  70   72  include ../../Makefile.lib
  71   73  
  72   74  # Force SOURCEDEBUG
  73   75  CSOURCEDEBUGFLAGS       = -g
  74   76  CCSOURCEDEBUGFLAGS      = -g
  75   77  STRIP_STABS     = :
  76   78  
  77   79  # Note: need our sys includes _before_ ENVCPPFLAGS, proto etc.
  78   80  # Also, like Makefile.uts, reset CPPFLAGS
  79   81  CPPFLAGS.first += -I../../../libfakekernel/common
  80   82  CPPFLAGS.first += -I../common
  81   83  CPPFLAGS= $(CPPFLAGS.first)
  82   84  

  83   85  INCS += -I$(SRC)/uts/common/fs/smbclnt
  84   86  INCS += -I$(SRC)/uts/common
  85   87  
  86   88  CPPFLAGS += $(INCS) -D_REENTRANT -D_FAKE_KERNEL
  87   89  CPPFLAGS += -D_FILE_OFFSET_BITS=64
  88   90  # Always want DEBUG here
  89   91  CPPFLAGS += -DDEBUG
  90   92  
  91   93  CERRWARN += -_gcc=-Wno-switch
  92   94  
       95 +# needs work
       96 +SMOFF += all_func_returns,deref_check,signed
       97 +
  93   98  LDLIBS +=       $(MACH_LDLIBS)
  94   99  LDLIBS +=       -lfakekernel -lpkcs11 -lnsl -lc
  95  100  
  96  101  NSMB_DIR=$(SRC)/uts/common/fs/smbclnt/netsmb
  97  102  SRCS=   $(OBJS_LOCAL:%.o=$(SRCDIR)/%.c) \
  98  103          $(OBJS_NSMB:%.o=$(NSMB_DIR)/%.c)
  99  104  
 100  105  all:
 101  106  
 102  107  pics/%.o:       $(NSMB_DIR)/%.c
 103  108          $(COMPILE.c) -o $@ $<
 104  109          $(POST_PROCESS_O)
 105  110  
 106  111  .KEEP_STATE:
 107  112  
 108  113  include ../../Makefile.targ
 109  114  include ../../../Makefile.targ
    

XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX