Code Review for illumos-gate

Prepared by:John Levon on 2019-Mar-30 14:54 -0700 PDT
Workspace:/export/home/gk/src/illumos-gate (explicit head at a7fc1d3381a7)
Compare against: previous revision (at 720c4860f9da)
Summary of changes: 83 lines changed: 68 ins; 3 del; 12 mod; 5739 unchg
Patch of changes: illumos-gate.patch
Printable review: illumos-gate.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/io/pcplusmp/apic_common.c

10597 would like a way to set NMI behavior at boot
Reviewed by: Robert Mustacchi <rm@joyent.com>
Reviewed by: Andy Fiddaman <andy@omniosce.org>
33 lines changed: 25 ins; 0 del; 8 mod; 1796 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/os/fakebop.c

10597 would like a way to set NMI behavior at boot
Reviewed by: Robert Mustacchi <rm@joyent.com>
Reviewed by: Andy Fiddaman <andy@omniosce.org>
16 lines changed: 12 ins; 2 del; 2 mod; 2936 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/os/mlsetup.c

10597 would like a way to set NMI behavior at boot
Reviewed by: Robert Mustacchi <rm@joyent.com>
Reviewed by: Andy Fiddaman <andy@omniosce.org>
19 lines changed: 18 ins; 0 del; 1 mod; 537 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/sys/apic_common.h

10597 would like a way to set NMI behavior at boot
Reviewed by: Robert Mustacchi <rm@joyent.com>
Reviewed by: Andy Fiddaman <andy@omniosce.org>
11 lines changed: 9 ins; 1 del; 1 mod; 207 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/sys/bootconf.h

10597 would like a way to set NMI behavior at boot
Reviewed by: Robert Mustacchi <rm@joyent.com>
Reviewed by: Andy Fiddaman <andy@omniosce.org>
4 lines changed: 4 ins; 0 del; 0 mod; 263 unchg

This code review page was prepared using /export/home/gk/src/illumos-gate/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.