10468 __ctype_mask[EOF] has been working by accident
10469 GCC's -faggressive-loop-optimizations is too aggressive
10470 array over-read in has_saved_fp()
Reviewed by: Robert Mustacchi <rm@joyent.com>
Reviewed by: John Levon <john.levon@joyent.com>

          --- old/usr/src/lib/libsaveargs/Makefile.com
          +++ new/usr/src/lib/libsaveargs/Makefile.com

   1    1  #
   2    2  # CDDL HEADER START
   3    3  #
   4    4  # The contents of this file are subject to the terms of the
   5    5  # Common Development and Distribution License (the "License").
   6    6  # You may not use this file except in compliance with the License.
   7    7  #
   8    8  # You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
   9    9  # or http://www.opensolaris.org/os/licensing.
  10   10  # See the License for the specific language governing permissions
  11   11  # and limitations under the License.
  12   12  #
  13   13  # When distributing Covered Code, include this CDDL HEADER in each
  14   14  # file and include the License file at usr/src/OPENSOLARIS.LICENSE.

  15   15  # If applicable, add the following below this CDDL HEADER, with the
  16   16  # fields enclosed by brackets "[]" replaced with your own identifying
  17   17  # information: Portions Copyright [yyyy] [name of copyright owner]
  18   18  #
  19   19  # CDDL HEADER END
  20   20  #
  21   21  #
  22   22  # Copyright 2007 Sun Microsystems, Inc.  All rights reserved.
  23   23  # Use is subject to license terms.
  24   24  #
  25      -# Copyright (c) 2018, Joyent, Inc.
       25 +# Copyright (c) 2019, Joyent, Inc.
  26   26  
  27   27  #
  28   28  # The build process for libsaveargs is sightly different from that used by other
  29   29  # libraries, because libsaveargs must be built in two flavors - as a standalone
  30   30  # for use by kmdb and as a normal library.  We use $(CURTYPE) to indicate the
  31   31  # current flavor being built.
  32   32  #
  33   33  
  34   34  LIBRARY=        libsaveargs.a
  35   35  STANDLIBRARY=   libstandsaveargs.so

  36   36  VERS=           .1
  37   37  
  38   38  # By default, we build the shared library.  Construction of the standalone
  39   39  # is specifically requested by architecture-specific Makefiles.
  40   40  TYPES=          library
  41   41  CURTYPE=        library
  42   42  
  43   43  COMDIR=         $(SRC)/lib/libsaveargs/common
  44   44  
  45   45  OBJECTS_common_amd64    = saveargs.o
  46   46  SRCS_common_amd64       = $(OBJECTS_common_amd64:%.o=../amd64/%.c)
  47   47  
  48   48  OBJECTS= $(OBJECTS_common_$(MACH)) $(OBJECTS_common_$(MACH64)) $(OBJECTS_common_common)
  49   49  
  50   50  include $(SRC)/lib/Makefile.lib
  51   51  
  52   52  SRCS=   $(SRCS_common_$(MACH)) $(SRCS_common_$(MACH64)) $(SRC_common_common)
  53   53  
  54   54  #
  55   55  # Used to verify that the standalone doesn't have any unexpected external
  56   56  # dependencies.
  57   57  #
  58   58  LINKTEST_OBJ = objs/linktest_stand.o
  59   59  
  60   60  CLOBBERFILES_standalone = $(LINKTEST_OBJ)
  61   61  CLOBBERFILES += $(CLOBBERFILES_$(CURTYPE))
  62   62  
  63   63  LIBS_standalone = $(STANDLIBRARY)
  64   64  LIBS_library = $(DYNLIB) $(LINTLIB)
  65   65  LIBS = $(LIBS_$(CURTYPE))
  66   66  
  67   67  MAPFILES =      $(COMDIR)/mapfile-vers
  68   68  
  69   69  LDLIBS +=       -lc -ldisasm
  70   70  
  71   71  LDFLAGS_standalone = $(ZNOVERSION) $(BREDUCE) -dy -r
  72   72  LDFLAGS = $(LDFLAGS_$(CURTYPE))
  73   73  
  74   74  ASFLAGS_standalone = -DDIS_STANDALONE
  75   75  ASFLAGS_library =
  76   76  ASFLAGS += -P $(ASFLAGS_$(CURTYPE)) -D_ASM
  77   77  
  78   78  $(LINTLIB) := SRCS = $(COMDIR)/$(LINTSRC)
  79   79  
  80   80  # We want the thread-specific errno in the library, but we don't want it in
  81   81  # the standalone.  $(DTS_ERRNO) is designed to add -D_TS_ERRNO to $(CPPFLAGS),
  82   82  # in order to enable this feature.  Conveniently, -D_REENTRANT does the same
  83   83  # thing.  As such, we null out $(DTS_ERRNO) to ensure that the standalone
  84   84  # doesn't get it.
  85   85  DTS_ERRNO=
  86   86  
  87   87  CPPFLAGS_standalone = -DDIS_STANDALONE

  88   88  CPPFLAGS_library = -D_REENTRANT
  89   89  CPPFLAGS +=     -I$(COMDIR) $(CPPFLAGS_$(CURTYPE))
  90   90  
  91   91  CFLAGS_standalone = $(STAND_FLAGS_32)
  92   92  CFLAGS_common =
  93   93  CFLAGS += $(CFLAGS_$(CURTYPE)) $(CFLAGS_common)
  94   94  
  95   95  CFLAGS64_standalone = $(STAND_FLAGS_64)
  96   96  CFLAGS64 += $(CCVERBOSE) $(CFLAGS64_$(CURTYPE)) $(CFLAGS64_common)
  97   97  
  98      -# not linted
  99      -SMATCH=off
 100      -
 101   98  DYNFLAGS +=     $(ZINTERPOSE)
 102   99  
 103  100  .KEEP_STATE:
    

XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX