10138 smatch fixes for usr/src/cmd/sgs

@@ -24,10 +24,14 @@
  *        All Rights Reserved
  *
  * Copyright (c) 1992, 2010, Oracle and/or its affiliates. All rights reserved.
  */
 
+/*
+ * Copyright (c) 2018, Joyent, Inc.
+ */
+
 #include        <stdio.h>
 #include        <string.h>
 #include        "msg.h"
 #include        "_libld.h"
 

@@ -154,11 +158,11 @@
                  * that the link editor may produce (symbols of type ABS and
                  * COMMON are not recorded in the first place, however functions
                  * like _init() and _fini() commonly have multiple occurrences).
                  */
                 if ((sdp->sd_ref == REF_DYN_SEEN) ||
-                    (sdp->sd_aux && sdp->sd_aux->sa_symspec) ||
+                    (sdp->sd_aux->sa_symspec) ||
                     (strcmp(MSG_ORIG(MSG_SYM_FINI_U), name) == 0) ||
                     (strcmp(MSG_ORIG(MSG_SYM_INIT_U), name) == 0) ||
                     (strcmp(MSG_ORIG(MSG_SYM_LIBVER_U), name) == 0))
                         continue;