Code Review for illumos-gate

Prepared by:John Levon on 2019-Jan-25 18:07 +0000 GMT
Workspace:/export/home/gk/src/illumos-gate (explicit head at 408d2c8f9bef)
Compare against: previous revision (at 47a78c2dc77b)
Summary of changes: 51 lines changed: 13 ins; 14 del; 24 mod; 22375 unchg
Patch of changes: illumos-gate.patch
Printable review: illumos-gate.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/common/kmdb/kmdb_kvm.c

10132 smatch fixes for MDB
Reviewed by: Andy Fiddaman <andy@omniosce.org>
2 lines changed: 0 ins; 1 del; 1 mod; 2573 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/common/mdb/mdb.c

10132 smatch fixes for MDB
Reviewed by: Andy Fiddaman <andy@omniosce.org>
2 lines changed: 0 ins; 0 del; 2 mod; 1411 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/common/mdb/mdb_cmds.c

10132 smatch fixes for MDB
Reviewed by: Andy Fiddaman <andy@omniosce.org>
4 lines changed: 0 ins; 0 del; 4 mod; 3255 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/common/mdb/mdb_nm.c

10132 smatch fixes for MDB
Reviewed by: Andy Fiddaman <andy@omniosce.org>
5 lines changed: 4 ins; 0 del; 1 mod; 913 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/common/mdb/mdb_proc.c

10132 smatch fixes for MDB
Reviewed by: Andy Fiddaman <andy@omniosce.org>
2 lines changed: 0 ins; 1 del; 1 mod; 5507 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/common/mdb/mdb_tab.c

10132 smatch fixes for MDB
Reviewed by: Andy Fiddaman <andy@omniosce.org>
10 lines changed: 0 ins; 7 del; 3 mod; 653 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/common/modules/crypto/spi.c

10132 smatch fixes for MDB
Reviewed by: Andy Fiddaman <andy@omniosce.org>
5 lines changed: 4 ins; 0 del; 1 mod; 310 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/common/modules/fcp/fcp.c

10132 smatch fixes for MDB
Reviewed by: Andy Fiddaman <andy@omniosce.org>
6 lines changed: 0 ins; 1 del; 5 mod; 558 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/common/modules/fctl/fctl.c

10132 smatch fixes for MDB
Reviewed by: Andy Fiddaman <andy@omniosce.org>
4 lines changed: 3 ins; 0 del; 1 mod; 1353 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/common/modules/genunix/ndievents.c

10132 smatch fixes for MDB
Reviewed by: Andy Fiddaman <andy@omniosce.org>
4 lines changed: 2 ins; 0 del; 2 mod; 260 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/common/modules/libumem/umem.c

10132 smatch fixes for MDB
Reviewed by: Andy Fiddaman <andy@omniosce.org>
2 lines changed: 0 ins; 0 del; 2 mod; 4348 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/intel/mdb/proc_amd64dep.c

10132 smatch fixes for MDB
Reviewed by: Andy Fiddaman <andy@omniosce.org>
2 lines changed: 0 ins; 2 del; 0 mod; 639 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/intel/mdb/proc_ia32dep.c

10132 smatch fixes for MDB
Reviewed by: Andy Fiddaman <andy@omniosce.org>
3 lines changed: 0 ins; 2 del; 1 mod; 595 unchg

This code review page was prepared using /export/home/gk/src/illumos-gate/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.