Print this page
10089 phy_check() is bitwise, should be streetwise

@@ -22,10 +22,14 @@
  * Copyright 2010 Sun Microsystems, Inc.  All rights reserved.
  * Use is subject to license terms.
  */
 
 /*
+ * Copyright (c) 2018, Joyent, Inc.
+ */
+
+/*
  * mii - MII/PHY support for MAC drivers
  *
  * Utility module to provide a consistent interface to a MAC driver accross
  * different implementations of PHY devices
  */

@@ -1517,11 +1521,11 @@
                  * according to clause 28.5.4.5, the link partner ability
                  * register will still have the right bits set.  However,
                  * gigabit modes cannot use legacy parallel detection.
                  */
 
-                if ((ph->phy_type == XCVR_1000T) &
+                if ((ph->phy_type == XCVR_1000T) &&
                     (anexp & MII_AN_EXP_LPCANAN)) {
 
                         /* check for gige */
                         msstat = phy_read(ph, MII_MSSTATUS);