Code Review for illumos-gate

Prepared by:John Levon on 2019-Jan-10 18:58 +0000 GMT
Workspace:/export/home/gk/src/illumos-gate (explicit head at 78b349dd217f)
Compare against: previous revision (at fec53254416b)
Summary of changes: 0 lines changed: 0 ins; 0 del; 0 mod; 161791 unchg
Patch of changes: illumos-gate.patch
Printable review: illumos-gate.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/c2/audit_event.c

10081 smatch indenting fixes for usr/src/uts
0 lines changed: 0 ins; 0 del; 0 mod; 5871 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/nfs/nfs_dlinet.c

10081 smatch indenting fixes for usr/src/uts
0 lines changed: 0 ins; 0 del; 0 mod; 2822 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/fs/portfs/port_fop.c

10081 smatch indenting fixes for usr/src/uts
0 lines changed: 0 ins; 0 del; 0 mod; 2363 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/ip/ip_mroute.c

10081 smatch indenting fixes for usr/src/uts
0 lines changed: 0 ins; 0 del; 0 mod; 3397 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/inet/ip/ip_ndp.c

10081 smatch indenting fixes for usr/src/uts
0 lines changed: 0 ins; 0 del; 0 mod; 5078 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/1394/targets/av1394/av1394_isoch_chan.c

10081 smatch indenting fixes for usr/src/uts
0 lines changed: 0 ins; 0 del; 0 mod; 829 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/1394/targets/dcam1394/dcam.c

10081 smatch indenting fixes for usr/src/uts
0 lines changed: 0 ins; 0 del; 0 mod; 1248 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/aac/aac.c

10081 smatch indenting fixes for usr/src/uts
0 lines changed: 0 ins; 0 del; 0 mod; 8501 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/bnxe/577xx/hsi/hw/include/clc.h

10081 smatch indenting fixes for usr/src/uts
0 lines changed: 0 ins; 0 del; 0 mod; 731 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/cryptmod.c

10081 smatch indenting fixes for usr/src/uts
0 lines changed: 0 ins; 0 del; 0 mod; 3819 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/dld/dld_proto.c

10081 smatch indenting fixes for usr/src/uts
0 lines changed: 0 ins; 0 del; 0 mod; 1723 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/fd.c

10081 smatch indenting fixes for usr/src/uts
0 lines changed: 0 ins; 0 del; 0 mod; 2326 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/fibre-channel/fca/oce/oce_gld.c

10081 smatch indenting fixes for usr/src/uts
0 lines changed: 0 ins; 0 del; 0 mod; 748 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/fibre-channel/fca/oce/oce_mbx.c

10081 smatch indenting fixes for usr/src/uts
0 lines changed: 0 ins; 0 del; 0 mod; 1458 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/fibre-channel/fca/qlge/qlge.c

10081 smatch indenting fixes for usr/src/uts
0 lines changed: 0 ins; 0 del; 0 mod; 8090 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/ib/clients/rds/rdsddi.c

10081 smatch indenting fixes for usr/src/uts
0 lines changed: 0 ins; 0 del; 0 mod; 1015 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/ib/ibnex/ibnex.c

10081 smatch indenting fixes for usr/src/uts
0 lines changed: 0 ins; 0 del; 0 mod; 4249 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/iwp/iwp.c

10081 smatch indenting fixes for usr/src/uts
0 lines changed: 0 ins; 0 del; 0 mod; 5423 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/nge/nge_chip.c

10081 smatch indenting fixes for usr/src/uts
0 lines changed: 0 ins; 0 del; 0 mod; 2026 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/ntxn/unm_gem.c

10081 smatch indenting fixes for usr/src/uts
0 lines changed: 0 ins; 0 del; 0 mod; 1509 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/ntxn/unm_nic_hw.c

10081 smatch indenting fixes for usr/src/uts
0 lines changed: 0 ins; 0 del; 0 mod; 2205 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/ntxn/unm_nic_init.c

10081 smatch indenting fixes for usr/src/uts
0 lines changed: 0 ins; 0 del; 0 mod; 514 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/scsi/adapters/mpt_sas/mptsas.c

10081 smatch indenting fixes for usr/src/uts
0 lines changed: 0 ins; 0 del; 0 mod; 16969 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/skd/skd.c

10081 smatch indenting fixes for usr/src/uts
0 lines changed: 0 ins; 0 del; 0 mod; 5234 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/tl.c

10081 smatch indenting fixes for usr/src/uts
0 lines changed: 0 ins; 0 del; 0 mod; 6309 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/urtw/urtw.c

10081 smatch indenting fixes for usr/src/uts
0 lines changed: 0 ins; 0 del; 0 mod; 4562 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/usb/clients/hidparser/hidparser.c

10081 smatch indenting fixes for usr/src/uts
0 lines changed: 0 ins; 0 del; 0 mod; 3058 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/usb/clients/usbinput/usbwcm/usbwcm.c

10081 smatch indenting fixes for usr/src/uts
0 lines changed: 0 ins; 0 del; 0 mod; 1709 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/usb/clients/video/usbvc/usbvc.c

10081 smatch indenting fixes for usr/src/uts
0 lines changed: 0 ins; 0 del; 0 mod; 3880 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/usb/hcd/ehci/ehci_util.c

10081 smatch indenting fixes for usr/src/uts
0 lines changed: 0 ins; 0 del; 0 mod; 4703 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/usb/hcd/openhci/ohci_polled.c

10081 smatch indenting fixes for usr/src/uts
0 lines changed: 0 ins; 0 del; 0 mod; 2279 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/usb/usba/hubdi.c

10081 smatch indenting fixes for usr/src/uts
0 lines changed: 0 ins; 0 del; 0 mod; 9415 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/vr/vr.c

10081 smatch indenting fixes for usr/src/uts
0 lines changed: 0 ins; 0 del; 0 mod; 3660 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/krtld/kobj.c

10081 smatch indenting fixes for usr/src/uts
0 lines changed: 0 ins; 0 del; 0 mod; 4669 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/aio.c

10081 smatch indenting fixes for usr/src/uts
0 lines changed: 0 ins; 0 del; 0 mod; 3839 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/modconf.c

10081 smatch indenting fixes for usr/src/uts
0 lines changed: 0 ins; 0 del; 0 mod; 1475 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/os/streamio.c

10081 smatch indenting fixes for usr/src/uts
0 lines changed: 0 ins; 0 del; 0 mod; 8651 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/rpc/sec/authdesubr.c

10081 smatch indenting fixes for usr/src/uts
0 lines changed: 0 ins; 0 del; 0 mod; 390 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/rpc/sec_gss/rpcsec_gss.c

10081 smatch indenting fixes for usr/src/uts
0 lines changed: 0 ins; 0 del; 0 mod; 1580 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/vm/vm_seg.c

10081 smatch indenting fixes for usr/src/uts
0 lines changed: 0 ins; 0 del; 0 mod; 1864 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/cpu/generic_cpu/gcpu_main.c

10081 smatch indenting fixes for usr/src/uts
0 lines changed: 0 ins; 0 del; 0 mod; 218 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/io/mp_platform_common.c

10081 smatch indenting fixes for usr/src/uts
0 lines changed: 0 ins; 0 del; 0 mod; 2428 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/io/mp_platform_misc.c

10081 smatch indenting fixes for usr/src/uts
0 lines changed: 0 ins; 0 del; 0 mod; 2221 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/os/cms.c

10081 smatch indenting fixes for usr/src/uts
0 lines changed: 0 ins; 0 del; 0 mod; 655 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/io/dktp/disk/cmdk.c

10081 smatch indenting fixes for usr/src/uts
0 lines changed: 0 ins; 0 del; 0 mod; 2200 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/io/drm/radeon_state.c

10081 smatch indenting fixes for usr/src/uts
0 lines changed: 0 ins; 0 del; 0 mod; 3530 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/io/intel_nhm/intel_nhmdrv.c

10081 smatch indenting fixes for usr/src/uts
0 lines changed: 0 ins; 0 del; 0 mod; 348 unchg

This code review page was prepared using /export/home/gk/src/illumos-gate/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.